| Message ID | 20220425171344.1924057-2-pgwipeout@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add support for several new rk3566 SBCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/04/2022 19:13, Peter Geis wrote: > The Quartz64 Model B is a compact single board computer from Pine64 > based on the rk3566 SoC. It outputs on uart2 for the debug console. > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index eece92f83a2d..d6650a366753 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -507,6 +507,11 @@ properties: > - const: pine64,quartz64-a > - const: rockchip,rk3566 > > + - description: Pine64 Quartz64 Model B > + items: > + - const: pine64,quartz64-b Since it is a single board, not a SoM, this should be rather part of enum of Model A block. See also Radxa ROCK Pi entry. Keeping such approach - each single board in one item of oneOf - makes the file very, very long... Best regards, Krzysztof
On Mon, Apr 25, 2022 at 2:00 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 25/04/2022 19:13, Peter Geis wrote: > > The Quartz64 Model B is a compact single board computer from Pine64 > > based on the rk3566 SoC. It outputs on uart2 for the debug console. > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index eece92f83a2d..d6650a366753 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -507,6 +507,11 @@ properties: > > - const: pine64,quartz64-a > > - const: rockchip,rk3566 > > > > + - description: Pine64 Quartz64 Model B > > + items: > > + - const: pine64,quartz64-b > > Since it is a single board, not a SoM, this should be rather part of > enum of Model A block. > > See also Radxa ROCK Pi entry. > > Keeping such approach - each single board in one item of oneOf - makes > the file very, very long... Thanks for pointing this out, I will go this route. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index eece92f83a2d..d6650a366753 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -507,6 +507,11 @@ properties: - const: pine64,quartz64-a - const: rockchip,rk3566 + - description: Pine64 Quartz64 Model B + items: + - const: pine64,quartz64-b + - const: rockchip,rk3566 + - description: Radxa Rock items: - const: radxa,rock
The Quartz64 Model B is a compact single board computer from Pine64 based on the rk3566 SoC. It outputs on uart2 for the debug console. Signed-off-by: Peter Geis <pgwipeout@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)