| Message ID | 20220228124345.99474-4-singh.kuldeep87k@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | DTC fixes for Arm pl022 bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 2022-02-28 12:43, Kuldeep Singh wrote: > Fix below dtc warning by making necessary addition of "spiclk" in > clock-names property. > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml As before, what makes the binding at fault rather than that DT? The PL022's actual input is named SSPCLK, not SPICLK, so why should a driver which wants to look up that clock by name expect to look for "spiclk"? Robin. > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 5f6926a58b15..fb3075a0c7fd 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -45,6 +45,7 @@ properties: > - enum: > - sspclk > - SSPCLK > + - spiclk > - const: apb_pclk > > pl022,autosuspend-delay:
On Mon, Feb 28, 2022 at 02:36:23PM +0000, Robin Murphy wrote: > On 2022-02-28 12:43, Kuldeep Singh wrote: > > Fix below dtc warning by making necessary addition of "spiclk" in > > clock-names property. > > > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > As before, what makes the binding at fault rather than that DT? The PL022's > actual input is named SSPCLK, not SPICLK, so why should a driver which wants > to look up that clock by name expect to look for "spiclk"? That's right. It's the DT which is at the fault of defining spiclk instead of sspclk and need to be fixed in DT itself. I didn't take a look at pl022 doc and acted on the basis of DT info. Moreover, DT also uses sspclk and SSPCLK names interchangeably which are anyway same. This also require updation to follow single convention. Appreciate your comments and valuable inputs.
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 5f6926a58b15..fb3075a0c7fd 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -45,6 +45,7 @@ properties: - enum: - sspclk - SSPCLK + - spiclk - const: apb_pclk pl022,autosuspend-delay:
Fix below dtc warning by making necessary addition of "spiclk" in clock-names property. arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + 1 file changed, 1 insertion(+)