diff mbox series

[1/3] dt-bindings: power: apple,pmgr-pwrstate: Add apple,min-ps prop

Message ID 20211209044501.67028-2-marcan@marcan.st
State Not Applicable, archived
Headers show
Series Apple PMGR fixup: Implement support for min-ps | expand

Checks

Context Check Description
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success

Commit Message

Hector Martin Dec. 9, 2021, 4:44 a.m. UTC
A few devices (DCP/DCPEXT) need to have the minimum power state for
auto-PM configured. Add a property that allows the DT to specify this
value.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 .../devicetree/bindings/power/apple,pmgr-pwrstate.yaml    | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Hector Martin Dec. 9, 2021, 4:48 a.m. UTC | #1
On 09/12/2021 13.44, Hector Martin wrote:
> A few devices (DCP/DCPEXT) need to have the minimum power state for
> auto-PM configured. Add a property that allows the DT to specify this
> value.

Argh, just realized right after sending this that there is a mismatch 
between the commit description and the actual prop name (same with the 
third patch).

If everything else is good I'll be happy to fix the commit description 
before merging it.

> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>   .../devicetree/bindings/power/apple,pmgr-pwrstate.yaml    | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> index 5056d08b8261..19a194980142 100644
> --- a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> +++ b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> @@ -61,6 +61,14 @@ properties:
>         Forces this power domain to always be powered up.
>       type: boolean
>   
> +  apple,min-state:
> +    description:
> +      Specifies the minimum power state for auto-PM.
> +      0 = power gated, 4 = clock gated, 15 = on.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 15
> +
>   required:
>     - compatible
>     - reg
>
Rob Herring Dec. 9, 2021, 5:30 p.m. UTC | #2
On Thu, 09 Dec 2021 13:44:59 +0900, Hector Martin wrote:
> A few devices (DCP/DCPEXT) need to have the minimum power state for
> auto-PM configured. Add a property that allows the DT to specify this
> value.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../devicetree/bindings/power/apple,pmgr-pwrstate.yaml    | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
index 5056d08b8261..19a194980142 100644
--- a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
+++ b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
@@ -61,6 +61,14 @@  properties:
       Forces this power domain to always be powered up.
     type: boolean
 
+  apple,min-state:
+    description:
+      Specifies the minimum power state for auto-PM.
+      0 = power gated, 4 = clock gated, 15 = on.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 15
+
 required:
   - compatible
   - reg