| Message ID | 20211005230009.3635-4-digetx@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | tegra20-emc: Identify memory chip by LPDDR configuration | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 06/10/2021 01:00, Dmitry Osipenko wrote: > Add optional revision-id standard LPDDR2 properties which will help to > identify memory chip. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../memory-controllers/ddr/jedec,lpddr2.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml > index d99ccad54938..01efb43c3425 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml > @@ -24,6 +24,16 @@ properties: > - enum: > - jedec,lpddr2-nvm > > + revision-id1: > + maximum: 255 > + description: | > + Revision 1 value of SDRAM chip. Obtained from device datasheet. > + Also type/ref for uint32 needed. Best regards, Krzysztof
06.10.2021 13:59, Krzysztof Kozlowski пишет: > On 06/10/2021 01:00, Dmitry Osipenko wrote: >> Add optional revision-id standard LPDDR2 properties which will help to >> identify memory chip. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> .../memory-controllers/ddr/jedec,lpddr2.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >> index d99ccad54938..01efb43c3425 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >> @@ -24,6 +24,16 @@ properties: >> - enum: >> - jedec,lpddr2-nvm >> >> + revision-id1: >> + maximum: 255 >> + description: | >> + Revision 1 value of SDRAM chip. Obtained from device datasheet. >> + > > Also type/ref for uint32 needed. Also unnecessary :) It's uint32 by default, inferred from the 'maximum'.
06.10.2021 18:47, Dmitry Osipenko пишет: > 06.10.2021 13:59, Krzysztof Kozlowski пишет: >> On 06/10/2021 01:00, Dmitry Osipenko wrote: >>> Add optional revision-id standard LPDDR2 properties which will help to >>> identify memory chip. >>> >>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >>> --- >>> .../memory-controllers/ddr/jedec,lpddr2.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >>> index d99ccad54938..01efb43c3425 100644 >>> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >>> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml >>> @@ -24,6 +24,16 @@ properties: >>> - enum: >>> - jedec,lpddr2-nvm >>> >>> + revision-id1: >>> + maximum: 255 >>> + description: | >>> + Revision 1 value of SDRAM chip. Obtained from device datasheet. >>> + >> >> Also type/ref for uint32 needed. > > Also unnecessary :) It's uint32 by default, inferred from the 'maximum'. > Please grep for 'maximum: ' to see that other bindings don't specify the type.
diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml index d99ccad54938..01efb43c3425 100644 --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml @@ -24,6 +24,16 @@ properties: - enum: - jedec,lpddr2-nvm + revision-id1: + maximum: 255 + description: | + Revision 1 value of SDRAM chip. Obtained from device datasheet. + + revision-id2: + maximum: 255 + description: | + Revision 2 value of SDRAM chip. Obtained from device datasheet. + density: description: | Density in megabits of SDRAM chip. Obtained from device datasheet. @@ -138,6 +148,8 @@ examples: compatible = "Elpida,ECB240ABACN", "jedec,lpddr2-s4"; density = <2048>; io-width = <32>; + revision-id1 = <1>; + revision-id2 = <0>; tRPab-min-tck = <3>; tRCD-min-tck = <3>;
Add optional revision-id standard LPDDR2 properties which will help to identify memory chip. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../memory-controllers/ddr/jedec,lpddr2.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)