| Message ID | 20210714133849.1041619-6-s.riedmueller@phytec.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | media: mt9p031: Read back the real clock rate | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 99 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Wed, Jul 14, 2021 at 03:38:48PM +0200, Stefan Riedmueller wrote: > Convert mt9p031 sensor bindings to yaml schema. Also update the > MAINTAINERS entry. > > Although input-clock-frequency and pixel-clock-frequency have not been > definded as endpoint propierties in the textual bindings, the sensor > does parse them from the endpoint. Thus move these properties to the > endpoint in the new yaml bindings. > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> > --- > .../bindings/media/i2c/aptina,mt9p031.yaml | 92 +++++++++++++++++++ > .../devicetree/bindings/media/i2c/mt9p031.txt | 40 -------- > MAINTAINERS | 1 + > 3 files changed, 93 insertions(+), 40 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > delete mode 100644 Documentation/devicetree/bindings/media/i2c/mt9p031.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > new file mode 100644 > index 000000000000..1531ecd1ed95 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + > +description: | > + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image sensor > + with an active array size of 2592H x 1944V. It is programmable through a > + simple two-wire serial interface. > + > +properties: > + compatible: > + enum: > + - aptina,mt9p031 > + - aptina,mt9p031m > + > + reg: > + description: I2C device address > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + description: Chip reset GPIO > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + input-clock-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 6000000 > + maximum: 96000000 > + description: Input clock frequency > + > + pixel-clock-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maximum: 96000000 > + description: Target pixel clock frequency > + > + bus-type: > + const: 5 > + > + bus-width: > + const: 12 If there's only 1 possible setting for both of these, why do they need to be in DT? Rob
Hi Rob, On Fri, 2021-07-16 at 13:23 -0600, Rob Herring wrote: > On Wed, Jul 14, 2021 at 03:38:48PM +0200, Stefan Riedmueller wrote: > > Convert mt9p031 sensor bindings to yaml schema. Also update the > > MAINTAINERS entry. > > > > Although input-clock-frequency and pixel-clock-frequency have not been > > definded as endpoint propierties in the textual bindings, the sensor > > does parse them from the endpoint. Thus move these properties to the > > endpoint in the new yaml bindings. > > > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> > > --- > > .../bindings/media/i2c/aptina,mt9p031.yaml | 92 +++++++++++++++++++ > > .../devicetree/bindings/media/i2c/mt9p031.txt | 40 -------- > > MAINTAINERS | 1 + > > 3 files changed, 93 insertions(+), 40 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/media/i2c/mt9p031.txt > > > > diff --git > > a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > new file mode 100644 > > index 000000000000..1531ecd1ed95 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > @@ -0,0 +1,92 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > + > > +description: | > > + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image > > sensor > > + with an active array size of 2592H x 1944V. It is programmable through > > a > > + simple two-wire serial interface. > > + > > +properties: > > + compatible: > > + enum: > > + - aptina,mt9p031 > > + - aptina,mt9p031m > > + > > + reg: > > + description: I2C device address > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + description: Chip reset GPIO > > + > > + port: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + additionalProperties: false > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + input-clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 6000000 > > + maximum: 96000000 > > + description: Input clock frequency > > + > > + pixel-clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + maximum: 96000000 > > + description: Target pixel clock frequency > > + > > + bus-type: > > + const: 5 > > + > > + bus-width: > > + const: 12 > > If there's only 1 possible setting for both of these, why do they need > to be in DT? My idea was to have them here as constraints in case someone wants to add them to although there is no actual need to. That's why I added them optional. But to be honest, I wasn't sure if that's the correct approach, so if you'd prefer to drop them then it's fine with me. Regards, Stefan > > Rob
diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml new file mode 100644 index 000000000000..1531ecd1ed95 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml @@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor + +maintainers: + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> + +description: | + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 2592H x 1944V. It is programmable through a + simple two-wire serial interface. + +properties: + compatible: + enum: + - aptina,mt9p031 + - aptina,mt9p031m + + reg: + description: I2C device address + maxItems: 1 + + reset-gpios: + maxItems: 1 + description: Chip reset GPIO + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + input-clock-frequency: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 6000000 + maximum: 96000000 + description: Input clock frequency + + pixel-clock-frequency: + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 96000000 + description: Target pixel clock frequency + + bus-type: + const: 5 + + bus-width: + const: 12 + + pclk-sample: + default: 0 + + required: + - input-clock-frequency + - pixel-clock-frequency + +required: + - compatible + - reg + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + mt9p031@5d { + compatible = "aptina,mt9p031"; + reg = <0x5d>; + reset-gpios = <&gpio_sensor 0 0>; + + port { + mt9p031_1: endpoint { + input-clock-frequency = <6000000>; + pixel-clock-frequency = <96000000>; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt deleted file mode 100644 index cb60443ff78f..000000000000 --- a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt +++ /dev/null @@ -1,40 +0,0 @@ -* Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor - -The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image sensor with -an active array size of 2592H x 1944V. It is programmable through a simple -two-wire serial interface. - -Required Properties: -- compatible: value should be either one among the following - (a) "aptina,mt9p031" for mt9p031 sensor - (b) "aptina,mt9p031m" for mt9p031m sensor - -- input-clock-frequency: Input clock frequency. - -- pixel-clock-frequency: Pixel clock frequency. - -Optional Properties: -- reset-gpios: Chip reset GPIO - -For further reading on port node refer to -Documentation/devicetree/bindings/media/video-interfaces.txt. - -Example: - - i2c0@1c22000 { - ... - ... - mt9p031@5d { - compatible = "aptina,mt9p031"; - reg = <0x5d>; - reset-gpios = <&gpio3 30 0>; - - port { - mt9p031_1: endpoint { - input-clock-frequency = <6000000>; - pixel-clock-frequency = <96000000>; - }; - }; - }; - ... - }; diff --git a/MAINTAINERS b/MAINTAINERS index a61f4f3b78a9..33dd81237a91 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12635,6 +12635,7 @@ M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml F: drivers/media/i2c/mt9p031.c F: include/media/i2c/mt9p031.h
Convert mt9p031 sensor bindings to yaml schema. Also update the MAINTAINERS entry. Although input-clock-frequency and pixel-clock-frequency have not been definded as endpoint propierties in the textual bindings, the sensor does parse them from the endpoint. Thus move these properties to the endpoint in the new yaml bindings. Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> --- .../bindings/media/i2c/aptina,mt9p031.yaml | 92 +++++++++++++++++++ .../devicetree/bindings/media/i2c/mt9p031.txt | 40 -------- MAINTAINERS | 1 + 3 files changed, 93 insertions(+), 40 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml delete mode 100644 Documentation/devicetree/bindings/media/i2c/mt9p031.txt