From patchwork Tue May 25 00:01:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 1483023 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=FFPgxCLK; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FpvRD5VHlz9sTD for ; Tue, 25 May 2021 10:02:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbhEYAEP (ORCPT ); Mon, 24 May 2021 20:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbhEYAEJ (ORCPT ); Mon, 24 May 2021 20:04:09 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 475DAC061574 for ; Mon, 24 May 2021 17:02:38 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id l70so21318818pga.1 for ; Mon, 24 May 2021 17:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W6ypAeNUyTw13+ot10ZJQCb7zwm92rirhMuMnGlmdIU=; b=FFPgxCLKPIvWnLs03iIgcyr6GE8zQUZQ8sRvcNzu/YD7cj4TPN4zWLQ3tH6so65zkb vJQaqSDWEWJD9nuU1vz0F+NdT65YWQM54V+JBtu3Ft2hIkfFeseFYai001oLOoRBfQ1F yreunhpuNrtcArkMUGoQaiZc8CD5Gi/QCl/ko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W6ypAeNUyTw13+ot10ZJQCb7zwm92rirhMuMnGlmdIU=; b=LEmtO9fTEcnvQbcHTeedMiqhfn+HhGdgXgeFiB3BTj8dCeFQl44QIbap/wgzfPzOTN i2BINMp+71akw0c1B3OVBWlDVxBQE67RXL+PhIuiufRUKSewsTllcBKgtpEsTCLs/LIP BhP3LCpLVoKl4z90io8bf8DC+nEpmYl8XABkl9GpIT7sFGgFgqfStTyNW0sMeDyiVscW p4L77v1Tu/muWzGW4BdDXEedlIJavxgw7DMHfd6pZEb+okOjTcjBFDUuOmoc9XuYrENv ecpVPWwpN5ANPKUapDrHsY5N5NeKRh9vawvSR6saEgx6CAymNdtzLFtlWxPdfwAe/hT1 GzkQ== X-Gm-Message-State: AOAM531cvpYGj7zEXOTaMlyAEIy0/JoJT9UVXBYusqoNzVCuGnIW6Q+n fYAvRd5LAG20w7Cp7OuydhwyoQ== X-Google-Smtp-Source: ABdhPJz+LC13pDsPvIBJY/vfn0G6QTA8D2JN1gmx11Mo7iFbBxGuzCfte4L/NJ0jWk9GQJjvTVI8vw== X-Received: by 2002:aa7:8556:0:b029:2e2:45aa:d01e with SMTP id y22-20020aa785560000b02902e245aad01emr25395634pfn.14.1621900957855; Mon, 24 May 2021 17:02:37 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:26d1:4df0:7cdf:ce13]) by smtp.gmail.com with ESMTPSA id f18sm10696741pjh.55.2021.05.24.17.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 17:02:37 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Sam Ravnborg Cc: linux-arm-msm@vger.kernel.org, Linus W , Lyude Paul , Bjorn Andersson , Steev Klimaszewski , robdclark@chromium.org, Maarten Lankhorst , Thierry Reding , dri-devel@lists.freedesktop.org, Stanislav Lisovskiy , Stephen Boyd , Douglas Anderson , Daniel Vetter , David Airlie , Rob Herring , Thierry Reding , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 01/11] dt-bindings: display: simple: List hpd properties in panel-simple Date: Mon, 24 May 2021 17:01:49 -0700 Message-Id: <20210524165920.v8.1.Ieb731d23680db4700cc41fe51ccc73ba0b785fb7@changeid> X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog In-Reply-To: <20210525000159.3384921-1-dianders@chromium.org> References: <20210525000159.3384921-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The HPD (Hot Plug Detect) signal is present in many (probably even "most") eDP panels. For eDP, this signal isn't actually used for detecting hot-plugs of the panel but is more akin to a "panel ready" signal. After you provide power to the panel, panel timing diagrams typically say that you should wait for HPD to be asserted (or wait a fixed amount of time) before talking to the panel. The panel-simple bindings describes many eDP panels and many of these panels provide the HPD signal. We should add the HPD-related properties to the panel-simple bindings. The HPD properties are actually defined in panel-common.yaml, so adding them here just documents that they are OK for panels handled by the panel-simple bindings. NOTE: whether or not we'd include HPD properties in the panel node is more a property of the board design than the panel itself. For most boards using these eDP panels everything "magically" works without specifying any HPD properties and that's been why we haven't needed to allow the HPD properties earlier. On these boards the HPD signal goes directly to a dedicated "HPD" input to the eDP controller and this connection doesn't need to be described in the device tree. The only time the HPD properties are needed in the device tree are if HPD is hooked up to a GPIO or if HPD is normally on the panel but isn't used on a given board. That means that if we don't allow the HPD properties in panel-simple then one could argue that we've got to boot all eDP panels (or at least all those that someone could conceivably put on a system where HPD goes to a GPIO or isn't hooked up) from panel-simple. Signed-off-by: Douglas Anderson Reviewed-by: Rob Herring --- Changes in v8: - Explain better why HPD needs to be in panel-simple in commit msg. Changes in v7: - List hpd properties bindings patch new for v7. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index b3797ba2698b..4a0a5e1ee252 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -298,6 +298,8 @@ properties: enable-gpios: true port: true power-supply: true + no-hpd: true + hpd-gpios: true additionalProperties: false