diff mbox series

[1/2] dt-bindings: arm: fsl: Add imx8mn ddr3l evk board

Message ID 20200927094124.2714390-1-ping.bai@nxp.com
State Not Applicable, archived
Headers show
Series [1/2] dt-bindings: arm: fsl: Add imx8mn ddr3l evk board | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Jacky Bai Sept. 27, 2020, 9:41 a.m. UTC
Add entry for i.MX8MN DDR3L EVK board.

Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 29, 2020, 7:50 a.m. UTC | #1
On Sun, Sep 27, 2020 at 05:41:23PM +0800, Jacky Bai wrote:
> Add entry for i.MX8MN DDR3L EVK board.
> 
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 29, 2020, 7:54 a.m. UTC | #2
On Sun, Sep 27, 2020 at 05:41:24PM +0800, Jacky Bai wrote:
> For i.MX8MN DDR3L EVK board, it populates with the 11x11 package
> with no GPU, no display module compared to 14x14 package. For
> the board design, it is same as LPDDR4 board except that the
> display related interface is removed.
> 
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/Makefile             |  1 +
>  arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts | 11 +++++++++++
>  2 files changed, 12 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index f8d59433af01..4edcbd920a8f 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr3l-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
> new file mode 100644
> index 000000000000..854cb3a525f0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + /*
> +  * Copyright 2020 NXP
> +  */
> +
> +#include "imx8mn-evk.dts"

This should be an include of shared DTSI. You could avoid
splitting/renaming if you started with DTSI at beginning, knowing that
there will be multiple boards like that, with only minor differences.

> +
> +/ {
> +	model = "NXP i.MX8MNano DDR3L EVK board";

NXP advertises it as "i.MX 8M Nano" (with spaces).

Best regards,
Krzysztof
Rob Herring Sept. 29, 2020, 7:21 p.m. UTC | #3
On Sun, 27 Sep 2020 17:41:23 +0800, Jacky Bai wrote:
> Add entry for i.MX8MN DDR3L EVK board.
> 
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1ca9dfa8ce9a..8199528b47ed 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -417,6 +417,7 @@  properties:
       - description: i.MX8MN based Boards
         items:
           - enum:
+              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
               - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
               - fsl,imx8mn-evk            # i.MX8MN LPDDR4 EVK Board
           - const: fsl,imx8mn