| Message ID | 20200915193109.16034-1-james.quinlan@broadcom.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v1,1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, Sep 15, 2020 at 03:31:04PM -0400, Jim Quinlan wrote: > Bindings are added. Only one interrupt is needed because > we do not yet employ the SCMI p2a channel. > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> > --- > .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml > new file mode 100644 > index 000000000000..c2359f3a2b13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml# > + > +title: Broadcom STB SCMI mailbox driver bindings I thought SCMI was a mailbox consumer, not provider? > + > +maintainers: > + - Jim Quinlan <james.quinlan@broadcom.com> > + > +properties: > + compatible: > + enum: > + - brcm,brcmstb-mbox > + > + interrupts: > + items: > + - description: SCMI a2p return interrupt > + > + "#mbox-cells": > + const: 1 > + > +required: > + - compatible > + - interrupts > + - "#mbox-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + mailbox0: mailbox@0 { Drop the label and unit-address. Run 'make dt_binding_check' as it will tell you the latter. > + compatible = "brcm,brcmstb-mailbox"; > + #mbox-cells = <1>; > + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>; > + }; > +... > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml new file mode 100644 index 000000000000..c2359f3a2b13 --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$schema: "http://devicetree.org/meta-schemas/core.yaml#" +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml# + +title: Broadcom STB SCMI mailbox driver bindings + +maintainers: + - Jim Quinlan <james.quinlan@broadcom.com> + +properties: + compatible: + enum: + - brcm,brcmstb-mbox + + interrupts: + items: + - description: SCMI a2p return interrupt + + "#mbox-cells": + const: 1 + +required: + - compatible + - interrupts + - "#mbox-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + mailbox0: mailbox@0 { + compatible = "brcm,brcmstb-mailbox"; + #mbox-cells = <1>; + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>; + }; +...
Bindings are added. Only one interrupt is needed because we do not yet employ the SCMI p2a channel. Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> --- .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml