| Message ID | 20200724060532.3878-1-peter.chen@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v3,1/4] doc: dt-binding: ci-hdrc-usb2: add property for samsung picophy | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, 24 Jul 2020 14:05:29 +0800, Peter Chen wrote: > Add two parameters which are used to tune USB signal for samsung picophy, > which is used at imx7d, imx8mm, and imx8mn. > > Reviewed-by: Jun Li <jun.li@nxp.com> > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Changes for v3: > - Changing propery name to indicate it is a samsung phy > - Add property range and default value. > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On 20-07-24 14:05:31, Peter Chen wrote: > With these two parameters tuning, it can pass USB eye diagram at evk board. > > Reviewed-by: Jun Li <jun.li@nxp.com> > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Changes for v3: > - Using the new property name > Changes for v2 > - Address Shawn's comment to change subject. > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > index 0f1d7f8aeac4..7c652b898114 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > @@ -324,6 +324,8 @@ > srp-disable; > adp-disable; > usb-role-switch; > + samsung,picophy-pre-emp-curr-control = <3>; > + samsung,picophy-dc-vol-level-adjust = <7>; > status = "okay"; > > port { > -- Hi Shawn, Rob has already acked the binding-doc changes, would you please queue these two dts changes?
On Fri, Aug 21, 2020 at 01:39:44AM +0000, Peter Chen wrote: > On 20-07-24 14:05:31, Peter Chen wrote: > > With these two parameters tuning, it can pass USB eye diagram at evk board. > > > > Reviewed-by: Jun Li <jun.li@nxp.com> > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > > --- > > Changes for v3: > > - Using the new property name > > Changes for v2 > > - Address Shawn's comment to change subject. > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > index 0f1d7f8aeac4..7c652b898114 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > @@ -324,6 +324,8 @@ > > srp-disable; > > adp-disable; > > usb-role-switch; > > + samsung,picophy-pre-emp-curr-control = <3>; > > + samsung,picophy-dc-vol-level-adjust = <7>; > > status = "okay"; > > > > port { > > -- > > Hi Shawn, > > Rob has already acked the binding-doc changes, would you please queue > these two dts changes? Applied patch #3 and #4, thanks.
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index 51376cbe5f3d..a5c5db6a0b2d 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt @@ -100,6 +100,15 @@ i.mx specific properties It's recommended to specify the over current polarity. - power-active-high: power signal polarity is active high - external-vbus-divider: enables off-chip resistor divider for Vbus +- samsung,picophy-pre-emp-curr-control: HS Transmitter Pre-Emphasis Current + Control. This signal controls the amount of current sourced to the + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. + The range is from 0x0 to 0x3, the default value is 0x1. + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. +- samsung,picophy-dc-vol-level-adjust: HS DC Voltage Level Adjustment. + Adjust the high-speed transmitter DC level voltage. + The range is from 0x0 to 0xf, the default value is 0x3. + Details can refer to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. Example: