| Message ID | 20200603200319.16184-3-luca@lucaceresoli.net |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | regulator: lp87565: ignore ENx pins and add LP87524-Q1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, 03 Jun 2020, Luca Ceresoli wrote: > The "Required properties:" section is copied verbatim for each of the two > supported chips. In preparation to add a new chip variant make it a common > section and keep the two examples to differentiate between the two chips. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- > 1 file changed, 4 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt > index 41671e0dc26b..b75ae23a1ef3 100644 > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt > @@ -1,7 +1,7 @@ > TI LP87565 PMIC MFD driver > > Required properties: > - - compatible: "ti,lp87565", "ti,lp87565-q1" > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" What happened to your tabbing here? All the other entries start with a capital letter. So should this. > - reg: I2C slave address. > - gpio-controller: Marks the device node as a GPIO Controller. > - #gpio-cells: Should be two. The first cell is the pin number and > @@ -10,7 +10,8 @@ Required properties: > - xxx-in-supply: Phandle to parent supply node of each regulator > populated under regulators node. xxx should match > the supply_name populated in driver. > -Example: > + > +Example for the TI LP87565-Q1 PMIC (dual 2-phase output configuration): > > lp87565_pmic: pmic@60 { > compatible = "ti,lp87565-q1"; > @@ -42,21 +43,7 @@ lp87565_pmic: pmic@60 { > }; > }; > > -TI LP87561 PMIC: > - > -This is a single output 4-phase regulator configuration > - > -Required properties: > - - compatible: "ti,lp87561-q1" > - - reg: I2C slave address. > - - gpio-controller: Marks the device node as a GPIO Controller. > - - #gpio-cells: Should be two. The first cell is the pin number and > - the second cell is used to specify flags. > - See ../gpio/gpio.txt for more information. > - - xxx-in-supply: Phandle to parent supply node of each regulator > - populated under regulators node. xxx should match > - the supply_name populated in driver. > -Example: > +Example for the TI LP87561 PMIC (single 4-phase output configuration): > > lp87561_pmic: pmic@62 { > compatible = "ti,lp87561-q1";
On Thu, 04 Jun 2020, Lee Jones wrote: > On Wed, 03 Jun 2020, Luca Ceresoli wrote: > > > The "Required properties:" section is copied verbatim for each of the two > > supported chips. In preparation to add a new chip variant make it a common > > section and keep the two examples to differentiate between the two chips. > > > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > > --- > > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- > > 1 file changed, 4 insertions(+), 17 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt > > index 41671e0dc26b..b75ae23a1ef3 100644 > > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt > > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt > > @@ -1,7 +1,7 @@ > > TI LP87565 PMIC MFD driver > > > > Required properties: > > - - compatible: "ti,lp87565", "ti,lp87565-q1" > > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" > > What happened to your tabbing here? > > All the other entries start with a capital letter. So should this. This is also an MFD patch. Please change the subject line.
Hi Lee, thanks for the very prompt review! On 04/06/20 08:47, Lee Jones wrote: > On Wed, 03 Jun 2020, Luca Ceresoli wrote: > >> The "Required properties:" section is copied verbatim for each of the two >> supported chips. In preparation to add a new chip variant make it a common >> section and keep the two examples to differentiate between the two chips. >> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >> --- >> .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- >> 1 file changed, 4 insertions(+), 17 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt >> index 41671e0dc26b..b75ae23a1ef3 100644 >> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt >> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt >> @@ -1,7 +1,7 @@ >> TI LP87565 PMIC MFD driver >> >> Required properties: >> - - compatible: "ti,lp87565", "ti,lp87565-q1" >> + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" > > What happened to your tabbing here? Looks weird, but I actually fixed it. The patch format is misleading, it you look at the file you'll see there's a missing tab there before the patch. Hm, guess I should have mentioned it in the commit message, will do in v2. > All the other entries start with a capital letter. So should this. Right.
On Wed, Jun 03, 2020 at 10:03:17PM +0200, Luca Ceresoli wrote: > The "Required properties:" section is copied verbatim for each of the two > supported chips. In preparation to add a new chip variant make it a common > section and keep the two examples to differentiate between the two chips. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- > 1 file changed, 4 insertions(+), 17 deletions(-) If you want to clean this up, can you convert it to DT schema? > > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt > index 41671e0dc26b..b75ae23a1ef3 100644 > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt > @@ -1,7 +1,7 @@ > TI LP87565 PMIC MFD driver > > Required properties: > - - compatible: "ti,lp87565", "ti,lp87565-q1" > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" > - reg: I2C slave address. > - gpio-controller: Marks the device node as a GPIO Controller. > - #gpio-cells: Should be two. The first cell is the pin number and > @@ -10,7 +10,8 @@ Required properties: > - xxx-in-supply: Phandle to parent supply node of each regulator > populated under regulators node. xxx should match > the supply_name populated in driver. > -Example: > + > +Example for the TI LP87565-Q1 PMIC (dual 2-phase output configuration): > > lp87565_pmic: pmic@60 { > compatible = "ti,lp87565-q1"; > @@ -42,21 +43,7 @@ lp87565_pmic: pmic@60 { > }; > }; > > -TI LP87561 PMIC: > - > -This is a single output 4-phase regulator configuration > - > -Required properties: > - - compatible: "ti,lp87561-q1" > - - reg: I2C slave address. > - - gpio-controller: Marks the device node as a GPIO Controller. > - - #gpio-cells: Should be two. The first cell is the pin number and > - the second cell is used to specify flags. > - See ../gpio/gpio.txt for more information. > - - xxx-in-supply: Phandle to parent supply node of each regulator > - populated under regulators node. xxx should match > - the supply_name populated in driver. > -Example: > +Example for the TI LP87561 PMIC (single 4-phase output configuration): > > lp87561_pmic: pmic@62 { > compatible = "ti,lp87561-q1"; > -- > 2.27.0 >
Hi Rob, Keerthy, On 13/06/20 00:19, Rob Herring wrote: > On Wed, Jun 03, 2020 at 10:03:17PM +0200, Luca Ceresoli wrote: >> The "Required properties:" section is copied verbatim for each of the two >> supported chips. In preparation to add a new chip variant make it a common >> section and keep the two examples to differentiate between the two chips. >> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >> --- >> .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- >> 1 file changed, 4 insertions(+), 17 deletions(-) > > If you want to clean this up, can you convert it to DT schema? Sure, no problem. My only question is who should I set in the "maintainers" property. Keerty, as the original author and TI employee, you surely know this chip series much better than I do. Would you like to be the maintainer for this binding document? Otherwise I can do it "best effort". Regards,
On 6/15/2020 1:30 AM, Luca Ceresoli wrote: > Hi Rob, Keerthy, > > On 13/06/20 00:19, Rob Herring wrote: >> On Wed, Jun 03, 2020 at 10:03:17PM +0200, Luca Ceresoli wrote: >>> The "Required properties:" section is copied verbatim for each of the two >>> supported chips. In preparation to add a new chip variant make it a common >>> section and keep the two examples to differentiate between the two chips. >>> >>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >>> --- >>> .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- >>> 1 file changed, 4 insertions(+), 17 deletions(-) >> >> If you want to clean this up, can you convert it to DT schema? > > Sure, no problem. My only question is who should I set in the > "maintainers" property. > > Keerty, as the original author and TI employee, you surely know this > chip series much better than I do. Would you like to be the maintainer > for this binding document? Otherwise I can do it "best effort". Hi Luca, You can add me as the maintainer. Regards, Keerthy > > Regards, >
diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt index 41671e0dc26b..b75ae23a1ef3 100644 --- a/Documentation/devicetree/bindings/mfd/lp87565.txt +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt @@ -1,7 +1,7 @@ TI LP87565 PMIC MFD driver Required properties: - - compatible: "ti,lp87565", "ti,lp87565-q1" + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" - reg: I2C slave address. - gpio-controller: Marks the device node as a GPIO Controller. - #gpio-cells: Should be two. The first cell is the pin number and @@ -10,7 +10,8 @@ Required properties: - xxx-in-supply: Phandle to parent supply node of each regulator populated under regulators node. xxx should match the supply_name populated in driver. -Example: + +Example for the TI LP87565-Q1 PMIC (dual 2-phase output configuration): lp87565_pmic: pmic@60 { compatible = "ti,lp87565-q1"; @@ -42,21 +43,7 @@ lp87565_pmic: pmic@60 { }; }; -TI LP87561 PMIC: - -This is a single output 4-phase regulator configuration - -Required properties: - - compatible: "ti,lp87561-q1" - - reg: I2C slave address. - - gpio-controller: Marks the device node as a GPIO Controller. - - #gpio-cells: Should be two. The first cell is the pin number and - the second cell is used to specify flags. - See ../gpio/gpio.txt for more information. - - xxx-in-supply: Phandle to parent supply node of each regulator - populated under regulators node. xxx should match - the supply_name populated in driver. -Example: +Example for the TI LP87561 PMIC (single 4-phase output configuration): lp87561_pmic: pmic@62 { compatible = "ti,lp87561-q1";
The "Required properties:" section is copied verbatim for each of the two supported chips. In preparation to add a new chip variant make it a common section and keep the two examples to differentiate between the two chips. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- .../devicetree/bindings/mfd/lp87565.txt | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-)