| Message ID | 20191127135932.7223-5-m.felsch@pengutronix.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | DA9062 PMIC features | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Nov 27, 2019 at 2:59 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > At the gpio-based regulator enable/disable documentation. This property > can be applied to each subnode within the 'regulators' node so each > regulator can be configured differently. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> (...) > + - dlg,ena-sense-gpios : The GPIO reference which should be used by the > + regulator to enable/disable the output. If the signal is active the > + regulator is on else it is off. Attention: Sharing the same gpio for other > + purposes or across multiple regulators is possible but the gpio settings > + must be the same. Also the gpio phandle must refer to the mfd root node > + other gpios are not allowed and make no sense. - Point out that this concerns references to the GPI general purpose input on the DA9062 itself, and not just "any" GPIO. The last sentence tries to say this but it should be stated more clearly. - Clarify which "gpio settings" must be the same, e.g. polarity I guess. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt index 7e780fa6f57d..417e836e273a 100644 --- a/Documentation/devicetree/bindings/mfd/da9062.txt +++ b/Documentation/devicetree/bindings/mfd/da9062.txt @@ -75,6 +75,13 @@ Sub-nodes: same. Also the gpio phandle must refer to the mfd root node other gpios are not allowed and make no sense. + - dlg,ena-sense-gpios : The GPIO reference which should be used by the + regulator to enable/disable the output. If the signal is active the + regulator is on else it is off. Attention: Sharing the same gpio for other + purposes or across multiple regulators is possible but the gpio settings + must be the same. Also the gpio phandle must refer to the mfd root node + other gpios are not allowed and make no sense. + - rtc : This node defines settings required for the Real-Time Clock associated with the DA9062. There are currently no entries in this binding, however compatible = "dlg,da9062-rtc" should be added if a node is created. @@ -112,6 +119,7 @@ Example: regulator-min-microvolt = <900000>; regulator-max-microvolt = <3600000>; regulator-boot-on; + dlg,ena-sense-gpios = <&pmic0 2 GPIO_ACTIVE_LOW>; }; }; };
At the gpio-based regulator enable/disable documentation. This property can be applied to each subnode within the 'regulators' node so each regulator can be configured differently. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Documentation/devicetree/bindings/mfd/da9062.txt | 8 ++++++++ 1 file changed, 8 insertions(+)