| Message ID | 20191002144542.114722-1-mripard@kernel.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] dt-bindings: iio: ad7192: Fix Regulator Properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, 2 Oct 2019 16:45:41 +0200, Maxime Ripard wrote: > The AD7192 binding describes two regulator properties, avdd-supply and > dvdd-supply, but describes it as a constant string that must be avdd and > dvdd. This is wrong since a *-supply property is actually a phandle, and > results in warnings when the example is validated (or any device tree using > that device, for that matter). > > Let's remove that requirement. > > Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192") > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- > 1 file changed, 4 deletions(-) > Applied, thanks. Rob
On Wed, 2 Oct 2019 14:14:16 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, 2 Oct 2019 16:45:41 +0200, Maxime Ripard wrote: > > The AD7192 binding describes two regulator properties, avdd-supply and > > dvdd-supply, but describes it as a constant string that must be avdd and > > dvdd. This is wrong since a *-supply property is actually a phandle, and > > results in warnings when the example is validated (or any device tree using > > that device, for that matter). > > > > Let's remove that requirement. > > > > Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192") > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > --- > > Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- > > 1 file changed, 4 deletions(-) > > > > Applied, thanks. > > Rob Thanks for clearing this up. Jonathan
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml index 676ec42e1438..9e62f54c891a 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml @@ -43,13 +43,9 @@ properties: dvdd-supply: description: DVdd voltage supply - items: - - const: dvdd avdd-supply: description: AVdd voltage supply - items: - - const: avdd adi,rejection-60-Hz-enable: description: |
The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter). Let's remove that requirement. Fixes: f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192") Signed-off-by: Maxime Ripard <mripard@kernel.org> --- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- 1 file changed, 4 deletions(-)