| Message ID | 20190801072611.27935-2-avifishman70@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | add NPCM7xx EMC 10/100 Ethernet driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Aug 01, 2019 at 10:26:10AM +0300, Avi Fishman wrote: > Added device tree binding documentation for > Nuvoton NPCM7xx Ethernet MAC Controller (EMC) 10/100 RMII > > Signed-off-by: Avi Fishman <avifishman70@gmail.com> > --- > .../bindings/net/nuvoton,npcm7xx-emc.txt | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt Consider converting this to DT schema (YAML). > > diff --git a/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt b/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt > new file mode 100644 > index 000000000000..a7ac3ca66de9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt > @@ -0,0 +1,38 @@ > +Nuvoton NPCM7XX 10/100 Ethernet MAC Controller (EMC) > + > +The NPCM7XX provides one or two Ethernet MAC RMII Controllers > +for WAN/LAN applications > + > +Required properties: > +- device_type : Should be "network" Drop this. device_type is deprecated for FDT except for a few cases. > +- compatible : "nuvoton,npcm750-emc" for Poleg NPCM7XX. > +- reg : Offset and length of the register set for the device. > +- interrupts : Contain the emc interrupts with flags for falling edge. > + first interrupt dedicated to Txirq > + second interrupt dedicated to Rxirq > +- phy-mode : Should be "rmii" (see ethernet.txt in the same directory) > +- clocks : phandle of emc reference clock. > +- resets : phandle to the reset control for this device. > +- use-ncsi : Use the NC-SI stack instead of an MDIO PHY Vendor prefix needed. > + > +Example: > + > +emc0: eth@f0825000 { ethernet@... > + device_type = "network"; > + compatible = "nuvoton,npcm750-emc"; > + reg = <0xf0825000 0x1000>; > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; > + phy-mode = "rmii"; > + clocks = <&clk NPCM7XX_CLK_AHB>; > + > + #use-ncsi; /* add this to support ncsi */ Doesn't match the binding. > + > + clock-names = "clk_emc"; > + resets = <&rstc 6>; > + pinctrl-names = "default"; > + pinctrl-0 = <&r1_pins > + &r1err_pins > + &r1md_pins>; > + status = "okay"; Drop status in examples. > +}; > -- > 2.18.0 >
diff --git a/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt b/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt new file mode 100644 index 000000000000..a7ac3ca66de9 --- /dev/null +++ b/Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt @@ -0,0 +1,38 @@ +Nuvoton NPCM7XX 10/100 Ethernet MAC Controller (EMC) + +The NPCM7XX provides one or two Ethernet MAC RMII Controllers +for WAN/LAN applications + +Required properties: +- device_type : Should be "network" +- compatible : "nuvoton,npcm750-emc" for Poleg NPCM7XX. +- reg : Offset and length of the register set for the device. +- interrupts : Contain the emc interrupts with flags for falling edge. + first interrupt dedicated to Txirq + second interrupt dedicated to Rxirq +- phy-mode : Should be "rmii" (see ethernet.txt in the same directory) +- clocks : phandle of emc reference clock. +- resets : phandle to the reset control for this device. +- use-ncsi : Use the NC-SI stack instead of an MDIO PHY + +Example: + +emc0: eth@f0825000 { + device_type = "network"; + compatible = "nuvoton,npcm750-emc"; + reg = <0xf0825000 0x1000>; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + phy-mode = "rmii"; + clocks = <&clk NPCM7XX_CLK_AHB>; + + #use-ncsi; /* add this to support ncsi */ + + clock-names = "clk_emc"; + resets = <&rstc 6>; + pinctrl-names = "default"; + pinctrl-0 = <&r1_pins + &r1err_pins + &r1md_pins>; + status = "okay"; +};
Added device tree binding documentation for Nuvoton NPCM7xx Ethernet MAC Controller (EMC) 10/100 RMII Signed-off-by: Avi Fishman <avifishman70@gmail.com> --- .../bindings/net/nuvoton,npcm7xx-emc.txt | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nuvoton,npcm7xx-emc.txt