| Message ID | 20190301035852.26780-6-marek.behun@nic.cz |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Mar 1, 2019 at 4:59 AM Marek Behún <marek.behun@nic.cz> wrote: > This patch adds documentation of the device tree bindings for GPIOs > on the devices connected via Moxtet bus. > > Signed-off-by: Marek Behún <marek.behun@nic.cz> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > + compatible = "cznic,moxtet-gpio"; Is cznic registered in Documentation/devicetree/bindings/vendor-prefixes.txt? Yours, Linus Walleij
On Fri, 1 Mar 2019 15:36:09 +0100 Linus Walleij <linus.walleij@linaro.org> wrote: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > + compatible = "cznic,moxtet-gpio"; > > Is cznic registered in > Documentation/devicetree/bindings/vendor-prefixes.txt? Yes, it is registered. Thank you for the review. Marek
Hi Linus, do you know who is responsible for merging into drivers/bus? I have received reviews for this and for previous versions only from you and Rob. Also, please do not merge yet. I have prepared a fourth version with debugging over debugfs, fixed some checkpatch issues, and most importantnly added interrupt reading support from moxtet. I will send after proper testing is done for this new version. Marek On Fri, 1 Mar 2019 15:36:09 +0100 Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Mar 1, 2019 at 4:59 AM Marek Behún <marek.behun@nic.cz> wrote: > > > This patch adds documentation of the device tree bindings for GPIOs > > on the devices connected via Moxtet bus. > > > > Signed-off-by: Marek Behún <marek.behun@nic.cz> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > + compatible = "cznic,moxtet-gpio"; > > Is cznic registered in > Documentation/devicetree/bindings/vendor-prefixes.txt? > > Yours, > Linus Walleij
On Mon, Mar 4, 2019 at 12:17 AM Marek Behun <marek.behun@nic.cz> wrote:
> do you know who is responsible for merging into drivers/bus?
Usually the ARM SoC maintainers arm@kernel.org merge drivers
there. You should just send them a pull request and explain the
situation I think. Else they know who should deal with it.
Yours,
Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt b/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt new file mode 100644 index 000000000000..410759de9f09 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/gpio-moxtet.txt @@ -0,0 +1,18 @@ +Turris Mox Moxtet GPIO expander via Moxtet bus + +Required properties: + - compatible : Should be "cznic,moxtet-gpio". + - gpio-controller : Marks the device node as a GPIO controller. + - #gpio-cells : Should be two. For consumer use see gpio.txt. + +Other properties are required for a Moxtet bus device, please refer to +Documentation/devicetree/bindings/bus/moxtet.txt. + +Example: + + moxtet_sfp: gpio@0 { + compatible = "cznic,moxtet-gpio"; + gpio-controller; + #gpio-cells = <2>; + reg = <0>; + }
This patch adds documentation of the device tree bindings for GPIOs on the devices connected via Moxtet bus. Signed-off-by: Marek Behún <marek.behun@nic.cz> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org --- .../devicetree/bindings/gpio/gpio-moxtet.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-moxtet.txt