| Message ID | 20190222175153.20567-1-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v4,1/2] dt-bindings: drm: panel: Add Samsung s6e63m0 panel documentation | expand |
Hi Paweł, Thierry On Fri, Feb 22, 2019 at 06:51:53PM +0100, Paweł Chmiel wrote: > This patch adds Samsung S6E63M0 AMOLED LCD panel driver, connected over > spi. It's based on already removed, non dt s6e63m0 driver and > panel-samsung-ld9040. It can be found for example in some of Samsung > Aries based phones. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> I took a last look at the driver. Everything looks good to me now, and I consider this driver ready to be applied. Sam
On Fri, Feb 22, 2019 at 06:51:52PM +0100, Paweł Chmiel wrote: > From: Jonathan Bakker <xc-racer2@live.ca> > > This commit adds documentation for Samsung s6e63m0 AMOLED LCD panel > driver. > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes from v2: > - Added Reviewed-by > > Changes from v1: > - Add missing subject prefix > - Rename reset-gpio to reset-gpios > - Add link to spi properites documentation. They're required > for driver to work > - Removed delay properties, which are now hardcoded in driver > - Removed display timings, which are now hardcoded in driver > --- > .../display/panel/samsung,s6e63m0.txt | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt Applied both patches, thanks. Thierry
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt new file mode 100644 index 000000000000..9fb9ebeef8e4 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.txt @@ -0,0 +1,33 @@ +Samsung s6e63m0 AMOLED LCD panel + +Required properties: + - compatible: "samsung,s6e63m0" + - reset-gpios: GPIO spec for reset pin + - vdd3-supply: VDD regulator + - vci-supply: VCI regulator + +The panel must obey rules for SPI slave device specified in document [1]. + +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in [2]. This +node should describe panel's video bus. + +[1]: Documentation/devicetree/bindings/spi/spi-bus.txt +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + + s6e63m0: display@0 { + compatible = "samsung,s6e63m0"; + reg = <0>; + reset-gpio = <&mp05 5 1>; + vdd3-supply = <&ldo12_reg>; + vci-supply = <&ldo11_reg>; + spi-max-frequency = <1200000>; + + port { + lcd_ep: endpoint { + remote-endpoint = <&fimd_ep>; + }; + }; + };