From patchwork Tue Feb 5 15:43:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 1036824 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="y4zJK6je"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43v85Q5ycwz9sNR for ; Wed, 6 Feb 2019 02:44:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729987AbfBEPoN (ORCPT ); Tue, 5 Feb 2019 10:44:13 -0500 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:13872 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729972AbfBEPoM (ORCPT ); Tue, 5 Feb 2019 10:44:12 -0500 X-IronPort-AV: E=Sophos;i="5.56,564,1539673200"; d="scan'208";a="26335556" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES128-SHA; 05 Feb 2019 08:43:57 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.37) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 5 Feb 2019 08:43:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJL2tcMdb3Wh+LX1moI1rIvzhnbFvdBbNiJ+NP+jTdg=; b=y4zJK6jeOnz5sIqYhfI7RiQ+zlRi5whjfyoWz7FOR22jB5ytso6Cdg8snbJJcPWHoV68BItgBcaCPfj5zqup8a8uRo7v39JJtn6ZvvS2zfh2ZcpnkQaEYzm4aFSU+eOAAIbj7KbbtYAZKzj3DVemWmF2SSX2er4Im5qPHHVZo+Q= Received: from BN6PR11MB1842.namprd11.prod.outlook.com (10.175.98.146) by BN6PR11MB1235.namprd11.prod.outlook.com (10.173.26.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.16; Tue, 5 Feb 2019 15:43:54 +0000 Received: from BN6PR11MB1842.namprd11.prod.outlook.com ([fe80::847:4296:13b9:fc9f]) by BN6PR11MB1842.namprd11.prod.outlook.com ([fe80::847:4296:13b9:fc9f%8]) with mapi id 15.20.1580.019; Tue, 5 Feb 2019 15:43:54 +0000 From: To: , , , , , , , , CC: , , , , , Subject: [PATCH v5 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Thread-Topic: [PATCH v5 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Thread-Index: AQHUvWmZxI5L2C0oQkuo4lo++dIp7w== Date: Tue, 5 Feb 2019 15:43:54 +0000 Message-ID: <20190205154257.29529-11-tudor.ambarus@microchip.com> References: <20190205154257.29529-1-tudor.ambarus@microchip.com> In-Reply-To: <20190205154257.29529-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5P190CA0017.EURP190.PROD.OUTLOOK.COM (2603:10a6:206:14::30) To BN6PR11MB1842.namprd11.prod.outlook.com (2603:10b6:404:101::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tudor.Ambarus@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.9.5 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR11MB1235; 6:P+3zViMZpr+qlJS/ShjY75RD0CgkV+tx3F3tuO3h70Igrh3BoHvZI2NdTDKVRvZLQeGnBdToLd/FR2XUwguXbQzsWVaTGcMKyBZJ6k0/Sf/Vpcij4lualb20XbPJ6dAqB63k3ixDi9GFWs2LXFzFL9V/dfYuKfVlSRoJnVWqY/N6gYV6zH0LAa/XZgM2Lo7ytRSCJJLdSfy6ggRAbEFkTZLhbkSgIM5tLx1b8E0oIpiRemq/xYLi6sXb1zEYCYUt9yf8PtPnNOaROFfccaz6B2mjMdwmzE9GyQjSBHDxBR1N3zaLvT1lJVJ/Qsel4v7S50CjPWzkWfEhwHE5b/VrRGt1MMTaf8Ymi3k6Ibwz2E676Na6o0uFOtxHjtLpPWCfcDP3jl0bzHnWdhWUozmpMqrkD6u0m5fPrdKBvp9h2sjQ5c+G9WHY8SSg0+bmy7sRz4XJJcrjFdc+YsiFSbx1sQ==; 5:3K3y9xODEFT+W3hnAPGia14mwUZPkclm8610lyMCAlG/AQP6dS/QZp04TWAGSp6YvTYXg+VBGZ7bloU8Tk9bby4Bz99BZoJfshVmB3CijbeZ/dVeltTRLh7/VoF/OnEPheYVMGm1UUo3aFgNZ+mS4rvNFP7YjOEyr4ntzKh7ZqxkSs2y9c/YvcdV7MksRAvF8mIp2IWyqJajp55C2WF/ww==; 7:xpJ9lxgX5RDPwC402hw0FqvqrCsZOdDdnfAC/oGxM6R/+6hCNU60GEh20ETzYkixKd7oJDt08dfLvZE3swxGZYmtzxGr49hGHV2ArD1UWxaNo+EPcJdNZ3wCgUnZ1T0yoSd/g5CeG6M/4+5tK25JuA== x-ms-office365-filtering-correlation-id: f1bf5253-9129-4f1b-f4db-08d68b80bba8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB1235; x-ms-traffictypediagnostic: BN6PR11MB1235: x-microsoft-antispam-prvs: x-forefront-prvs: 0939529DE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(396003)(346002)(136003)(199004)(189003)(14454004)(7416002)(486006)(305945005)(11346002)(7736002)(2501003)(6506007)(186003)(102836004)(26005)(68736007)(71190400001)(2906002)(476003)(2616005)(106356001)(97736004)(105586002)(71200400001)(86362001)(54906003)(72206003)(446003)(36756003)(4326008)(6486002)(6436002)(386003)(478600001)(25786009)(1076003)(316002)(110136005)(8676002)(81156014)(52116002)(81166006)(8936002)(50226002)(66066001)(6512007)(256004)(53936002)(107886003)(99286004)(6116002)(3846002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR11MB1235; H:BN6PR11MB1842.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: VirgvViGsQ1Ujkuj80IYoCNFtK8yqVjZWF/m+p2wvzM+409QW3QgMV5K6XATSPE732o9LLGQsTkttzrJ1GB2fGmVvH9Ir/XTXarxlG57OV3+ZdS2Cr9c9KkRTRp9pj/5JQS/ATul6gkOprgNwOSgruPC8GXy7t5vm9KlvMGsGYItGalnIQL+uI0hTlnOjzql5oIArnU3k6ewTuefbGxxh+kPB3AlzFsqMBtD78aK8nVNWgOTPiFRBTP3u1FcoUAfryEQjs18lNphUt9vTGs3QPVaEnA7u7XMA7WsIEe9+juKAUc7yxXNx8j/3UjjGA+pZBcYDEa+XtCd6SzyMK4oUe770AGdqQ1BUeeV6As41Xwjyjj12W1nqxY0keHyoWw4cUsQC/7rDz7DtpwOaeufCkxSRj0PpChfbiZYJcj0RPo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1bf5253-9129-4f1b-f4db-08d68b80bba8 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2019 15:43:51.5950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1235 X-OriginatorOrg: microchip.com Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Tudor Ambarus Naming clocks is a good practice. Make "pclk" madatory even if we support unnamed clock in the driver, to be backward compatible with old DTs. Suggested-by: Boris Brezillon Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon --- v5: no change v4: add missing semicolon, collect R-b v3: new patch Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt index e9dae6264d89..50bd257e6826 100644 --- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt +++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt @@ -9,6 +9,7 @@ Required properties: - qspi_mmap: memory mapped address space - interrupts: Should contain the interrupt for the device. - clocks: The phandle of the clock needed by the QSPI controller. +- clock-names: Should contain "pclk" for the peripheral clock. - #address-cells: Should be <1>. - #size-cells: Should be <0>. @@ -20,6 +21,7 @@ spi@f0020000 { reg-names = "qspi_base", "qspi_mmap"; interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&pmc PMC_TYPE_PERIPHERAL 52>; + clock-names = "pclk"; #address-cells = <1>; #size-cells = <0>; pinctrl-names = "default";