From patchwork Wed Jan 23 22:11:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 1030212 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="kslQlDMz"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43lKJm6HV4z9sD4 for ; Thu, 24 Jan 2019 09:12:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfAWWMH (ORCPT ); Wed, 23 Jan 2019 17:12:07 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42309 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbfAWWMH (ORCPT ); Wed, 23 Jan 2019 17:12:07 -0500 Received: by mail-pg1-f195.google.com with SMTP id d72so1693718pga.9 for ; Wed, 23 Jan 2019 14:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nwEgonuYSGrKbJYDl4G3bbQHZLlfkk1X5XVhYfW28I8=; b=kslQlDMzIjeV/wdofyuFSig3T4gbiRun22xL6zxuqH+/BQjKZvrgfjxEn+BLqR9ig8 WYqmdGl/MPAZzd8WaYhwwaCyR/xpkW/JrqgN+V4HGB965QxnhMrrkVo/DEKuCs7i/kJn h7FwTVDIYPl2/dF3aSbp/sHUksrRYcV1VZixM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nwEgonuYSGrKbJYDl4G3bbQHZLlfkk1X5XVhYfW28I8=; b=AnLZZW0jhf/vmboggVvBT6A8Edmo2A3gx45MoSiY/QEgO2/K5eCYQR/Lh3BMIiVebK J4UpcXsm+uVhmFJs9GDdVBmKdJHhLEa+TKgyCfi+4ySPgvCOnKKnfNnl4ucfg5zWVG/q +krWP9vcVshFS6MJTsodbpYJu4x59i7ff1HAWlDWyaho6s6OYF8BrlgQgKRK6nbRKEAT WwgTsDmhEOkKsYmiHXfRhQxK1C3U1MUh4kYkjUyK8+ckvIojlUHFSHvOEl16oYaWG+KH LRY9BxO9Q9EsmoTjXI4sE5C0J124jhX3TJq3YGBJgPD9bwoYDKBtxbz2lxf+yxgZenQX YEVw== X-Gm-Message-State: AJcUukdiLs89C5PjvC0t7dZqTpFERlPFPFptnoMuHeyQmWMK+HqFgjCt j7GPsky0Qum1NQCsBcC857cWWQ== X-Google-Smtp-Source: ALg8bN5U/FBBt+r8Hj97ySEDpETRZckbgmxnT0QvxqbXfa2sJKmXKP5MrMwojRLrLRJMvAOEghniDg== X-Received: by 2002:a62:104a:: with SMTP id y71mr3798578pfi.34.1548281526447; Wed, 23 Jan 2019 14:12:06 -0800 (PST) Received: from evgreen2.mtv.corp.google.com ([2620:15c:202:201:ffda:7716:9afc:1301]) by smtp.gmail.com with ESMTPSA id d18sm27927943pfj.47.2019.01.23.14.12.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Jan 2019 14:12:05 -0800 (PST) From: Evan Green To: Andy Gross , Rob Herring , Kishon Vijay Abraham I Cc: Can Guo , Douglas Anderson , Asutosh Das , Stephen Boyd , Vivek Gautam , Evan Green , devicetree@vger.kernel.org, Mark Rutland , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/9] dt-bindings: phy-qcom-qmp: Add UFS PHY reset Date: Wed, 23 Jan 2019 14:11:30 -0800 Message-Id: <20190123221137.41722-3-evgreen@chromium.org> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20190123221137.41722-1-evgreen@chromium.org> References: <20190123221137.41722-1-evgreen@chromium.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a required reset to the SDM845 UFS phy to express the PHY reset bit inside the UFS controller register space. Before this change, this reset was not expressed in the DT, and the driver utilized two different callbacks (phy_init and phy_poweron) to implement a two-phase initialization procedure that involved deasserting this reset between init and poweron. This abused the two callbacks and diluted their purpose. That scheme does not work as regulators cannot be turned off in phy_poweroff because they were turned on in init, rather than poweron. The net result is that regulators are left on in suspend that shouldn't be. This new scheme gives the UFS reset to the PHY, so that it can fully initialize itself in a single callback. We can then turn regulators on during poweron and off during poweroff. Signed-off-by: Evan Green Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd --- I realize I'm not supposed to add a required property after the fact, but given that the UFS DT nodes that would use this binding are not yet upstream (and this would be the first), I was hoping to squeak by. Changes in v2: None Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index 4ff26dbf43106..49b8a5eed3cd1 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -56,7 +56,8 @@ Required properties: one for each entry in reset-names. - reset-names: "phy" for reset of phy block, "common" for phy common block reset, - "cfg" for phy's ahb cfg block reset. + "cfg" for phy's ahb cfg block reset, + "ufsphy" for the PHY reset in the UFS controller. For "qcom,ipq8074-qmp-pcie-phy" must contain: "phy", "common". @@ -70,7 +71,8 @@ Required properties: "phy", "common". For "qcom,sdm845-qmp-usb3-uni-phy" must contain: "phy", "common". - For "qcom,sdm845-qmp-ufs-phy": no resets are listed. + For "qcom,sdm845-qmp-ufs-phy": must contain: + "ufsphy". - vdda-phy-supply: Phandle to a regulator supply to PHY core block. - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.