| Message ID | 20181205154750.17996-3-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | media: radio-si470x-i2c: Add device tree and reset gpio support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Please combine 2/5 with 5/5. No need to have two patches for these bindings. Regards, Hans On 12/05/2018 04:47 PM, Paweł Chmiel wrote: > Add device tree bindings for si470x family radio receiver driver. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > .../devicetree/bindings/media/si470x.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/si470x.txt > > diff --git a/Documentation/devicetree/bindings/media/si470x.txt b/Documentation/devicetree/bindings/media/si470x.txt > new file mode 100644 > index 000000000000..9294fdfd3aae > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/si470x.txt > @@ -0,0 +1,24 @@ > +* Silicon Labs FM Radio receiver > + > +The Silicon Labs Si470x is family of FM radio receivers with receive power scan > +supporting 76-108 MHz, programmable through an I2C interface. > +Some of them includes an RDS encoder. > + > +Required Properties: > +- compatible: Should contain "silabs,si470x" > +- reg: the I2C address of the device > + > +Optional Properties: > +- interrupts : The interrupt number > + > +Example: > + > +&i2c2 { > + si470x@63 { > + compatible = "silabs,si470x"; > + reg = <0x63>; > + > + interrupt-parent = <&gpj2>; > + interrupts = <4 IRQ_TYPE_EDGE_FALLING>; > + }; > +}; >
Dnia piątek, 7 grudnia 2018 12:33:10 CET Hans Verkuil pisze: > Please combine 2/5 with 5/5. No need to have two patches for these bindings. I though that it will be better to separate patches which just adds devicetree support and those adding new functionality (reset), so for example if there is more work needed on one of them, the second one can still be picked (devicetree one). Ok will do this in next version of patchset. > > Regards, > > Hans > > On 12/05/2018 04:47 PM, Paweł Chmiel wrote: > > Add device tree bindings for si470x family radio receiver driver. > > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > .../devicetree/bindings/media/si470x.txt | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/si470x.txt > > > > diff --git a/Documentation/devicetree/bindings/media/si470x.txt b/Documentation/devicetree/bindings/media/si470x.txt > > new file mode 100644 > > index 000000000000..9294fdfd3aae > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/si470x.txt > > @@ -0,0 +1,24 @@ > > +* Silicon Labs FM Radio receiver > > + > > +The Silicon Labs Si470x is family of FM radio receivers with receive power scan > > +supporting 76-108 MHz, programmable through an I2C interface. > > +Some of them includes an RDS encoder. > > + > > +Required Properties: > > +- compatible: Should contain "silabs,si470x" > > +- reg: the I2C address of the device > > + > > +Optional Properties: > > +- interrupts : The interrupt number > > + > > +Example: > > + > > +&i2c2 { > > + si470x@63 { > > + compatible = "silabs,si470x"; > > + reg = <0x63>; > > + > > + interrupt-parent = <&gpj2>; > > + interrupts = <4 IRQ_TYPE_EDGE_FALLING>; > > + }; > > +}; > > > >
diff --git a/Documentation/devicetree/bindings/media/si470x.txt b/Documentation/devicetree/bindings/media/si470x.txt new file mode 100644 index 000000000000..9294fdfd3aae --- /dev/null +++ b/Documentation/devicetree/bindings/media/si470x.txt @@ -0,0 +1,24 @@ +* Silicon Labs FM Radio receiver + +The Silicon Labs Si470x is family of FM radio receivers with receive power scan +supporting 76-108 MHz, programmable through an I2C interface. +Some of them includes an RDS encoder. + +Required Properties: +- compatible: Should contain "silabs,si470x" +- reg: the I2C address of the device + +Optional Properties: +- interrupts : The interrupt number + +Example: + +&i2c2 { + si470x@63 { + compatible = "silabs,si470x"; + reg = <0x63>; + + interrupt-parent = <&gpj2>; + interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + }; +};
Add device tree bindings for si470x family radio receiver driver. Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> --- .../devicetree/bindings/media/si470x.txt | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/si470x.txt