diff mbox series

[v8,1/7] ASoC: dt-bindings: add regulator property to simple amplifier

Message ID 20181121051752.18387-2-anarsoul@gmail.com
State Superseded, archived
Headers show
Series Add support for audiocodec in Allwinner A64 | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Vasily Khoruzhick Nov. 21, 2018, 5:17 a.m. UTC
Amplifier may have associated regulator, so add a property for it.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 Documentation/devicetree/bindings/sound/simple-amplifier.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Mark Brown Nov. 26, 2018, 2:53 p.m. UTC | #1
On Tue, Nov 20, 2018 at 09:17:46PM -0800, Vasily Khoruzhick wrote:

> +Optional properties:
> +- VCC-supply   : power supply for the device, as covered
> +                 in Documentation/devicetree/bindings/regulator/regulator.txt
> +

As ever supplies shouldn't be marked as optional unless they can be
missing even though they can safely be omitted on Linux.  This one's a
bit odd in that the name is going to depend on which amp is connected
but still it's probably best that we do that for consistency.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt
index 8647edae7af0..7182ac4f1e65 100644
--- a/Documentation/devicetree/bindings/sound/simple-amplifier.txt
+++ b/Documentation/devicetree/bindings/sound/simple-amplifier.txt
@@ -4,9 +4,14 @@  Required properties:
 - compatible : "dioo,dio2125" or "simple-audio-amplifier"
 - enable-gpios : the gpio connected to the enable pin of the simple amplifier
 
+Optional properties:
+- VCC-supply   : power supply for the device, as covered
+                 in Documentation/devicetree/bindings/regulator/regulator.txt
+
 Example:
 
 amp: analog-amplifier {
 	compatible = "simple-audio-amplifier";
+	VCC-supply = <&regulator>;
 	enable-gpios = <&gpio GPIOH_3 0>;
 };