| Message ID | 20181105200549.17159-3-dinguyen@kernel.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Dinh, On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: > "altr,stratix10-rst-mgr" is used for the Stratix10 reset manager. > > Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> > --- > Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/socfpga-reset.txt b/Documentation/devicetree/bindings/reset/socfpga-reset.txt > index 98c9f560e5c5..38fe34fd8b8a 100644 > --- a/Documentation/devicetree/bindings/reset/socfpga-reset.txt > +++ b/Documentation/devicetree/bindings/reset/socfpga-reset.txt > @@ -1,7 +1,8 @@ > Altera SOCFPGA Reset Manager > > Required properties: > -- compatible : "altr,rst-mgr" > +- compatible : "altr,rst-mgr" for (Cyclone5/Arria5/Arria10) > + "altr,stratix10-rst-mgr","altr,rst-mgr" for Stratix10 ARM64 SoC git grep '\(altr\|intel\),stratix10' currently only shows "intel,stratix10-clkmgr". Should this be "intel,stratix10-rst-mgr"? I think keeping "altr," is fine for consistency, just wanted to point it out. > - reg : Should contain 1 register ranges(address and length) > - altr,modrst-offset : Should contain the offset of the first modrst register. > - #reset-cells: 1 regards Philipp
On 11/15/18 3:32 AM, Philipp Zabel wrote: > Hi Dinh, > > On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote: >> "altr,stratix10-rst-mgr" is used for the Stratix10 reset manager. >> >> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> >> --- >> Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/reset/socfpga-reset.txt b/Documentation/devicetree/bindings/reset/socfpga-reset.txt >> index 98c9f560e5c5..38fe34fd8b8a 100644 >> --- a/Documentation/devicetree/bindings/reset/socfpga-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/socfpga-reset.txt >> @@ -1,7 +1,8 @@ >> Altera SOCFPGA Reset Manager >> >> Required properties: >> -- compatible : "altr,rst-mgr" >> +- compatible : "altr,rst-mgr" for (Cyclone5/Arria5/Arria10) >> + "altr,stratix10-rst-mgr","altr,rst-mgr" for Stratix10 ARM64 SoC > > git grep '\(altr\|intel\),stratix10' > > currently only shows "intel,stratix10-clkmgr". Should this be > "intel,stratix10-rst-mgr"? I think keeping "altr," is fine for > consistency, just wanted to point it out. > Thanks for pointing it out. I think it's okay to keep it "altr". Dinh
diff --git a/Documentation/devicetree/bindings/reset/socfpga-reset.txt b/Documentation/devicetree/bindings/reset/socfpga-reset.txt index 98c9f560e5c5..38fe34fd8b8a 100644 --- a/Documentation/devicetree/bindings/reset/socfpga-reset.txt +++ b/Documentation/devicetree/bindings/reset/socfpga-reset.txt @@ -1,7 +1,8 @@ Altera SOCFPGA Reset Manager Required properties: -- compatible : "altr,rst-mgr" +- compatible : "altr,rst-mgr" for (Cyclone5/Arria5/Arria10) + "altr,stratix10-rst-mgr","altr,rst-mgr" for Stratix10 ARM64 SoC - reg : Should contain 1 register ranges(address and length) - altr,modrst-offset : Should contain the offset of the first modrst register. - #reset-cells: 1
"altr,stratix10-rst-mgr" is used for the Stratix10 reset manager. Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> --- Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)