| Message ID | 20181023051449.2116-3-qiangqing.zhang@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | can: flexcan: Add CAN self wakeup support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Oct 23, 2018 at 05:17:10AM +0000, Joakim Zhang wrote: > From: Dong Aisheng <aisheng.dong@nxp.com> > > The FlexCAN controller can parse the stop-mode property to enable CAN > self wakeup feature. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > --- > Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > index bfc0c433654f..b5ccfc9c14fb 100644 > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > @@ -24,6 +24,14 @@ Optional properties: > if this property is present then controller is assumed to be big > endian. > > +- stop-mode: register bits of stop mode control, the format is Should have a vendor prefix: fsl,stop-mode > + <&gpr req_gpr req_bit ack_gpr ack_bit>. > + gpr is the phandle to general purpose register node. > + req_gpr is the gpr register offset of CAN stop request. > + req_bit is the bit offset of CAN stop request. > + ack_gpr is the gpr register offset of CAN stop acknowledge. > + ack_bit is the bit offset of CAN stop acknowledge. > + > Example: > > can@1c000 { > -- > 2.17.1 >
-----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: 2018年10月25日 7:57 To: Joakim Zhang <qiangqing.zhang@nxp.com> Cc: linux-can@vger.kernel.org; wg@grandegger.com; mkl@pengutronix.de; mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; A.s. Dong <aisheng.dong@nxp.com> Subject: Re: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree On Tue, Oct 23, 2018 at 05:17:10AM +0000, Joakim Zhang wrote: > From: Dong Aisheng <aisheng.dong@nxp.com> > > The FlexCAN controller can parse the stop-mode property to enable CAN > self wakeup feature. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > --- > Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 8 > ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > index bfc0c433654f..b5ccfc9c14fb 100644 > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > @@ -24,6 +24,14 @@ Optional properties: > if this property is present then controller is assumed to be big > endian. > > +- stop-mode: register bits of stop mode control, the format is Should have a vendor prefix: fsl,stop-mode Okay, I will add it. Thanks a lot! Best Regards, Joakim Zhang > + <&gpr req_gpr req_bit ack_gpr ack_bit>. > + gpr is the phandle to general purpose register node. > + req_gpr is the gpr register offset of CAN stop request. > + req_bit is the bit offset of CAN stop request. > + ack_gpr is the gpr register offset of CAN stop acknowledge. > + ack_bit is the bit offset of CAN stop acknowledge. > + > Example: > > can@1c000 { > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt index bfc0c433654f..b5ccfc9c14fb 100644 --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt @@ -24,6 +24,14 @@ Optional properties: if this property is present then controller is assumed to be big endian. +- stop-mode: register bits of stop mode control, the format is + <&gpr req_gpr req_bit ack_gpr ack_bit>. + gpr is the phandle to general purpose register node. + req_gpr is the gpr register offset of CAN stop request. + req_bit is the bit offset of CAN stop request. + ack_gpr is the gpr register offset of CAN stop acknowledge. + ack_bit is the bit offset of CAN stop acknowledge. + Example: can@1c000 {