Message ID | 20180406151356.7818-3-ilina@codeaurora.org |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [v7,[RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs | expand |
Quoting Lina Iyer (2018-04-06 08:13:56) > From: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > Command DB provides information on shared resources like clocks, > regulators etc., probed at boot by the remote subsytem and made > available in shared memory. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > + reserved-memory { > + [...] > + qcom,cmd-db@85fe0000 { Nitpick: This may want to be called 'memory@85fe0000' because we prefer generic node names. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd <swboyd@chromium.org> wrote: > Quoting Lina Iyer (2018-04-06 08:13:56) > > From: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > > > Command DB provides information on shared resources like clocks, > > regulators etc., probed at boot by the remote subsytem and made > > available in shared memory. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > + reserved-memory { > > + [...] > > + qcom,cmd-db@85fe0000 { > Nitpick: This may want to be called 'memory@85fe0000' because we prefer > generic node names. Another nit: the cmd-db region seems to need "no-map" to make the example actually work. Reviewed-by: Evan Green <evgreen@chromium.org> -Evan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 06, 2018 at 04:16:42PM -0700, Stephen Boyd wrote: > Quoting Lina Iyer (2018-04-06 08:13:56) > > From: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > > > Command DB provides information on shared resources like clocks, > > regulators etc., probed at boot by the remote subsytem and made > > available in shared memory. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > + reserved-memory { > > + [...] > > + qcom,cmd-db@85fe0000 { > > Nitpick: This may want to be called 'memory@85fe0000' because we prefer > generic node names. Well, "memory" is for nodes of memory that aren't reserved. So "reserved-memory@..." would be better. Otherwise, Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt new file mode 100644 index 000000000000..1390cd3a7f0e --- /dev/null +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt @@ -0,0 +1,36 @@ +Command DB +--------- + +Command DB is a database that provides a mapping between resource key and the +resource address for a system resource managed by a remote processor. The data +is stored in a shared memory region and is loaded by the remote processor. + +Some of the Qualcomm Technologies Inc SoC's have hardware accelerators for +controlling shared resources. Depending on the board configuration the shared +resource properties may change. These properties are dynamically probed by the +remote processor and made available in the shared memory. + +The bindings for Command DB is specified in the reserved-memory section in +devicetree. The devicetree representation of the command DB driver should be: + +Properties: +- compatible: + Usage: required + Value type: <string> + Definition: Should be "qcom,cmd-db" + +- reg: + Usage: required + Value type: <prop encoded array> + Definition: The register address that points to the actual location of + the Command DB in memory. + +Example: + + reserved-memory { + [...] + qcom,cmd-db@85fe0000 { + reg = <0x0 0x85fe0000 0x0 0x20000>; + compatible = "qcom,cmd-db"; + }; + };