| Message ID | 20171201224425.5477-2-peda@axentia.se |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | Add devicetree for Axentia Nattis | expand |
On Fri, Dec 1, 2017 at 8:44 PM, Peter Rosin <peda@axentia.se> wrote: > Add record for NXP TFA9879 Mono BTL Class D audio amplifier. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > Documentation/devicetree/bindings/trivial-devices.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > index af284fbd4d23..4cf30ce4e71f 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > @@ -157,6 +157,7 @@ nxp,pcf2127 Real-time clock > nxp,pcf2129 Real-time clock > nxp,pcf8563 Real-time clock/calendar > nxp,pcf85063 Tiny Real-Time Clock > +nxp,tfa9879 Mono BTL Class D audio amplifier This is already described at Documentation/devicetree/bindings/sound/tfa9879.txt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-12-02 22:17, Fabio Estevam wrote: > On Fri, Dec 1, 2017 at 8:44 PM, Peter Rosin <peda@axentia.se> wrote: >> Add record for NXP TFA9879 Mono BTL Class D audio amplifier. >> >> Signed-off-by: Peter Rosin <peda@axentia.se> >> --- >> Documentation/devicetree/bindings/trivial-devices.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt >> index af284fbd4d23..4cf30ce4e71f 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.txt >> +++ b/Documentation/devicetree/bindings/trivial-devices.txt >> @@ -157,6 +157,7 @@ nxp,pcf2127 Real-time clock >> nxp,pcf2129 Real-time clock >> nxp,pcf8563 Real-time clock/calendar >> nxp,pcf85063 Tiny Real-Time Clock >> +nxp,tfa9879 Mono BTL Class D audio amplifier > > This is already described at Documentation/devicetree/bindings/sound/tfa9879.txt Right. However, the patch adding that should have been sent to me, the maintainer of the driver. That is carefully recorded in MAINTAINERS. So, forgive me for assuming that nothing had changed in the driver behind my back. Had that patch been sent my way as it should have been, I would have insisted that maintenance of the bindings had been kept together with the maintenance of the driver. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-12-03 12:12, Fabio Estevam wrote: > Hi Peter, > > On Sun, Dec 3, 2017 at 4:59 AM, Peter Rosin <peda@axentia.se> wrote: > >> Right. However, the patch adding that should have been sent to me, the >> maintainer of the driver. That is carefully recorded in MAINTAINERS. So, >> forgive me for assuming that nothing had changed in the driver behind my >> back. >> >> Had that patch been sent my way as it should have been, I would have >> insisted that maintenance of the bindings had been kept together with >> the maintenance of the driver. > > When I sent this patch ./scripts/get_maintainer.pl did lot list your > name, so that's why I did not put you on Cc, sorry. > > 4.15-rc1 still does not list you, but linux-next does. That's funny, because I get the below on both 4.14 and 4.15-rc1. And I expect the same ever since the driver was added some 3 years ago. $ scripts/get_maintainer.pl your-patch-from[1].diff | grep Peter Peter Rosin <peda@axentia.se> (maintainer:NXP TFA9879 DRIVER) [1] https://patchwork.ozlabs.org/patch/815930/ By the way, scripts/checkpatch.pl on that patch reports WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > Would you like me to send the following patch so that new binding > updates go to you? Naahh, I'll claim it myself, that way I can clean up some nits in the actual file while at it... Cheers, Peter > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9808,6 +9808,7 @@ NXP TFA9879 DRIVER > M: Peter Rosin <peda@axentia.se> > L: alsa-devel@alsa-project.org (moderated for non-subscribers) > S: Maintained > +F: Documentation/devicetree/bindings/sound/tfa9879.txt > F: sound/soc/codecs/tfa9879* > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Dec 3, 2017 at 6:53 PM, Peter Rosin <peda@axentia.se> wrote: > That's funny, because I get the below on both 4.14 and 4.15-rc1. And I > expect the same ever since the driver was added some 3 years ago. > > $ scripts/get_maintainer.pl your-patch-from[1].diff | grep Peter > Peter Rosin <peda@axentia.se> (maintainer:NXP TFA9879 DRIVER) You are right. I tried ./scripts/get_maintainer.pl Documentation/devicetree/bindings/sound/tfa9879.txt in 4.15-rc1. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index af284fbd4d23..4cf30ce4e71f 100644 --- a/Documentation/devicetree/bindings/trivial-devices.txt +++ b/Documentation/devicetree/bindings/trivial-devices.txt @@ -157,6 +157,7 @@ nxp,pcf2127 Real-time clock nxp,pcf2129 Real-time clock nxp,pcf8563 Real-time clock/calendar nxp,pcf85063 Tiny Real-Time Clock +nxp,tfa9879 Mono BTL Class D audio amplifier oki,ml86v7667 OKI ML86V7667 video decoder ovti,ov5642 OV5642: Color CMOS QSXGA (5-megapixel) Image Sensor with OmniBSI and Embedded TrueFocus pericom,pt7c4338 Real-time Clock Module
Add record for NXP TFA9879 Mono BTL Class D audio amplifier. Signed-off-by: Peter Rosin <peda@axentia.se> --- Documentation/devicetree/bindings/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+)