diff mbox series

[v2,6/8] dt-bindings: power: Add Actions Semi S700 SPS

Message ID 20171113233427.5386-7-afaerber@suse.de
State Not Applicable, archived
Headers show
Series arm64: Add initial Actions Semi S700 and CubieBoard7 support | expand

Commit Message

Andreas Färber Nov. 13, 2017, 11:34 p.m. UTC 
Define power domains for Actions Semi S700 SoC Smart Power System (SPS).

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 .../devicetree/bindings/power/actions,owl-sps.txt    |  2 ++
 include/dt-bindings/power/owl-s700-powergate.h       | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 include/dt-bindings/power/owl-s700-powergate.h

Comments

Rob Herring (Arm) Nov. 16, 2017, 4:35 a.m. UTC | #1 
On Tue, Nov 14, 2017 at 12:34:25AM +0100, Andreas Färber wrote:
> Define power domains for Actions Semi S700 SoC Smart Power System (SPS).
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2: New
>  
>  .../devicetree/bindings/power/actions,owl-sps.txt    |  2 ++
>  include/dt-bindings/power/owl-s700-powergate.h       | 20 ++++++++++++++++++++
>  2 files changed, 22 insertions(+)
>  create mode 100644 include/dt-bindings/power/owl-s700-powergate.h
> 
> diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
> index 007b9a7ae723..78edd63641e8 100644
> --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt
> +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
> @@ -2,10 +2,12 @@ Actions Semi Owl Smart Power System (SPS)
>  
>  Required properties:
>  - compatible          :  "actions,s500-sps" for S500
> +                         "actions,s700-sps" for S700
>  - reg                 :  Offset and length of the register set for the device.
>  - #power-domain-cells :  Must be 1.
>                           See macros in:
>                            include/dt-bindings/power/owl-s500-powergate.h for S500
> +                          include/dt-bindings/power/owl-s700-powergate.h for S700
>  
>  
>  Example:
> diff --git a/include/dt-bindings/power/owl-s700-powergate.h b/include/dt-bindings/power/owl-s700-powergate.h
> new file mode 100644
> index 000000000000..4ded16bc074f
> --- /dev/null
> +++ b/include/dt-bindings/power/owl-s700-powergate.h
> @@ -0,0 +1,20 @@
> +/*
> + * Actions Semi S700 SPS
> + *
> + * Copyright (c) 2017 Andreas Färber
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)

The decree now for SPDX tags is make this the first line using "//".

Otherwise, 

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Färber Nov. 16, 2017, 1:42 p.m. UTC | #2 
Am 16.11.2017 um 05:35 schrieb Rob Herring:
> On Tue, Nov 14, 2017 at 12:34:25AM +0100, Andreas Färber wrote:
>> Define power domains for Actions Semi S700 SoC Smart Power System (SPS).
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v2: New
>>  
>>  .../devicetree/bindings/power/actions,owl-sps.txt    |  2 ++
>>  include/dt-bindings/power/owl-s700-powergate.h       | 20 ++++++++++++++++++++
>>  2 files changed, 22 insertions(+)
>>  create mode 100644 include/dt-bindings/power/owl-s700-powergate.h
>>
>> diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
>> index 007b9a7ae723..78edd63641e8 100644
>> --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt
>> +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
>> @@ -2,10 +2,12 @@ Actions Semi Owl Smart Power System (SPS)
>>  
>>  Required properties:
>>  - compatible          :  "actions,s500-sps" for S500
>> +                         "actions,s700-sps" for S700
>>  - reg                 :  Offset and length of the register set for the device.
>>  - #power-domain-cells :  Must be 1.
>>                           See macros in:
>>                            include/dt-bindings/power/owl-s500-powergate.h for S500
>> +                          include/dt-bindings/power/owl-s700-powergate.h for S700
>>  
>>  
>>  Example:
>> diff --git a/include/dt-bindings/power/owl-s700-powergate.h b/include/dt-bindings/power/owl-s700-powergate.h
>> new file mode 100644
>> index 000000000000..4ded16bc074f
>> --- /dev/null
>> +++ b/include/dt-bindings/power/owl-s700-powergate.h
>> @@ -0,0 +1,20 @@
>> +/*
>> + * Actions Semi S700 SPS
>> + *
>> + * Copyright (c) 2017 Andreas Färber
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> 
> The decree now for SPDX tags is make this the first line using "//".

Thanks for noticing. Fixed:

diff --git a/include/dt-bindings/power/owl-s700-powergate.h
b/include/dt-bindings/power/owl-s700-powergate.h
index 4ded16bc074f..4cf1aefbf09c 100644
--- a/include/dt-bindings/power/owl-s700-powergate.h
+++ b/include/dt-bindings/power/owl-s700-powergate.h
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
 /*
  * Actions Semi S700 SPS
  *
  * Copyright (c) 2017 Andreas Färber
- *
- * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
  */
 #ifndef DT_BINDINGS_POWER_OWL_S700_POWERGATE_H
 #define DT_BINDINGS_POWER_OWL_S700_POWERGATE_H

> 
> Otherwise, 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks, queued in v4.16/dt64:
https://git.kernel.org/pub/scm/linux/kernel/git/afaerber/linux-actions.git/log/?h=v4.16/dt64

Regards,
Andreas
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
index 007b9a7ae723..78edd63641e8 100644
--- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt
+++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt
@@ -2,10 +2,12 @@  Actions Semi Owl Smart Power System (SPS)
 
 Required properties:
 - compatible          :  "actions,s500-sps" for S500
+                         "actions,s700-sps" for S700
 - reg                 :  Offset and length of the register set for the device.
 - #power-domain-cells :  Must be 1.
                          See macros in:
                           include/dt-bindings/power/owl-s500-powergate.h for S500
+                          include/dt-bindings/power/owl-s700-powergate.h for S700
 
 
 Example:
diff --git a/include/dt-bindings/power/owl-s700-powergate.h b/include/dt-bindings/power/owl-s700-powergate.h
new file mode 100644
index 000000000000..4ded16bc074f
--- /dev/null
+++ b/include/dt-bindings/power/owl-s700-powergate.h
@@ -0,0 +1,20 @@ 
+/*
+ * Actions Semi S700 SPS
+ *
+ * Copyright (c) 2017 Andreas Färber
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+#ifndef DT_BINDINGS_POWER_OWL_S700_POWERGATE_H
+#define DT_BINDINGS_POWER_OWL_S700_POWERGATE_H
+
+#define S700_PD_VDE	0
+#define S700_PD_VCE_SI	1
+#define S700_PD_USB2_1	2
+#define S700_PD_HDE	3
+#define S700_PD_DMA	4
+#define S700_PD_DS	5
+#define S700_PD_USB3	6
+#define S700_PD_USB2_0	7
+
+#endif