| Message ID | 20170605173136.10795-4-paul.burton@imgtec.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Hello! On 06/05/2017 08:31 PM, Paul Burton wrote: > Introduce documentation for a device tree binding for the Intel Platform > Controller Hub (PCH) GigaBit Ethernet (GBE) device. Although this is a > PCIe device & thus largely auto-detectable, this binding will be used to > provide the driver with the PHY reset GPIO. > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jarod Wilson <jarod@redhat.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Tobias Klauser <tklauser@distanz.ch> > Cc: devicetree@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: netdev@vger.kernel.org > > --- > > Changes in v4: None > > Changes in v3: > - New patch. > > Changes in v2: None > > Documentation/devicetree/bindings/net/pch_gbe.txt | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/pch_gbe.txt > > diff --git a/Documentation/devicetree/bindings/net/pch_gbe.txt b/Documentation/devicetree/bindings/net/pch_gbe.txt > new file mode 100644 > index 000000000000..5de479c26b04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/pch_gbe.txt > @@ -0,0 +1,25 @@ > +Intel Platform Controller Hub (PCH) GigaBit Ethernet (GBE) > + > +Required properties: > +- compatible: Should be the PCI vendor & device ID, eg. "pci8086,8802". > +- reg: Should be a PCI device number as specified by the PCI bus > + binding to IEEE Std 1275-1994. > +- phy-reset-gpios: Should be a GPIO list containing a single GPIO that > + resets the attached PHY when active. > + > +Example: > + > + eg20t_mac@2,0,1 { > + compatible = "pci8086,8802"; > + reg = <0x00020100 0 0 0 0>; > + phy-reset-gpios = <&eg20t_gpio 6 > + GPIO_ACTIVE_LOW>; > + }; > + > + eg20t_gpio: eg20t_gpio@2,0,2 { Name it "gpio@2,0,2" please -- the node names need to be generic and "gpio" is explicitly listed in the DT 1.0 spec... MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 05, 2017 at 10:31:32AM -0700, Paul Burton wrote: > Introduce documentation for a device tree binding for the Intel Platform > Controller Hub (PCH) GigaBit Ethernet (GBE) device. Although this is a > PCIe device & thus largely auto-detectable, this binding will be used to > provide the driver with the PHY reset GPIO. > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jarod Wilson <jarod@redhat.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Tobias Klauser <tklauser@distanz.ch> > Cc: devicetree@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: netdev@vger.kernel.org > > --- > > Changes in v4: None > > Changes in v3: > - New patch. > > Changes in v2: None > > Documentation/devicetree/bindings/net/pch_gbe.txt | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/pch_gbe.txt > > diff --git a/Documentation/devicetree/bindings/net/pch_gbe.txt b/Documentation/devicetree/bindings/net/pch_gbe.txt > new file mode 100644 > index 000000000000..5de479c26b04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/pch_gbe.txt > @@ -0,0 +1,25 @@ > +Intel Platform Controller Hub (PCH) GigaBit Ethernet (GBE) > + > +Required properties: > +- compatible: Should be the PCI vendor & device ID, eg. "pci8086,8802". > +- reg: Should be a PCI device number as specified by the PCI bus > + binding to IEEE Std 1275-1994. > +- phy-reset-gpios: Should be a GPIO list containing a single GPIO that > + resets the attached PHY when active. > + > +Example: > + > + eg20t_mac@2,0,1 { ethernet@... Your unit address is not valid for PCI[1]. You should not have the bus number (2) as there should be a bridge node that defines the bus number. Rob [1] http://www.o3one.org/hwdocs/openfirmware/pci_supplement_2_1.pdf -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/pch_gbe.txt b/Documentation/devicetree/bindings/net/pch_gbe.txt new file mode 100644 index 000000000000..5de479c26b04 --- /dev/null +++ b/Documentation/devicetree/bindings/net/pch_gbe.txt @@ -0,0 +1,25 @@ +Intel Platform Controller Hub (PCH) GigaBit Ethernet (GBE) + +Required properties: +- compatible: Should be the PCI vendor & device ID, eg. "pci8086,8802". +- reg: Should be a PCI device number as specified by the PCI bus + binding to IEEE Std 1275-1994. +- phy-reset-gpios: Should be a GPIO list containing a single GPIO that + resets the attached PHY when active. + +Example: + + eg20t_mac@2,0,1 { + compatible = "pci8086,8802"; + reg = <0x00020100 0 0 0 0>; + phy-reset-gpios = <&eg20t_gpio 6 + GPIO_ACTIVE_LOW>; + }; + + eg20t_gpio: eg20t_gpio@2,0,2 { + compatible = "pci8086,8803"; + reg = <0x00020200 0 0 0 0>; + + gpio-controller; + #gpio-cells = <2>; + };
Introduce documentation for a device tree binding for the Intel Platform Controller Hub (PCH) GigaBit Ethernet (GBE) device. Although this is a PCIe device & thus largely auto-detectable, this binding will be used to provide the driver with the PHY reset GPIO. Signed-off-by: Paul Burton <paul.burton@imgtec.com> Cc: David S. Miller <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jarod Wilson <jarod@redhat.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Tobias Klauser <tklauser@distanz.ch> Cc: devicetree@vger.kernel.org Cc: linux-mips@linux-mips.org Cc: netdev@vger.kernel.org --- Changes in v4: None Changes in v3: - New patch. Changes in v2: None Documentation/devicetree/bindings/net/pch_gbe.txt | 25 +++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/pch_gbe.txt