| Message ID | 20170523133448.4794-2-javier@dowhile0.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, May 23, 2017 at 8:34 AM, Javier Martinez Canillas <javier@dowhile0.org> wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > Document in the Device Tree binding document that this manufacturer should > be used as the generic fallback. Also document the deprecated vendors. > > Suggested-by: Wolfram Sang <wsa@the-dreams.de> > Suggested-by: Rob Herring <robh@kernel.org> > Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org> > > --- > > Changes in v5: > - Only deprecate the atmel variants at25 and at (Geert Uytterhoeven). > > Changes in v4: > - Document the manufacturers that have been deprecated (Rob Herring). > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/eeprom/eeprom.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt index 5696eb508e95..afc04589eadf 100644 --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt @@ -16,8 +16,12 @@ Required properties: "renesas,r1ex24002" + The following manufacturers values have been deprecated: + "at", "at24" + If there is no specific driver for <manufacturer>, a generic - driver based on <type> is selected. Possible types are: + device with <type> and manufacturer "atmel" should be used. + Possible types are: "24c00", "24c01", "24c02", "24c04", "24c08", "24c16", "24c32", "24c64", "24c128", "24c256", "24c512", "24c1024", "spd"
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken into account so the driver defines only a set of compatible strings using the "atmel" vendor as a generic fallback for compatible I2C devices. Document in the Device Tree binding document that this manufacturer should be used as the generic fallback. Also document the deprecated vendors. Suggested-by: Wolfram Sang <wsa@the-dreams.de> Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org> --- Changes in v5: - Only deprecate the atmel variants at25 and at (Geert Uytterhoeven). Changes in v4: - Document the manufacturers that have been deprecated (Rob Herring). Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/eeprom/eeprom.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)