| Message ID | 20131112174001.GA21881@linutronix.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Nov 12, 2013, at 11:40 AM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > The document says "first four bits" and means the upper nibble. Most > people would probably agree that the first four bits are bits 0…3 and > that is the lower nibble. > This patch updates the documentation so it is clear what is meant. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > v1…v2: > - use most/least significant instead of upper/ lower nibble > - add an example. > > .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) Thanks Acked-by: Kumar Gala <galak@codeaurora.org> - k
On Tue, 12 Nov 2013 12:26:14 -0600, Kumar Gala <galak@codeaurora.org> wrote: > > On Nov 12, 2013, at 11:40 AM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > The document says "first four bits" and means the upper nibble. Most > > people would probably agree that the first four bits are bits 0…3 and > > that is the lower nibble. > > This patch updates the documentation so it is clear what is meant. > > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > --- > > v1…v2: > > - use most/least significant instead of upper/ lower nibble > > - add an example. > > > > .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > Thanks > > Acked-by: Kumar Gala <galak@codeaurora.org> Kumar, for patches like this, do you want to put them into a git tree instead of acking? It will help spread the load. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt index 491c97b..b25a2fe 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt @@ -17,13 +17,16 @@ remaining 4 can be used by the ADC. ti,wire-config: Different boards could have a different order for connecting wires on touchscreen. We need to provide an - 8 bit number where in the 1st four bits represent the - analog lines and the next 4 bits represent positive/ - negative terminal on that input line. Notations to - represent the input lines and terminals resoectively - is as follows: + 8 bit number where the most significant nibble represent + the analog lines and the least significant nibble + represent positive/ negative terminal on that input + line. Notations to represent the input lines and + terminals resoectively is as follows: AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7. XP = 0, XN = 1, YP = 2, YN = 3. + + Example: ti,wire-config = <0x71>; + => line AIN7, configuration XN - child "adc" ti,adc-channels: List of analog inputs available for ADC. AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
The document says "first four bits" and means the upper nibble. Most people would probably agree that the first four bits are bits 0…3 and that is the lower nibble. This patch updates the documentation so it is clear what is meant. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- v1…v2: - use most/least significant instead of upper/ lower nibble - add an example. .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)