| Message ID | 1cdfd174d3ac541f3968dfe9bd14d5b6b28e4ac6.1724885333.git.daniel@makrotopia.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [net-next,v2,1/2] dt-bindings: net: marvell,aquantia: add properties to override MDI_CFG | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Aug 28, 2024 at 11:52:09PM +0100, Daniel Golle wrote: > Despite supporting Auto MDI-X, it looks like Aquantia only supports > swapping pair (1,2) with pair (3,6) like it used to be for MDI-X on > 100MBit/s networks. > > When all 4 pairs are in use (for 1000MBit/s or faster) the link does not > come up with pair order is not configured correctly, either using > MDI_CFG pin or using the "PMA Receive Reserved Vendor Provisioning 1" > register. > > Normally, the order of MDI pairs being either ABCD or DCBA is configured > by pulling the MDI_CFG pin. > > However, some hardware designs require overriding the value configured > by that bootstrap pin. The PHY allows doing that by setting a bit in > "PMA Receive Reserved Vendor Provisioning 1" register which allows > ignoring the state of the MDI_CFG pin and another bit configuring > whether the order of MDI pairs should be normal (ABCD) or reverse > (DCBA). Pair polarity is not affected and remains identical in both > settings. > > Introduce two mutually exclusive boolean properties which allow forcing > either normal or reverse order of the MDI pairs from DT. > > If none of the two new properties is present, the behavior is unchanged > and MDI pair order configuration is untouched (ie. either the result of > MDI_CFG pin pull-up/pull-down, or pair order override already configured > by the bootloader before Linux is started). > > Forcing normal pair order is required on the Adtran SDG-8733A Wi-Fi 7 > residential gateway. Is there an in-tree dts file for this? We like to see that options which are added are actually used. Andrew
On Thu, Aug 29, 2024 at 01:05:00AM +0200, Andrew Lunn wrote: > On Wed, Aug 28, 2024 at 11:52:09PM +0100, Daniel Golle wrote: > > Despite supporting Auto MDI-X, it looks like Aquantia only supports > > swapping pair (1,2) with pair (3,6) like it used to be for MDI-X on > > 100MBit/s networks. > > > > When all 4 pairs are in use (for 1000MBit/s or faster) the link does not > > come up with pair order is not configured correctly, either using > > MDI_CFG pin or using the "PMA Receive Reserved Vendor Provisioning 1" > > register. > > > > Normally, the order of MDI pairs being either ABCD or DCBA is configured > > by pulling the MDI_CFG pin. > > > > However, some hardware designs require overriding the value configured > > by that bootstrap pin. The PHY allows doing that by setting a bit in > > "PMA Receive Reserved Vendor Provisioning 1" register which allows > > ignoring the state of the MDI_CFG pin and another bit configuring > > whether the order of MDI pairs should be normal (ABCD) or reverse > > (DCBA). Pair polarity is not affected and remains identical in both > > settings. > > > > Introduce two mutually exclusive boolean properties which allow forcing > > either normal or reverse order of the MDI pairs from DT. > > > > If none of the two new properties is present, the behavior is unchanged > > and MDI pair order configuration is untouched (ie. either the result of > > MDI_CFG pin pull-up/pull-down, or pair order override already configured > > by the bootloader before Linux is started). > > > > Forcing normal pair order is required on the Adtran SDG-8733A Wi-Fi 7 > > residential gateway. > > Is there an in-tree dts file for this? We like to see that options > which are added are actually used. I planning to submit DTS for all the Adtran 8700 series once the MediaTek MT7988 SoC Ethernet is fully supported. At this point I'm still waiting for feedback on how to organize the PCS drivers for that SoC, see https://patchwork.kernel.org/comment/25954425/
On Wed, Aug 28, 2024 at 11:51:49PM +0100, Daniel Golle wrote: > Usually the MDI pair order reversal configuration is defined by > bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI > pair order and force either normal or reverse order. > > Add mutually exclusive properties 'marvell,force-mdi-order-normal' and > 'marvell,force-mdi-order-reverse' for that purpose. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > v2: enforce mutually exclusive relationship of the two new properties in > dt-schema. > > .../bindings/net/marvell,aquantia.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > index 9854fab4c4db0..03b0cff239f70 100644 > --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > @@ -22,6 +22,12 @@ description: | > > allOf: > - $ref: ethernet-phy.yaml# > + - if: > + required: > + - marvell,force-mdi-order-normal > + then: > + properties: > + marvell,force-mdi-order-reverse: false Ordinarily, when there are property related constraints in here, the allOf is moved after the property definitions, since it is odd to talk about rules for properties prior to defining them. If you resend, please move these down. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > select: > properties: > @@ -48,6 +54,16 @@ properties: > firmware-name: > description: specify the name of PHY firmware to load > > + marvell,force-mdi-order-normal: > + type: boolean > + description: > + force normal order of MDI pairs, overriding MDI_CFG bootstrap pin. > + > + marvell,force-mdi-order-reverse: > + type: boolean > + description: > + force reverse order of MDI pairs, overriding MDI_CFG bootstrap pin. > + > nvmem-cells: > description: phandle to the firmware nvmem cell > maxItems: 1 > -- > 2.46.0
On Wed, Aug 28, 2024 at 11:51:49PM +0100, Daniel Golle wrote: > Usually the MDI pair order reversal configuration is defined by > bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI > pair order and force either normal or reverse order. > > Add mutually exclusive properties 'marvell,force-mdi-order-normal' and > 'marvell,force-mdi-order-reverse' for that purpose. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > v2: enforce mutually exclusive relationship of the two new properties in > dt-schema. > > .../bindings/net/marvell,aquantia.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > index 9854fab4c4db0..03b0cff239f70 100644 > --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml > @@ -22,6 +22,12 @@ description: | > > allOf: > - $ref: ethernet-phy.yaml# > + - if: > + required: > + - marvell,force-mdi-order-normal > + then: > + properties: > + marvell,force-mdi-order-reverse: false > > select: > properties: > @@ -48,6 +54,16 @@ properties: > firmware-name: > description: specify the name of PHY firmware to load > > + marvell,force-mdi-order-normal: > + type: boolean > + description: > + force normal order of MDI pairs, overriding MDI_CFG bootstrap pin. > + > + marvell,force-mdi-order-reverse: > + type: boolean > + description: > + force reverse order of MDI pairs, overriding MDI_CFG bootstrap pin. Why 2 properties for 1 setting? Just do something like this: marvell,mdi-cfg-order = <0|1>; 1 means reverse, 0 means normal (or vise-versa). Not present then means use MDI_CFG setting. Then the binding naturally avoids nonsensical combinations of properties without the schema having to enforce it. Feel free to tweak the naming/values. I would make 0 and 1 align with MDI_CFG states, but I don't know what those are. Rob
diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml index 9854fab4c4db0..03b0cff239f70 100644 --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml @@ -22,6 +22,12 @@ description: | allOf: - $ref: ethernet-phy.yaml# + - if: + required: + - marvell,force-mdi-order-normal + then: + properties: + marvell,force-mdi-order-reverse: false select: properties: @@ -48,6 +54,16 @@ properties: firmware-name: description: specify the name of PHY firmware to load + marvell,force-mdi-order-normal: + type: boolean + description: + force normal order of MDI pairs, overriding MDI_CFG bootstrap pin. + + marvell,force-mdi-order-reverse: + type: boolean + description: + force reverse order of MDI pairs, overriding MDI_CFG bootstrap pin. + nvmem-cells: description: phandle to the firmware nvmem cell maxItems: 1
Usually the MDI pair order reversal configuration is defined by bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI pair order and force either normal or reverse order. Add mutually exclusive properties 'marvell,force-mdi-order-normal' and 'marvell,force-mdi-order-reverse' for that purpose. Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- v2: enforce mutually exclusive relationship of the two new properties in dt-schema. .../bindings/net/marvell,aquantia.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)