| Message ID | 1554136640-25194-2-git-send-email-shubhrajyoti.datta@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | serial: uartps: Add modem support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, Apr 01, 2019 at 10:07:19PM +0530, shubhrajyoti.datta@gmail.com wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > Vivado has a configurationo for selecting the modem control. > Add a dt binding to check for the same. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > Documentation/devicetree/bindings/serial/cdns,uart.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt > index 227bb77..3e96619 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt > @@ -12,6 +12,10 @@ Required properties: > See ../clocks/clock-bindings.txt for details. > > > +Optional properties: > +- xlnx,nomodem: The presence of this property indicates that the > + UART does not support modem lines for RTS/CTS hardware flow control. Shouldn't that be something like "noflowcontrol" or "nortscts"? "modem" has nothing to do with rts/cts flow control, right? thanks, greg k-h
Hi Greg , Thanks for the review. On Mon, Apr 1, 2019 at 11:09 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Apr 01, 2019 at 10:07:19PM +0530, shubhrajyoti.datta@gmail.com wrote: > > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > > > Vivado has a configurationo for selecting the modem control. > > Add a dt binding to check for the same. > > > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > --- > > Documentation/devicetree/bindings/serial/cdns,uart.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt > > index 227bb77..3e96619 100644 > > --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt > > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt > > @@ -12,6 +12,10 @@ Required properties: > > See ../clocks/clock-bindings.txt for details. > > > > > > +Optional properties: > > +- xlnx,nomodem: The presence of this property indicates that the > > + UART does not support modem lines for RTS/CTS hardware flow control. > > Shouldn't that be something like "noflowcontrol" or "nortscts"? "modem" > has nothing to do with rts/cts flow control, right? Updated in the v2. Thanks > > thanks, > > greg k-h
diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt index 227bb77..3e96619 100644 --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt @@ -12,6 +12,10 @@ Required properties: See ../clocks/clock-bindings.txt for details. +Optional properties: +- xlnx,nomodem: The presence of this property indicates that the + UART does not support modem lines for RTS/CTS hardware flow control. + Example: uart@e0000000 { compatible = "cdns,uart-r1p8";