Message ID | 1550662447-8565-2-git-send-email-aisheng.dong@nxp.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | irq: imx-irqsteer: add 32 interrupts chan and multi outputs support | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | "total: 0 errors, 1 warnings, 18 lines checked" |
On Wed, 20 Feb 2019 11:40:40 +0000, Aisheng Dong wrote: > Not all 64 interrupts may be used in one group. e.g. most irqsteer in > imx8qxp and imx8qm subsystems supports only 32 interrupts. > > As the IP integration parameters are Channel number and interrupts number, > let's use fsl,irqs-num to represents how many interrupts supported > by this irqsteer channel. > > Note this will break the compatibility of old binding. As the original > fsl,irq-groups was born out of a misunderstanding of the HW config > options and we are not aware of any users of the current binding. > And the old binding was just published in recent months, so it's > worth to change now to avoid confusing in the future. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > ChangeLog: > v3->v4: > * add more commit messages to describe the compatibility break > v2->v3: > * no changes > v1->v2: > * change property name fsl,irqs-per-chan to fsl,num-irqs. > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt index 45790ce..6d0a41b 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt @@ -16,8 +16,8 @@ Required properties: - #interrupt-cells: Specifies the number of cells needed to encode an interrupt source. The value must be 1. - fsl,channel: The output channel that all input IRQs should be steered into. -- fsl,irq-groups: Number of IRQ groups managed by this controller instance. - Each group manages 64 input interrupts. +- fsl,num-irqs: Number of input interrupts of this channel. + Should be multiple of 32 input interrupts and up to 512 interrupts. Example: @@ -28,7 +28,7 @@ Example: clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; clock-names = "ipg"; fsl,channel = <0>; - fsl,irq-groups = <1>; + fsl,num-irqs = <64>; interrupt-controller; #interrupt-cells = <1>; };