| Message ID | 1543337297-21873-2-git-send-email-fabrice.gasnier@st.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | mfd: syscon: Add optional clock support needed on stm32 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Nov 27, 2018 at 05:48:15PM +0100, Fabrice Gasnier wrote: > Some system control registers need to be clocked, so the registers can > be accessed. Add an optional clock. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > Documentation/devicetree/bindings/mfd/syscon.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt > index 25d9e9c..a9aaa51 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.txt > +++ b/Documentation/devicetree/bindings/mfd/syscon.txt > @@ -17,6 +17,7 @@ Optional property: > - reg-io-width: the size (in bytes) of the IO accesses that should be > performed on the device. > - hwlocks: reference to a phandle of a hardware spinlock provider node. > +- clocks: phandle to the syscon clock No. Add clocks to specific bindings using syscon. If you have a node with only 'syscon', then that should be fixed. Rob
On 12/11/18 11:16 PM, Rob Herring wrote: > On Tue, Nov 27, 2018 at 05:48:15PM +0100, Fabrice Gasnier wrote: >> Some system control registers need to be clocked, so the registers can >> be accessed. Add an optional clock. >> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> >> --- >> Documentation/devicetree/bindings/mfd/syscon.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt >> index 25d9e9c..a9aaa51 100644 >> --- a/Documentation/devicetree/bindings/mfd/syscon.txt >> +++ b/Documentation/devicetree/bindings/mfd/syscon.txt >> @@ -17,6 +17,7 @@ Optional property: >> - reg-io-width: the size (in bytes) of the IO accesses that should be >> performed on the device. >> - hwlocks: reference to a phandle of a hardware spinlock provider node. >> +- clocks: phandle to the syscon clock > > No. Add clocks to specific bindings using syscon. If you have a node > with only 'syscon', then that should be fixed. Hi Rob, Thanks for reviewing, so I'll - add it to Documentation/devicetree/bindings/arm/stm32/stm32-syscon.txt - send a v2 with this change. Best regards, Fabrice > > Rob >
diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt index 25d9e9c..a9aaa51 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.txt +++ b/Documentation/devicetree/bindings/mfd/syscon.txt @@ -17,6 +17,7 @@ Optional property: - reg-io-width: the size (in bytes) of the IO accesses that should be performed on the device. - hwlocks: reference to a phandle of a hardware spinlock provider node. +- clocks: phandle to the syscon clock Examples: gpr: iomuxc-gpr@20e0000 {
Some system control registers need to be clocked, so the registers can be accessed. Add an optional clock. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- Documentation/devicetree/bindings/mfd/syscon.txt | 1 + 1 file changed, 1 insertion(+)