From patchwork Tue Apr 3 06:28:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shubhrajyoti Datta X-Patchwork-Id: 894448 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40FfGF05KRz9s35 for ; Tue, 3 Apr 2018 16:25:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbeDCGZH (ORCPT ); Tue, 3 Apr 2018 02:25:07 -0400 Received: from mail-sn1nam01on0084.outbound.protection.outlook.com ([104.47.32.84]:2512 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754855AbeDCGZG (ORCPT ); Tue, 3 Apr 2018 02:25:06 -0400 Received: from BLUPR0201CA0024.namprd02.prod.outlook.com (2a01:111:e400:52e7::34) by SN1PR0201MB1568.namprd02.prod.outlook.com (2a01:111:e400:5305::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 06:25:04 +0000 Received: from CY1NAM02FT013.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::203) by BLUPR0201CA0024.outlook.office365.com (2a01:111:e400:52e7::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.631.10 via Frontend Transport; Tue, 3 Apr 2018 06:25:04 +0000 Authentication-Results: spf=softfail (sender IP is 149.199.60.100) smtp.mailfrom=gmail.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=fail action=none header.from=gmail.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning gmail.com discourages use of 149.199.60.100 as permitted sender) Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT013.mail.protection.outlook.com (10.152.75.162) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.653.8 via Frontend Transport; Tue, 3 Apr 2018 06:25:03 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:40841 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1f3FIx-0000Ln-RE; Mon, 02 Apr 2018 23:20:27 -0700 Received: from [127.0.0.1] (helo=xsj-smtp-dlp2.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1f3FIs-0007Cd-MY; Mon, 02 Apr 2018 23:20:22 -0700 Received: from xsj-pvapsmtp01 (xsj-mail.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w336KLPN007420; Mon, 2 Apr 2018 23:20:21 -0700 Received: from [172.23.37.106] (helo=xhdshubhraj40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1f3FIq-0007BZ-JC; Mon, 02 Apr 2018 23:20:21 -0700 From: To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH] usb: gadget: udc-xilinx: Add clock support Date: Tue, 3 Apr 2018 11:58:07 +0530 Message-ID: <1522736887-17079-1-git-send-email-shubhrajyoti.datta@gmail.com> X-Mailer: git-send-email 2.1.1 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-Result: No--2.580-7.0-31-1 X-imss-scan-details: No--2.580-7.0-31-1;No--2.580-5.0-31-1 X-TM-AS-User-Approved-Sender: No;No X-TM-AS-Result-Xfilter: Match text exemption rules:No X-EOPAttributedMessage: 0 X-Matching-Connectors: 131672103038685810; (f9e945fa-a09a-4caa-7158-08d2eb1d8c44); () X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(376002)(346002)(39850400004)(396003)(2980300002)(189003)(199004)(16586007)(59450400001)(316002)(2876002)(86362001)(1857600001)(73972006)(61266001)(47776003)(5660300001)(106466001)(2906002)(305945005)(55446002)(4326008)(450100002)(76482006)(105596002)(356003)(51416003)(107886003)(81156014)(82202002)(6916009)(2351001)(86152003)(81166006)(8676002)(73392003)(336012)(63266004)(87572001)(498600001)(126002)(50226002)(426003)(486005)(48376002)(50466002)(83322999)(54906003)(6666003)(476003)(36756003)(9786002)(486005)(2616005)(77096007)(26005)(8936002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0201MB1568; H:xsj-pvapsmtpgw02; FPR:; SPF:SoftFail; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT013; 1:bwYIBHdPyDaKAFfTFNU9GWo10H/Wyq4p39DWfiGUbDiW1m2fFsBqhVVV46XHLp0funRmzwKq8QgB8cuAHB3gtbICnUUIkFRt7AQftlmcDMB+jI22DWzQ10keR9QyD4hF MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4252938-3c18-4b40-c43a-08d5992ba2db X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603328); SRVR:SN1PR0201MB1568; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1568; 3:Uv8/YPoghbTmMFGmyNiNzdSotciCt2lSp+g9lOcC2ETHsa0SqBPJz68Kqu/Oz/aJSZNzv4LObKLpLpx4UzACJcgG6ask/NjtidAKoikun+fAN9HKD/6KSE8W+iXIY1fc/onjBj5auG+gAK/B6QdxK9oIW/cNwX5IbpH3VhyWM6onbJa9lfJayb519Dq0Wj/iDwjQI2LPqI0t5VVE4iROkDR8vORQFozGHFJMILI15vpIePLBpHO6hPjOepKGlF62W7PIK9P5z5Fg15gD2P13+dKEHURepyoGpnsRii1c4GpIhfqBdI7AvxGSYL/yvaxuLHSeQzgWTOkva7wzmSWna8Pb4lq+8T9EFrOSMK4MIEw=; 25:qgW5edB+I3Hf+N2TSQXC4wQ3slsAY0qLY5cdiwBldO7gfgJD9lqv53q2Hubv9lRFEE3Nf3wdF5dFqITA/CdKW28VNC2boy49ExssyW0tThPQ0V6kmHhuTE3Dc+tNGu3viRxWVPEQ2klvEnLNuBQ56c02w4rUeMR4osaCbGoSY+88SMd+MhILJz9+f0VCeMpRHNdSDz58/rPWwxxLVAL66IbVN7XeTGnXUxpcIWLO2akn75SbWLLQVIzVUSysatYxaVSwxAhxANs4DI/sUvLrnXAZCBhAnne/Qih3XSW4zIads3l0Vj4BeUMnU11l46CoJKS/61Z9TGdijbilcRfRjg== X-MS-TrafficTypeDiagnostic: SN1PR0201MB1568: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1568; 31:3jbmnlSLqFkaZ1tb78E69eH7HX3G9DsJuydR2muS5ZlmCN6m7PMmorUOiCjIGJP2pHB3zsnRSxCguqswM7aG8qOEvYVyw8olt0e6Gzw3vYGBo7Bulx7RSdys0p8IxpB0qrdg3j80Eh7yQbADQwHO4TEgrDIeMbFGOfxz73MPsXBeHyUTnl+quPm5vmVY+/NednqNzctqKyVyfTpV20B+Wrlb8H0dP41zHMbOUZ9TUTY=; 4:hVvyfMoxLZ38SceLSnNAH+J+w/V8JAbkjjhdnNWjiw10jtc6NZBBnNDOS5gezxuwf0QuGMRtX9KaGNn6y+vpLKCMbrJxCbbHxsPSBJBl0MAuuGusztImxSq8FxO8YorY1tYCnbIWGbf9YSrQV4Olmy0PQQBQumdjmUs8IpHiMlDCfH2wUn/Lh9j5/HRU8+hdM2GEXT+nivZkkz4Xnybv9wQ90KrWAPfz/kkSVmV10tMd7wLEmbq8cWbUO9/WNNL2s7nmS2PFl/pMWuVPLlLuSSvneG8NlO94Cv1M1k2q0XhvH9AQHzHomAeoAUh2JYtd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501327)(52105095)(6055026)(6096035)(20161123561025)(20161123556025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123565025)(20161123563025)(201708071742011); SRVR:SN1PR0201MB1568; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0201MB1568; X-Forefront-PRVS: 0631F0BC3D X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0201MB1568; 23:SVMP+htNWNAC2t7ppvTJSOPMEZolALYjcetvg5A?= Vbz+GSzcgDCMWMA5F/ju4t6R3McQeBCQepRUYI3/U5EmnsJFz6kzn6I0ztaO4gIxkYeJRuqFiJTsoUOtqVJQRvYKJgPzhKu4cIvrKHCzZR/hNagdQYnjfPkXTor7ZuLnIvnmJP1kQRnTVltjrofPJLlB95cllBTiQcvnmdsVGuBDhHqh6+vU1t/Ez0pJnIiyLiIzbmttq5RhQwg9Cjn9gCXhEwSQ24Pzbkf8u1Tqv0AftCFEvYy3O87KENfN2v/H+Gb2YmU+TqbkP/Hl0T4lZ4+f7joe5lWheZx0hJeWMixDZoXtcNHLBxHSfdl0uscyn6HpWVep9kCZjqZSZYzDkKsUXo/Do1FeWknkc8UN70CfN0VT+d4FxBLgm9V6c83HWt4bUz3KHFy8JgKVGdhLXTWf+6nFKhPjB3uS3fosN9L8uec8zFTj5XqUfpASalLMv8Vhzv9/hhxXL0m+69JFqWAg9H+PxpdCY4GwPMxompD6A+F3A3b7PQ4JlKWUq9zMCkG4Ut76Q/Myp1Pvn+mPt7ljust8ug/3uzQB4AS4lkmVTOPiM/GuBgWN9Re+6T4ujZnEd+dPM3R1l9Bnut2zhGJ8mdsfboU3BBhasj3/bROA8P8XiuwfInxoJ+/Z1lxLCl6CPMTPRvksILCvzMvKbKkT/PutoX88WmFJVYpvS2WE0547AZgI7qfBCiFKowrqw510AXtMicYbECzWw3k+7NTE2zbBqBtnAiGxuM/RTQgBkHShVpGb+DlPUk48oQs7bwEogi7bva5EXEXjh8qWhwc1MXnvjvJkwlCgY4T/D8O9s9REkwwilNrxpCv2U7KOtGidaL0/ntM6Dir38swk/qcE2fTDjnn02hYoBSDM/+aShLCxDzZmbm5myJSxIjRn7qvHCXU0ywMPWycef2nHi4G4Po6lBM6E6noOWkmt14lrdc0D4poog/cgqGNJxcHf69O5RJO7xWB+6pfojkraW143PnOwR+WC+Y89pwpG8ZyF3jNNrPtfnr4gi0wIt72A7KvQes/P7sVEaNoB9S8XYvcq0SN1TD8Hy9w0t3NfYB/UXGN8JBzFJjNATEamom7NG7dmcS71WJqTF/1iDB8hgFey1EXBeMKStbqYRhW6DApsHF5zb3EbJSI0Gd4hWQzh/0OSMBlzyu2t2UZTi8rFWh/fk4sT7xhb1o4qTp1snyexlBPscuLeuupNivnvrj6eGpvtCYo/BNbW2/Zd6p6FVx0IkfBv4uOf4U0g4OM0xptlL/YTTQnldAlXzcZMmfy5B3yGEPu0BPZbR7WhdB7cQIXE85RBYg3sgMSha5bsXK/P0IA== X-Microsoft-Antispam-Message-Info: /XhQs7CC0Q1HqWvXzflf7ymWicw2n0dbTAvyWMDTW+8QdRTvki4vXTsFnwD1Ali6s+F4PtCnaz7g4ZjadpJ3DbLCYbiQKdGkF21Ebd0v5ZBwzKV4b+R4lgqSRHBS8YiUvX5RoEx+61xMI7+eMWRQGIlBR7BgzLQeB6WoA4pP/hm2mLvl2HZ9J53GxbpbunfV X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1568; 6:4Y7HaSxq6RtxZegwK6Mj7Y1UigRx9tZs71K6P2OGc/IVrV45UGPL/m8bhWc1L8k+Z/KoRhq6dL/IaUXN9OYgTCmT5+q91JaO1/bBzIadJfyzYTwiJtPAmCddSgSWkzEdBAcmgzCIIHpLGcmc5/GO0YNGqKwE6pZg/2ooQRqImX3SGFXPV5GMrgM+CYYgoVrTtglVwNXlZoczWOYs/TUETYP32CePONhkoUtX52BSyT1MZtfRF8N1aes0yQ1kgqIrUUjaT+eB1ZFyLoBEwPPJkXLilRnv7ePqlKkyqU0uYBVOpnUHXvADG6DfTcFdIW48BV1zwK1Y9PrM4lj4vP+Vl/DnILlLwhewozPRKsZTTHGnsXhUNmnrWjf6nzwsxun1U8M8YFhWIpA1ia8+IRsHjkA8tFNNpgWvFb/fma/oBhkhTbOWsb2Du3Zrhplx+6Cw+8H83AAhpAi+bQrXFXfXow==; 5:tUa4xfnwREsgJQe3IipOI3Ir3TFZvEUPdGrwFu8tNRy2jmnI3yc4ZjD6Q8OvXoDS0YLcztTWuFG9SUtkJqwMZlPNvQ4VgqwHpf7/ICl0xskaZsE9ZNN9antjHIhIFXgNs9qC71bm2rxq+kIjYgItpi60FM8nwKhIvL6aa3++Eaw=; 24:gWMVyrlu4HxtNK23vi242+hjC0omG+WX0RnLhoy7lpuHFJm1M5StKbWSTR8Nn9oGMv8gVXgx0qqryJHG8VGOoCS8QTRUu6KkmHo/cD8jUD8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0201MB1568; 7:JIW7s0PSwWfJk59g2xJr9qc1ULYAoZlyIaN0K+bLYrwjWHpqoueRei1ITF8zbuwGjoHpymSNV9oi08VddrwYdbTzzB6Kf+tX+d7RIJ+ey8lBPJNuEvqKKYPdss0Vef1SZHddsYQqWJJ5VaLG2XHiAkBeB6rZLhGaPybuCD9OTHS6lNyT2QccH+S6LEcP9qQGKYnbgCXlQeY1dBWT1erry17KNScrpN6gA+X6zKBr3a7lJ4Bs/QUS53NfvvhfP4cu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 06:25:03.5873 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4252938-3c18-4b40-c43a-08d5992ba2db X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1568 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Shubhrajyoti Datta Currently the driver depends on the bootloader to enable the clocks. Add support for clocking. The patch enables the clock at probe and disables them at remove. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/usb/udc-xilinx.txt | 4 ++++ drivers/usb/gadget/udc/udc-xilinx.c | 23 ++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt index 47b4e39..da2fedc 100644 --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt @@ -8,6 +8,10 @@ Required properties: controller - xlnx,has-builtin-dma : if DMA is included +Optional properties: +- clock-names : should be "s_axi_aclk" +- clocks : Input clock specifier. Refer to common clock bindings. + Example: axi-usb2-device@42e00000 { compatible = "xlnx,usb2-device-4.00.a"; diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index 6407e43..8e81171 100644 --- a/drivers/usb/gadget/udc/udc-xilinx.c +++ b/drivers/usb/gadget/udc/udc-xilinx.c @@ -11,6 +11,7 @@ * USB peripheral controller (at91_udc.c). */ +#include #include #include #include @@ -188,6 +189,7 @@ struct xusb_udc { void __iomem *addr; spinlock_t lock; bool dma_enabled; + struct clk *clk; unsigned int (*read_fn)(void __iomem *); void (*write_fn)(void __iomem *, u32, u32); @@ -2094,6 +2096,26 @@ static int xudc_probe(struct platform_device *pdev) udc->gadget.ep0 = &udc->ep[XUSB_EP_NUMBER_ZERO].ep_usb; udc->gadget.name = driver_name; + udc->clk = devm_clk_get(&pdev->dev, "s_axi_aclk"); + if (IS_ERR(udc->clk)) { + if (PTR_ERR(udc->clk) != -ENOENT) { + ret = PTR_ERR(udc->clk); + goto fail; + } + + /* + * Clock framework support is optional, continue on, + * anyways if we don't find a matching clock + */ + udc->clk = NULL; + } + + ret = clk_prepare_enable(udc->clk); + if (ret) { + dev_err(&pdev->dev, "Unable to enable clock.\n"); + return ret; + } + spin_lock_init(&udc->lock); /* Check for IP endianness */ @@ -2149,6 +2171,7 @@ static int xudc_remove(struct platform_device *pdev) struct xusb_udc *udc = platform_get_drvdata(pdev); usb_del_gadget_udc(&udc->gadget); + clk_disable_unprepare(udc->clk); return 0; }