| Message ID | 1484157171-15571-2-git-send-email-david@lechnology.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 11/01/17 17:52, David Lechner wrote: > This adds device tree bindings for the TI ADS7950 family of A/DC chips. > > Signed-off-by: David Lechner <david@lechnology.com> This is in of itself good, but we may need to have some deprecated elements to continue supporting what was implicitly happening with the missnaming so as to avoid accidentally breaking someone's device tree. Jonathan > --- > .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > new file mode 100644 > index 0000000..e77a6f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt > @@ -0,0 +1,23 @@ > +* Texas Instruments ADS7950 family of A/DC chips > + > +Required properties: > + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", > + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", > + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" > + - reg: SPI chip select number for the device > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads7957"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/14/2017 06:53 AM, Jonathan Cameron wrote: > On 11/01/17 17:52, David Lechner wrote: >> This adds device tree bindings for the TI ADS7950 family of A/DC chips. >> >> Signed-off-by: David Lechner <david@lechnology.com> > This is in of itself good, but we may need to have some deprecated > elements to continue supporting what was implicitly happening with > the missnaming so as to avoid accidentally breaking someone's device > tree. > As I mentioned in my cover letter, this driver, as far as I can tell, only exists in your testing branch, so I find it highly unlikely that we would be breaking anyone. It is not in mainline and it is not even in linux-next. > Jonathan >> --- >> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> new file mode 100644 >> index 0000000..e77a6f7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> @@ -0,0 +1,23 @@ >> +* Texas Instruments ADS7950 family of A/DC chips >> + >> +Required properties: >> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", >> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", >> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" >> + - reg: SPI chip select number for the device >> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V >> + reference voltage >> + >> +Recommended properties: >> + - spi-max-frequency: Definition as per >> + Documentation/devicetree/bindings/spi/spi-bus.txt >> + >> +Example: >> +adc@0 { >> + compatible = "ti,ads7957"; >> + reg = <0>; >> + #io-channel-cells = <1>; >> + vref-supply = <&refin_supply>; >> + spi-max-frequency = <10000000>; >> +}; >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14/01/17 18:00, David Lechner wrote: > On 01/14/2017 06:53 AM, Jonathan Cameron wrote: >> On 11/01/17 17:52, David Lechner wrote: >>> This adds device tree bindings for the TI ADS7950 family of A/DC chips. >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >> This is in of itself good, but we may need to have some deprecated >> elements to continue supporting what was implicitly happening with >> the missnaming so as to avoid accidentally breaking someone's device >> tree. >> > > As I mentioned in my cover letter, this driver, as far as I can tell, > only exists in your testing branch, so I find it highly unlikely that > we would be breaking anyone. It is not in mainline and it is not even > in linux-next. Oops, I not only have a memory like a goldfish, I clearly didn't read your cover letter either. Applied to the togreg branch of iio.git and pushed out as testing. The driver will hit next before this does but will get into mainline in the same ultimate pull request unless something weird happens so that's all fine. Jonathan >> Jonathan >>> --- >>> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >>> >>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >>> new file mode 100644 >>> index 0000000..e77a6f7 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >>> @@ -0,0 +1,23 @@ >>> +* Texas Instruments ADS7950 family of A/DC chips >>> + >>> +Required properties: >>> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", >>> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", >>> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" >>> + - reg: SPI chip select number for the device >>> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >>> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V >>> + reference voltage >>> + >>> +Recommended properties: >>> + - spi-max-frequency: Definition as per >>> + Documentation/devicetree/bindings/spi/spi-bus.txt >>> + >>> +Example: >>> +adc@0 { >>> + compatible = "ti,ads7957"; >>> + reg = <0>; >>> + #io-channel-cells = <1>; >>> + vref-supply = <&refin_supply>; >>> + spi-max-frequency = <10000000>; >>> +}; >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 11, 2017 at 11:52:49AM -0600, David Lechner wrote: > This adds device tree bindings for the TI ADS7950 family of A/DC chips. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt new file mode 100644 index 0000000..e77a6f7 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt @@ -0,0 +1,23 @@ +* Texas Instruments ADS7950 family of A/DC chips + +Required properties: + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" + - reg: SPI chip select number for the device + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V + reference voltage + +Recommended properties: + - spi-max-frequency: Definition as per + Documentation/devicetree/bindings/spi/spi-bus.txt + +Example: +adc@0 { + compatible = "ti,ads7957"; + reg = <0>; + #io-channel-cells = <1>; + vref-supply = <&refin_supply>; + spi-max-frequency = <10000000>; +};
This adds device tree bindings for the TI ADS7950 family of A/DC chips. Signed-off-by: David Lechner <david@lechnology.com> --- .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt