| Message ID | 1478497281-5477-2-git-send-email-ping.bai@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Nov 07, 2016 at 01:41:20PM +0800, Bai Ping wrote: > Add new compatible string for i.MX6UL SOC. > > Signed-off-by: Bai Ping <ping.bai@nxp.com> > --- > Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > index 383d588..a7ff65d 100644 > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > @@ -1,13 +1,14 @@ > Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings > > This binding represents the on-chip eFuse OTP controller found on > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs. > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs. > > Required properties: > - compatible: should be one of > "fsl,imx6q-ocotp" (i.MX6Q/D/DL/S), > - "fsl,imx6sl-ocotp" (i.MX6SL), or > - "fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon". > + "fsl,imx6sl-ocotp" (i.MX6SL), > + "fsl,imx6sx-ocotp" (i.MX6SX), or > + "fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon". This should be reformatted such that it's not a 5 line change to add a compatible. "one of" defines this is an OR relationship, so drop that. Move 'followed by "syscon"' to below the list of compatibles. > - reg: Should contain the register base and length. > - clocks: Should contain a phandle pointing to the gated peripheral clock. > > -- > 2.8.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Add new compatible string for i.MX6UL SOC. > > > > Signed-off-by: Bai Ping <ping.bai@nxp.com> > > --- > > Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > index 383d588..a7ff65d 100644 > > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > @@ -1,13 +1,14 @@ > > Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings > > > > This binding represents the on-chip eFuse OTP controller found on > > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs. > > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs. > > > > Required properties: > > - compatible: should be one of > > "fsl,imx6q-ocotp" (i.MX6Q/D/DL/S), > > - "fsl,imx6sl-ocotp" (i.MX6SL), or > > - "fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon". > > + "fsl,imx6sl-ocotp" (i.MX6SL), > > + "fsl,imx6sx-ocotp" (i.MX6SX), or > > + "fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon". > > This should be reformatted such that it's not a 5 line change to add a > compatible. "one of" defines this is an OR relationship, so drop that. > Move 'followed by "syscon"' to below the list of compatibles. > Thanks for review, I will adopt in V2. Jacky Bai > > - reg: Should contain the register base and length. > > - clocks: Should contain a phandle pointing to the gated peripheral clock. > > > > -- > > 2.8.2 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt index 383d588..a7ff65d 100644 --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt @@ -1,13 +1,14 @@ Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings This binding represents the on-chip eFuse OTP controller found on -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs. +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs. Required properties: - compatible: should be one of "fsl,imx6q-ocotp" (i.MX6Q/D/DL/S), - "fsl,imx6sl-ocotp" (i.MX6SL), or - "fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon". + "fsl,imx6sl-ocotp" (i.MX6SL), + "fsl,imx6sx-ocotp" (i.MX6SX), or + "fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon". - reg: Should contain the register base and length. - clocks: Should contain a phandle pointing to the gated peripheral clock.
Add new compatible string for i.MX6UL SOC. Signed-off-by: Bai Ping <ping.bai@nxp.com> --- Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)