| Message ID | 1467408602-16546-1-git-send-email-alexandre.belloni@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 01/07/16 22:30, Alexandre Belloni wrote: > Add documentation for ADC keys > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Clean looking binding to me - one comment inline. Jonathan > --- > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > > .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt > > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt > new file mode 100644 > index 000000000000..873476bb4eab > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt > @@ -0,0 +1,45 @@ > +Allwinner sun4i low res adc attached tablet keys What is allwinner specific in here? Looks pretty general purpose to me! > +------------------------------------------------ > + > +Required properties: > + - compatible: "adc-keys" > + - io-channels: Phandle to an ADC channel > + - io-channel-names = "buttons"; > + - voltage-keyup-mvolt: Voltage at which all the keys are considered up. > + > +Each key is represented as a sub-node of "adc-keys": > + > +Required subnode-properties: > + - label: Descriptive name of the key. > + - linux,code: Keycode to emit. > + - voltage-mvolt: Voltage adc input when this key is pressed. > + > +Example: > + > +#include <dt-bindings/input/input.h> > + > + adc-keys { > + compatible = "adc-keys"; > + io-channels = <&lradc 0>; > + io-channel-names = "buttons"; > + voltage-keyup-mvolt = <2000>; > + > + button@1500 { > + label = "Volume Up"; > + linux,code = <KEY_VOLUMEUP>; > + voltage-mvolt = <1500>; > + }; > + > + button@1000 { > + label = "Volume Down"; > + linux,code = <KEY_VOLUMEDOWN>; > + voltage-mvolt = <1000>; > + }; > + > + button@500 { > + label = "Enter"; > + linux,code = <KEY_ENTER>; > + voltage-mvolt = <500>; > + }; > + }; > + > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/07/2016 at 14:43:56 +0100, Jonathan Cameron wrote : > On 01/07/16 22:30, Alexandre Belloni wrote: > > Add documentation for ADC keys > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Clean looking binding to me - one comment inline. > > Jonathan > > --- > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > > > .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt > > > > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt > > new file mode 100644 > > index 000000000000..873476bb4eab > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt > > @@ -0,0 +1,45 @@ > > +Allwinner sun4i low res adc attached tablet keys > What is allwinner specific in here? Looks pretty general purpose to me! That's true, I forgot to change that after shamelessly copy pasting... I was planning to use something like ADC attached resistor ladder buttons, unless you have a better way to describe that.
On Sun, Jul 03, 2016 at 02:43:56PM +0100, Jonathan Cameron wrote: > On 01/07/16 22:30, Alexandre Belloni wrote: > > Add documentation for ADC keys > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Clean looking binding to me - one comment inline. > > Jonathan > > --- > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > > > .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt > > > > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt > > new file mode 100644 > > index 000000000000..873476bb4eab > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt > > @@ -0,0 +1,45 @@ > > +Allwinner sun4i low res adc attached tablet keys > What is allwinner specific in here? Looks pretty general purpose to me! > > +------------------------------------------------ > > + > > +Required properties: > > + - compatible: "adc-keys" > > + - io-channels: Phandle to an ADC channel > > + - io-channel-names = "buttons"; > > + - voltage-keyup-mvolt: Voltage at which all the keys are considered up. > > + > > +Each key is represented as a sub-node of "adc-keys": > > + > > +Required subnode-properties: > > + - label: Descriptive name of the key. > > + - linux,code: Keycode to emit. > > + - voltage-mvolt: Voltage adc input when this key is pressed. voltage-mcvoltface? "voltage" is redundant and use standard units. How about {press,up}-threshold-microvolt? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt new file mode 100644 index 000000000000..873476bb4eab --- /dev/null +++ b/Documentation/devicetree/bindings/input/adc-keys.txt @@ -0,0 +1,45 @@ +Allwinner sun4i low res adc attached tablet keys +------------------------------------------------ + +Required properties: + - compatible: "adc-keys" + - io-channels: Phandle to an ADC channel + - io-channel-names = "buttons"; + - voltage-keyup-mvolt: Voltage at which all the keys are considered up. + +Each key is represented as a sub-node of "adc-keys": + +Required subnode-properties: + - label: Descriptive name of the key. + - linux,code: Keycode to emit. + - voltage-mvolt: Voltage adc input when this key is pressed. + +Example: + +#include <dt-bindings/input/input.h> + + adc-keys { + compatible = "adc-keys"; + io-channels = <&lradc 0>; + io-channel-names = "buttons"; + voltage-keyup-mvolt = <2000>; + + button@1500 { + label = "Volume Up"; + linux,code = <KEY_VOLUMEUP>; + voltage-mvolt = <1500>; + }; + + button@1000 { + label = "Volume Down"; + linux,code = <KEY_VOLUMEDOWN>; + voltage-mvolt = <1000>; + }; + + button@500 { + label = "Enter"; + linux,code = <KEY_ENTER>; + voltage-mvolt = <500>; + }; + }; +
Add documentation for ADC keys Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt