| Message ID | 1455757572-44955-1-git-send-email-qiang.zhao@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > Add IC, SI and SIRAM document of QE to > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > --- > Changes for v2 > - Add interrupt-controller in Required properties > - delete address-cells and size-cells for qe-si and qe-siram > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > index 4f89302..84052a7 100644 > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > @@ -69,6 +69,56 @@ Example: > }; > }; > > +* Interrupt Controller (IC) > + > +Required properties: > +- compatible : should be "fsl,qe-ic". > +- compatible : should be "fsl,qe-si". > +- compatible : should be "fsl,qe-siram". These compatible strings are all a bit generic and should have SoC specific compatible strings. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > Add IC, SI and SIRAM document of QE to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > --- > > Changes for v2 > > - Add interrupt-controller in Required properties > > - delete address-cells and size-cells for qe-si and qe-siram > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > index 4f89302..84052a7 100644 > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > @@ -69,6 +69,56 @@ Example: > > }; > > }; > > > > +* Interrupt Controller (IC) > > + > > +Required properties: > > +- compatible : should be "fsl,qe-ic". > > > +- compatible : should be "fsl,qe-si". > > > +- compatible : should be "fsl,qe-siram". > > These compatible strings are all a bit generic and should have SoC > specific compatible strings. I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it should be documented even if a more specific compatible is also added. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote: > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote: > > -----Original Message----- > > From: Scott Wood [mailto:oss@buserror.net] > > Sent: Wednesday, February 24, 2016 4:20 AM > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com> > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device > > tree > > bindings. > > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > > > Add IC, SI and SIRAM document of QE to > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > > > --- > > > > Changes for v2 > > > > - Add interrupt-controller in Required properties > > > > - delete address-cells and size-cells for qe-si and qe-siram > > > > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > > > ++++++++++++++++++++++ > > > > 1 file changed, 50 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > index 4f89302..84052a7 100644 > > > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > @@ -69,6 +69,56 @@ Example: > > > > }; > > > > }; > > > > > > > > +* Interrupt Controller (IC) > > > > + > > > > +Required properties: > > > > +- compatible : should be "fsl,qe-ic". > > > > > > > +- compatible : should be "fsl,qe-si". > > > > > > > +- compatible : should be "fsl,qe-siram". > > > > > > These compatible strings are all a bit generic and should have SoC > > > specific compatible strings. > > > > I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, > > so it > > should be documented even if a more specific compatible is also added. > > Agree, and si/siram are also has been around since 2008. Where? I couldn't find them when grepping. > In addition, I don’t think it is needed to add specific compatible, because > they are > the same in qe-supported soc. How do we know that they are 100% the same? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote: > -----Original Message----- > From: Scott Wood [mailto:oss@buserror.net] > Sent: Thursday, February 25, 2016 11:12 AM > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree > bindings. > > On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote: > > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote: > > > -----Original Message----- > > > From: Scott Wood [mailto:oss@buserror.net] > > > Sent: Wednesday, February 24, 2016 4:20 AM > > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com> > > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org; > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to > > > device tree bindings. > > > > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > > > > Add IC, SI and SIRAM document of QE to > > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > > > > --- > > > > > Changes for v2 > > > > > - Add interrupt-controller in Required properties > > > > > - delete address-cells and size-cells for qe-si and qe-siram > > > > > > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > > > > ++++++++++++++++++++++ > > > > > 1 file changed, 50 insertions(+) > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > index 4f89302..84052a7 100644 > > > > > --- > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx > > > > > +++ t > > > > > @@ -69,6 +69,56 @@ Example: > > > > > }; > > > > > }; > > > > > > > > > > +* Interrupt Controller (IC) > > > > > + > > > > > +Required properties: > > > > > +- compatible : should be "fsl,qe-ic". > > > > > > > > > +- compatible : should be "fsl,qe-si". > > > > > > > > > +- compatible : should be "fsl,qe-siram". > > > > > > > > These compatible strings are all a bit generic and should have SoC > > > > specific compatible strings. > > > > > > I don't know about si/siram, but "fsl,qe-ic" has been around since > > > 2008, so it should be documented even if a more specific compatible > > > is also added. > > > > Agree, and si/siram are also has been around since 2008. > > Where? I couldn't find them when grepping. Sorry, I make a mistake, they have not been in upstream. > > > In addition, I don’t think it is needed to add specific compatible, > > because they are the same in qe-supported soc. > > How do we know that they are 100% the same? You mean it will be changed in later version? BR -Zhao
On Thu, 2016-02-25 at 05:55 +0000, Qiang Zhao wrote: > On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote: > > -----Original Message----- > > From: Scott Wood [mailto:oss@buserror.net] > > Sent: Thursday, February 25, 2016 11:12 AM > > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org> > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device > > tree > > bindings. > > > > On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote: > > > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote: > > > > -----Original Message----- > > > > From: Scott Wood [mailto:oss@buserror.net] > > > > Sent: Wednesday, February 24, 2016 4:20 AM > > > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com> > > > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org; > > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > > > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to > > > > device tree bindings. > > > > > > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > > > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > > > > > Add IC, SI and SIRAM document of QE to > > > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > > > > > --- > > > > > > Changes for v2 > > > > > > - Add interrupt-controller in Required properties > > > > > > - delete address-cells and size-cells for qe-si and qe-siram > > > > > > > > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > > > > > ++++++++++++++++++++++ > > > > > > 1 file changed, 50 insertions(+) > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > index 4f89302..84052a7 100644 > > > > > > --- > > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx > > > > > > +++ t > > > > > > @@ -69,6 +69,56 @@ Example: > > > > > > }; > > > > > > }; > > > > > > > > > > > > +* Interrupt Controller (IC) > > > > > > + > > > > > > +Required properties: > > > > > > +- compatible : should be "fsl,qe-ic". > > > > > > > > > > > +- compatible : should be "fsl,qe-si". > > > > > > > > > > > +- compatible : should be "fsl,qe-siram". > > > > > > > > > > These compatible strings are all a bit generic and should have SoC > > > > > specific compatible strings. > > > > > > > > I don't know about si/siram, but "fsl,qe-ic" has been around since > > > > 2008, so it should be documented even if a more specific compatible > > > > is also added. > > > > > > Agree, and si/siram are also has been around since 2008. > > > > Where? I couldn't find them when grepping. > > Sorry, I make a mistake, they have not been in upstream. > > > > > > In addition, I don’t think it is needed to add specific compatible, > > > because they are the same in qe-supported soc. > > > > How do we know that they are 100% the same? > > You mean it will be changed in later version? That's always a possibility, but even on current chips, what bit of documentation are you referring to that confirms it's the exact same logic? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt index 4f89302..84052a7 100644 --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt @@ -69,6 +69,56 @@ Example: }; }; +* Interrupt Controller (IC) + +Required properties: +- compatible : should be "fsl,qe-ic". +- reg : Address range of IC register set. +- interrupts : interrupts generated by the device. +- interrupt-controller : this device is a interrupt controller. + +Example: + + qeic: interrupt-controller@80 { + interrupt-controller; + compatible = "fsl,qe-ic"; + #address-cells = <0>; + #interrupt-cells = <1>; + reg = <0x80 0x80>; + interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78 + }; + +* Serial Interface Block (SI) + +The SI manages the routing of eight TDM lines to the QE block serial drivers +, the MCC and the UCCs, for receive and transmit. + +Required properties: +- compatible : should be "fsl,qe-si". +- reg : Address range of SI register set. + +Example: + + si1: si@700 { + compatible = "fsl,qe-si"; + reg = <0x700 0x80>; + }; + +* Serial Interface Block RAM(SIRAM) + +store the routing entries of SI + +Required properties: +- compatible : should be "fsl,qe-siram". +- reg : Address range of SI RAM. + +Example: + + siram1: siram@1000 { + compatible = "fsl,qe-siram"; + reg = <0x1000 0x800>; + }; + * QE Firmware Node This node defines a firmware binary that is embedded in the device tree, for
Add IC, SI and SIRAM document of QE to Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- Changes for v2 - Add interrupt-controller in Required properties - delete address-cells and size-cells for qe-si and qe-siram .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+)