| Message ID | 1411471444-2764-10-git-send-email-boris.brezillon@free-electrons.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tuesday 23 September 2014 13:24:03 Boris BREZILLON wrote: > Add RTT bindings documentation. Two minor comments here: > +Atmel AT91SAM9260 Real Time Timer > + > +Required properties: > +- compatible: should be: "atmel,at91sam9260-rtt" > +- reg: should encode the memory region of the RTT controller > +- interrupts: rtt alarm/event interrupt > +- clocks: should contain one clock pointing to the slow clk This should document what the clock is used for, not where it's connected. > + > +rtt@fffffe00 { > + compatible = "atmel,at91sam9260-rtt"; > + reg = <0xfffffd20 0x10>; > + interrupts = <1 4 7>; > + clocks = <&clk32k>; > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > The register address fffffd20 does not match the name fffffe00 Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt new file mode 100644 index 0000000..f307a1d --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt @@ -0,0 +1,23 @@ +Atmel AT91SAM9260 Real Time Timer + +Required properties: +- compatible: should be: "atmel,at91sam9260-rtt" +- reg: should encode the memory region of the RTT controller +- interrupts: rtt alarm/event interrupt +- clocks: should contain one clock pointing to the slow clk +- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store + the time base when the RTT is used as an RTC. + The first cell should point to the GPBR node and the second one + encode the offset within the GPBR block (or in other words, the + GPBR register used to store the time base). + + +Example: + +rtt@fffffe00 { + compatible = "atmel,at91sam9260-rtt"; + reg = <0xfffffd20 0x10>; + interrupts = <1 4 7>; + clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; +};