| Message ID | 1410553499-55951-2-git-send-email-s-anna@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Suman, On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna <s-anna@ti.com> wrote: > This patch adds the generic common bindings used to represent > a hwlock device and use/request locks in a device-tree build. > ... > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > .../devicetree/bindings/hwlock/hwlock.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwlock/hwlock.txt Please ask a DT maintainer to ACK this - otherwise I can't send this to Linus. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Kumar, Mark, Rob, On 11/12/2014 09:14 AM, Ohad Ben-Cohen wrote: > Hi Suman, > > On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna <s-anna@ti.com> wrote: >> This patch adds the generic common bindings used to represent >> a hwlock device and use/request locks in a device-tree build. >> > ... >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> --- >> .../devicetree/bindings/hwlock/hwlock.txt | 55 ++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwlock/hwlock.txt > > Please ask a DT maintainer to ACK this - otherwise I can't send this to Linus. > Can one of you ack this patch and the next patch [1] so that Ohad can pick up the series for 3.19? This series has been in works for quite some time now and was reviewed by each of you at some point of time (thanks!!), the cover letter [2] has the history of the changes. regards Suman [1] https://patchwork.kernel.org/patch/4898001/ [2] http://marc.info/?l=linux-omap&m=141055365213895&w=2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 12, 2014 at 9:08 AM, Suman Anna <s-anna@ti.com> wrote: > Kumar, Mark, Rob, > > On 11/12/2014 09:14 AM, Ohad Ben-Cohen wrote: >> Hi Suman, >> >> On Fri, Sep 12, 2014 at 11:24 PM, Suman Anna <s-anna@ti.com> wrote: >>> This patch adds the generic common bindings used to represent >>> a hwlock device and use/request locks in a device-tree build. >>> >> ... >>> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Signed-off-by: Suman Anna <s-anna@ti.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> >>> --- >>> .../devicetree/bindings/hwlock/hwlock.txt | 55 ++++++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwlock/hwlock.txt >> >> Please ask a DT maintainer to ACK this - otherwise I can't send this to Linus. >> > > Can one of you ack this patch and the next patch [1] so that Ohad can > pick up the series for 3.19? This series has been in works for quite > some time now and was reviewed by each of you at some point of time > (thanks!!), the cover letter [2] has the history of the changes. > Could we please have a statement from a DT maintainer so we could move forward with this? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/hwlock/hwlock.txt b/Documentation/devicetree/bindings/hwlock/hwlock.txt new file mode 100644 index 0000000..24993dd --- /dev/null +++ b/Documentation/devicetree/bindings/hwlock/hwlock.txt @@ -0,0 +1,55 @@ +Generic hwlock bindings +======================= + +Generic bindings that are common to all the hwlock platform specific driver +implementations. + +The validity and need of these common properties may vary from one platform +implementation to another. The platform specific bindings should explicitly +state if an optional property is used. Please also look through the individual +platform specific hwlock binding documentations for identifying the applicable +properties. + +Common properties: +- #hwlock-cells: Specifies the number of cells needed to represent a + specific lock. This property is mandatory for all + platform implementations. +- hwlock-num-locks: Number of locks present in a hwlock device. This + property is needed on hwlock devices, where the number + of supported locks within a hwlock device cannot be + read from a register. +- hwlock-base-id: An unique base Id for the locks for a particular hwlock + device. This property is mandatory if a SoC has several + hwlock devices. + +Hwlock Users: +============= + +Nodes that require specific hwlock(s) should specify them using the property +"hwlocks", each containing a phandle to the hwlock node and an args specifier +value as indicated by #hwlock-cells. Multiple hwlocks can be requested using +an array of the phandle and hwlock number specifier tuple. + +1. Example of a node using a single specific hwlock: + +The following example has a node requesting a hwlock in the bank defined by +the node hwlock1. hwlock1 is a hwlock provider with an argument specifier +of length 1. + + node { + ... + hwlocks = <&hwlock1 2>; + ... + }; + +2. Example of a node using multiple specific hwlocks: + +The following example has a node requesting two hwlocks, a hwlock within +the hwlock device node 'hwlock1' with #hwlock-cells value of 1, and another +hwlock within the hwlock device node 'hwlock2' with #hwlock-cells value of 2. + + node { + ... + hwlocks = <&hwlock1 2>, <&hwlock2 0 3>; + ... + };
This patch adds the generic common bindings used to represent a hwlock device and use/request locks in a device-tree build. All the platform-specific hwlock driver implementations need the number of locks and associated base id for registering the locks present within the device with the driver core. This base id needs to be unique across multiple IP instances of a hwspinlock device, so that each hwlock can be represented uniquely in a system. The number of locks is represented by 'hwlock-num-locks' property, and the base id is represented by the 'hwlock-base-id' property. The args specifier length is dependent on each vendor-specific implementation and is represented through the '#hwlock-cells' property. Client users need to use the property 'hwlocks' for requesting specific lock(s). Note that the document is named hwlock.txt deliberately to keep it a bit more generic. Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Suman Anna <s-anna@ti.com> --- .../devicetree/bindings/hwlock/hwlock.txt | 55 ++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwlock/hwlock.txt