diff mbox

[v5,1/3] i2c: cadence: Document device tree bindings

Message ID 1396646876-27336-1-git-send-email-soren.brinkmann@xilinx.com
State Accepted, archived
Commit 893f0677725fec4927f78195a7c52fbe24c9e467
Headers show

Commit Message

Soren Brinkmann April 4, 2014, 9:27 p.m. UTC
Add device tree binding documentation for the Cadence I2C controller.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---

Changes in v5:
 - Document all properties
 - list clock-names as optional property (driver doesn't use it, though)
 - use lower case hex digits in 'reg' property
 - reword description of 'clocks' property
 - remove implementation specific notes regarding default speed
 - use #defines for interrupt specifier

Changes in v4:
 - moved adding DT docs into this dedicated patch

Changes in v3: None
Changes in v2: None

---
 .../devicetree/bindings/i2c/i2c-cadence.txt        | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-cadence.txt

Comments

Wolfram Sang April 6, 2014, 3:50 p.m. UTC | #1
On Fri, Apr 04, 2014 at 02:27:54PM -0700, Soren Brinkmann wrote:
> Add device tree binding documentation for the Cadence I2C controller.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Applied to for-next, thanks!
Wolfram Sang April 6, 2014, 3:51 p.m. UTC | #2
On Fri, Apr 04, 2014 at 02:27:55PM -0700, Soren Brinkmann wrote:
> Add a driver for the Cadence I2C controller. This controller is for
> example found in Xilinx Zynq.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Harini Katakam <harinik@xilinx.com>

Applied to for-next, thanks!
Michal Simek April 7, 2014, 5:47 a.m. UTC | #3
On 04/04/2014 11:27 PM, Soren Brinkmann wrote:
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> Changes in v5:
>  - use lower case hex digits in 'reg' property
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
>  - replace 'pmbus' with 'ti' in compatibility strings of UCD devices
> 
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi | 22 ++++++++++++
>  arch/arm/boot/dts/zynq-zc702.dts | 76 ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/zynq-zc706.dts | 68 +++++++++++++++++++++++++++++++++++
>  3 files changed, 166 insertions(+)

Applied to zynq-dt branch.

Thanks,
Michal
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
new file mode 100644
index 000000000000..7cb0b5608f49
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
@@ -0,0 +1,24 @@ 
+Binding for the Cadence I2C controller
+
+Required properties:
+  - reg: Physical base address and size of the controller's register area.
+  - compatible: Compatibility string. Must be 'cdns,i2c-r1p10'.
+  - clocks: Input clock specifier. Refer to common clock bindings.
+  - interrupts: Interrupt specifier. Refer to interrupt bindings.
+  - #address-cells: Should be 1.
+  - #size-cells: Should be 0.
+
+Optional properties:
+  - clock-frequency: Desired operating frequency, in Hz, of the bus.
+  - clock-names: Input clock name, should be 'pclk'.
+
+Example:
+	i2c@e0004000 {
+		compatible = "cdns,i2c-r1p10";
+		clocks = <&clkc 38>;
+		interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+		reg = <0xe0004000 0x1000>;
+		clock-frequency = <400000>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};