diff mbox

devicetree: macb: Document clock properties

Message ID 1386972205-32733-1-git-send-email-soren.brinkmann@xilinx.com
State Accepted, archived
Commit e2897d7e0b0460dca91b52d55ce41c888363502d
Headers show

Commit Message

Soren Brinkmann Dec. 13, 2013, 10:03 p.m. UTC
The macb driver uses the clock bindings. Document the required
properties, especially the driver specific clock-names.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 Documentation/devicetree/bindings/net/macb.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Nicolas Ferre Dec. 16, 2013, 9:46 a.m. UTC | #1
On 13/12/2013 23:03, Soren Brinkmann :
> The macb driver uses the clock bindings. Document the required
> properties, especially the driver specific clock-names.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks.

> ---
>  Documentation/devicetree/bindings/net/macb.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 4ff65047bb9a..70af2ec12b09 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -10,6 +10,10 @@ Required properties:
>  - interrupts: Should contain macb interrupt
>  - phy-mode: String, operation mode of the PHY interface.
>    Supported values are: "mii", "rmii", "gmii", "rgmii".
> +- clock-names: Tuple listing input clock names.
> +	Required elements: 'pclk', 'hclk'
> +	Optional elements: 'tx_clk'
> +- clocks: Phandles to input clocks.
>  
>  Optional properties:
>  - local-mac-address: 6 bytes, mac address
> @@ -22,4 +26,6 @@ Examples:
>  		interrupts = <21>;
>  		phy-mode = "rmii";
>  		local-mac-address = [3a 0e 03 04 05 06];
> +		clock-names = "pclk", "hclk", "tx_clk";
> +		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
>  	};
>
Michal Simek Dec. 19, 2013, 10:36 a.m. UTC | #2
On 12/16/2013 10:46 AM, Nicolas Ferre wrote:
> On 13/12/2013 23:03, Soren Brinkmann :
>> The macb driver uses the clock bindings. Document the required
>> properties, especially the driver specific clock-names.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Has someone taken this patch?
If not, Rob can you please add it to your tree?

Thanks,
Michal
Soren Brinkmann Jan. 6, 2014, 4:10 p.m. UTC | #3
Hi,

On Thu, Dec 19, 2013 at 11:36:29AM +0100, Michal Simek wrote:
> On 12/16/2013 10:46 AM, Nicolas Ferre wrote:
> > On 13/12/2013 23:03, Soren Brinkmann :
> >> The macb driver uses the clock bindings. Document the required
> >> properties, especially the driver specific clock-names.
> >>
> >> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > 
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> Has someone taken this patch?
> If not, Rob can you please add it to your tree?

Since nobody responded to Michal's question and I also don't see this in
next yet, I just wanted to check in on the status. Does anybody take
this for 3.14?

	Sören


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 4ff65047bb9a..70af2ec12b09 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -10,6 +10,10 @@  Required properties:
 - interrupts: Should contain macb interrupt
 - phy-mode: String, operation mode of the PHY interface.
   Supported values are: "mii", "rmii", "gmii", "rgmii".
+- clock-names: Tuple listing input clock names.
+	Required elements: 'pclk', 'hclk'
+	Optional elements: 'tx_clk'
+- clocks: Phandles to input clocks.
 
 Optional properties:
 - local-mac-address: 6 bytes, mac address
@@ -22,4 +26,6 @@  Examples:
 		interrupts = <21>;
 		phy-mode = "rmii";
 		local-mac-address = [3a 0e 03 04 05 06];
+		clock-names = "pclk", "hclk", "tx_clk";
+		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
 	};