diff mbox series

dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support

Message ID 13643259be4e8a8e30632de622ad7c685dbb7c61.1713526852.git.geert+renesas@glider.be
State Not Applicable
Headers show
Series dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779h0 support | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Geert Uytterhoeven April 19, 2024, 11:42 a.m. UTC
From: Thanh Le <thanh.le.xv@renesas.com>

Document support for the I/O Memory Management Unit (IPMMU) on the
Renesas R-Car V4M (R8A779H0) SoC.

Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
property could be added again.
As nothing really uses this register and the associated bit numbers,
I think it is better to keep it simple, and not partially revert commit
b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
R-Car Gen4").
---
 Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Yoshihiro Shimoda April 22, 2024, 12:20 a.m. UTC | #1
Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Friday, April 19, 2024 8:42 PM
> 
> From: Thanh Le <thanh.le.xv@renesas.com>
> 
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
> 
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
> for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
> property could be added again.
> As nothing really uses this register and the associated bit numbers,
> I think it is better to keep it simple, and not partially revert commit
> b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
> R-Car Gen4").

Thank you for the patch! I think so. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index be90f68c11d18b03..0acaa2bcec0898b2 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -50,6 +50,7 @@ properties:
>                - renesas,ipmmu-r8a779a0           # R-Car V3U
>                - renesas,ipmmu-r8a779f0           # R-Car S4-8
>                - renesas,ipmmu-r8a779g0           # R-Car V4H
> +              - renesas,ipmmu-r8a779h0           # R-Car V4M
>            - const: renesas,rcar-gen4-ipmmu-vmsa  # R-Car Gen4
> 
>    reg:
> --
> 2.34.1
Rob Herring (Arm) April 22, 2024, 2:33 p.m. UTC | #2
On Fri, 19 Apr 2024 13:42:11 +0200, Geert Uytterhoeven wrote:
> From: Thanh Le <thanh.le.xv@renesas.com>
> 
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
> 
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Interestingly, the IMSSTR register is documented for R-Car V4M, unlike
> for R-Car S4 and R-Car V4H, so the second cell of the renesas,ipmmu-main
> property could be added again.
> As nothing really uses this register and the associated bit numbers,
> I think it is better to keep it simple, and not partially revert commit
> b67ab6fb63bbbe6d ("dt-bindings: iommu: renesas, ipmmu-vmsa: Update for
> R-Car Gen4").
> ---
>  Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Joerg Roedel April 26, 2024, 10:04 a.m. UTC | #3
On Fri, Apr 19, 2024 at 01:42:11PM +0200, Geert Uytterhoeven wrote:
> From: Thanh Le <thanh.le.xv@renesas.com>
> 
> Document support for the I/O Memory Management Unit (IPMMU) on the
> Renesas R-Car V4M (R8A779H0) SoC.
> 
> Signed-off-by: Thanh Le <thanh.le.xv@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index be90f68c11d18b03..0acaa2bcec0898b2 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -50,6 +50,7 @@  properties:
               - renesas,ipmmu-r8a779a0           # R-Car V3U
               - renesas,ipmmu-r8a779f0           # R-Car S4-8
               - renesas,ipmmu-r8a779g0           # R-Car V4H
+              - renesas,ipmmu-r8a779h0           # R-Car V4M
           - const: renesas,rcar-gen4-ipmmu-vmsa  # R-Car Gen4
 
   reg: