| Message ID | cover.1702862778.git.zhoubinbin@loongson.cn |
|---|---|
| Headers | show |
| Series | LoongArch: Add built-in dtb support | expand |
On 18/12/2023 02:52, Binbin Zhou wrote: > Add DeviceTree file for Loongson-2K0500 processor, which integrates one > 64-bit dual emission superscalar LA264 processor core. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > arch/loongarch/boot/dts/Makefile | 2 + > .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++ > arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++ > 3 files changed, 365 insertions(+) > create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts > create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi > > diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile > index 1e24cdb5180a..aa0b21d73d4e 100644 > --- a/arch/loongarch/boot/dts/Makefile > +++ b/arch/loongarch/boot/dts/Makefile > @@ -1,3 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > > +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb > + > obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) > diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > new file mode 100644 > index 000000000000..52483127a419 > --- /dev/null > +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > @@ -0,0 +1,89 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Loongson Technology Corporation Limited > + */ > + > +/dts-v1/; > + > +#include "loongson-2k0500.dtsi" > + > +/ { > + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500"; > + model = "Loongson-2K0500 Reference Board"; > + > + aliases { > + ethernet0 = &gmac0; > + ethernet1 = &gmac1; > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + bootargs = "console=ttyS0,115200"; You received here comments already: https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@linaro.org/ Don't waste our time to re-review the same mistakes over and over again. ... > + > + i2c@1ff4a800 { > + compatible = "loongson,ls2k-i2c"; > + reg = <0x0 0x1ff4a800 0x0 0x0800>; > + interrupt-parent = <&eiointc>; > + interrupts = <19>; > + status = "disabled"; > + }; > + > + pmc: power-management@1ff6c000 { > + compatible = "loongson,ls2k0500-pmc", "syscon"; It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Or you did not test your DTS on the hardware. > + reg = <0x0 0x1ff6c000 0x0 0x58>; > + interrupt-parent = <&eiointc>; > + interrupts = <56>; > + loongson,suspend-address = <0x0 0x1c000500>; > + > + syscon-reboot { Best regards, Krzysztof
On 18/12/2023 02:52, Binbin Zhou wrote: > Add DeviceTree file for Loongson-2K1000 processor, which integrates two > 64-bit dual emission superscalar LA264 processor cores. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > arch/loongarch/boot/dts/Makefile | 3 +- > .../boot/dts/loongson-2k1000-ref.dts | 184 +++++++ > arch/loongarch/boot/dts/loongson-2k1000.dtsi | 453 ++++++++++++++++++ > 3 files changed, 639 insertions(+), 1 deletion(-) > create mode 100644 arch/loongarch/boot/dts/loongson-2k1000-ref.dts > create mode 100644 arch/loongarch/boot/dts/loongson-2k1000.dtsi > > diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile > index aa0b21d73d4e..dc0782315bed 100644 > --- a/arch/loongarch/boot/dts/Makefile > +++ b/arch/loongarch/boot/dts/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb > +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb \ > + loongson-2k1000-ref.dtb > > obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) > diff --git a/arch/loongarch/boot/dts/loongson-2k1000-ref.dts b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts > new file mode 100644 > index 000000000000..95346bcbea71 > --- /dev/null > +++ b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts > @@ -0,0 +1,184 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Loongson Technology Corporation Limited > + */ > + > +/dts-v1/; > + > +#include "loongson-2k1000.dtsi" > + > +/ { > + compatible = "loongson,ls2k1000-ref", "loongson,ls2k1000"; > + model = "Loongson-2K1000 Reference Board"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + bootargs = "console=ttyS0,115200"; NAK. Don't ignore the review. Best regards, Krzysztof
On 18/12/2023 02:53, Binbin Zhou wrote: > Add DeviceTree file for Loongson-2K2000 processor, which integrates two > 64-bit triple emission superscalar LA364 processor cores. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > arch/loongarch/boot/dts/Makefile | 3 +- > .../boot/dts/loongson-2k2000-ref.dts | 73 ++++ > arch/loongarch/boot/dts/loongson-2k2000.dtsi | 311 ++++++++++++++++++ > 3 files changed, 386 insertions(+), 1 deletion(-) > create mode 100644 arch/loongarch/boot/dts/loongson-2k2000-ref.dts > create mode 100644 arch/loongarch/boot/dts/loongson-2k2000.dtsi > > diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile > index dc0782315bed..c019d6676f7e 100644 > --- a/arch/loongarch/boot/dts/Makefile > +++ b/arch/loongarch/boot/dts/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > > dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb \ > - loongson-2k1000-ref.dtb > + loongson-2k1000-ref.dtb \ > + loongson-2k2000-ref.dtb > > obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) > diff --git a/arch/loongarch/boot/dts/loongson-2k2000-ref.dts b/arch/loongarch/boot/dts/loongson-2k2000-ref.dts > new file mode 100644 > index 000000000000..ac6b370800fa > --- /dev/null > +++ b/arch/loongarch/boot/dts/loongson-2k2000-ref.dts > @@ -0,0 +1,73 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Loongson Technology Corporation Limited > + */ > + > +/dts-v1/; > + > +#include "loongson-2k2000.dtsi" > + > +/ { > + compatible = "loongson,ls2k2000-ref", "loongson,ls2k2000"; > + model = "Loongson-2K2000 Reference Board"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + bootargs = "console=ttyS0,115200"; Nope. Best regards, Krzysztof
On Mon, Dec 18, 2023 at 09:52:58AM +0800, Binbin Zhou wrote: > diff --git a/arch/loongarch/boot/dts/loongson-2k0500.dtsi b/arch/loongarch/boot/dts/loongson-2k0500.dtsi > new file mode 100644 > index 000000000000..1dcb6a20fc6c > --- /dev/null > +++ b/arch/loongarch/boot/dts/loongson-2k0500.dtsi > @@ -0,0 +1,274 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Loongson Technology Corporation Limited > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/interrupt-controller/irq.h> > + > +/ { > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + }; > + }; You have only one CPU, this should not be needed. > + > + cpu0: cpu@0 { > + compatible = "loongson,la264"; > + device_type = "cpu"; > + reg = <0x0>; > + clocks = <&cpu_clk>; Is this actually a complete description of the cpu? Are there i/d caches etc? Cheers, Conor.
On Mon, Dec 18, 2023 at 09:52:59AM +0800, Binbin Zhou wrote: > +/ { > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + core1 { > + cpu = <&cpu1>; > + }; > + }; > + }; > + > + cpu0: cpu@0 { > + compatible = "loongson,la264"; > + device_type = "cpu"; > + reg= <0x0>; > + clocks = <&clk LOONGSON2_NODE_CLK>; > + }; > + > + cpu1: cpu@1 { > + compatible = "loongson,la264"; > + device_type = "cpu"; > + reg = <0x1>; > + clocks = <&clk LOONGSON2_NODE_CLK>; > + }; > + }; Even with 2 CPUs, the cpu-map should not really be needed. The generic topology code that is used by riscv and arm64 should be able to determine that these two cpus are in the same cluster (See CONFIG_GENERIC_ARCH_TOPOLOGY) provided you populate the next level cache in the cpu devicetree nodes. As with the ls2k0500, you have no i, d or next level cache information in these nodes, which I suspect your hardware actually has? I wired this generic "fallback" code up for riscv in this series here: https://lore.kernel.org/all/20220715175155.3567243-3-mail@conchuod.ie/ Cheers, Conor.
On Tue, Dec 19, 2023 at 9:37 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 18/12/2023 02:52, Binbin Zhou wrote: > > Add DeviceTree file for Loongson-2K0500 processor, which integrates one > > 64-bit dual emission superscalar LA264 processor core. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > arch/loongarch/boot/dts/Makefile | 2 + > > .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++ > > arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++ > > 3 files changed, 365 insertions(+) > > create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts > > create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi > > > > diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile > > index 1e24cdb5180a..aa0b21d73d4e 100644 > > --- a/arch/loongarch/boot/dts/Makefile > > +++ b/arch/loongarch/boot/dts/Makefile > > @@ -1,3 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > > > +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb > > + > > obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) > > diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > > new file mode 100644 > > index 000000000000..52483127a419 > > --- /dev/null > > +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > > @@ -0,0 +1,89 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2023 Loongson Technology Corporation Limited > > + */ > > + > > +/dts-v1/; > > + > > +#include "loongson-2k0500.dtsi" > > + > > +/ { > > + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500"; > > + model = "Loongson-2K0500 Reference Board"; > > + > > + aliases { > > + ethernet0 = &gmac0; > > + ethernet1 = &gmac1; > > + serial0 = &uart0; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + bootargs = "console=ttyS0,115200"; > > You received here comments already: > https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@linaro.org/ > > Don't waste our time to re-review the same mistakes over and over again. > > Hi Krzysztof: I am sorry for this, I misunderstood before that `earlycon` is not allowed. BTW, is there a note about not using the `bootargs` attribute? I didn't find it in the Documentation. > > ... > > > + > > + i2c@1ff4a800 { > > + compatible = "loongson,ls2k-i2c"; > > + reg = <0x0 0x1ff4a800 0x0 0x0800>; > > + interrupt-parent = <&eiointc>; > > + interrupts = <19>; > > + status = "disabled"; > > + }; > > + > > + pmc: power-management@1ff6c000 { > > + compatible = "loongson,ls2k0500-pmc", "syscon"; > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). Emm... Here is the compatible description from the latest kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml#n13 I think this compatible should be fine, also, I ensure that `make dtbs_check W=1` is fine before committing. Thanks. Binbin > > Or you did not test your DTS on the hardware. > > > + reg = <0x0 0x1ff6c000 0x0 0x58>; > > + interrupt-parent = <&eiointc>; > > + interrupts = <56>; > > + loongson,suspend-address = <0x0 0x1c000500>; > > + > > + syscon-reboot { > > > > Best regards, > Krzysztof >
Hi Conor: On Tue, Dec 19, 2023 at 10:05 PM Conor Dooley <conor@kernel.org> wrote: > > On Mon, Dec 18, 2023 at 09:52:58AM +0800, Binbin Zhou wrote: > > diff --git a/arch/loongarch/boot/dts/loongson-2k0500.dtsi b/arch/loongarch/boot/dts/loongson-2k0500.dtsi > > new file mode 100644 > > index 000000000000..1dcb6a20fc6c > > --- /dev/null > > +++ b/arch/loongarch/boot/dts/loongson-2k0500.dtsi > > @@ -0,0 +1,274 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2023 Loongson Technology Corporation Limited > > + */ > > + > > +/dts-v1/; > > + > > +#include <dt-bindings/interrupt-controller/irq.h> > > + > > +/ { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu-map { > > + cluster0 { > > + core0 { > > + cpu = <&cpu0>; > > + }; > > + }; > > + }; > > You have only one CPU, this should not be needed. OK! > > > + > > + cpu0: cpu@0 { > > + compatible = "loongson,la264"; > > + device_type = "cpu"; > > + reg = <0x0>; > > + clocks = <&cpu_clk>; > > Is this actually a complete description of the cpu? Are there i/d caches > etc? The cpu i/d caches are present, but the architecture gets the values through a particular instruction (`cpucfg`). So I didn't describe it here. Thanks. Binbin > > Cheers, > Conor.
On 20/12/2023 10:17, Binbin Zhou wrote: > On Tue, Dec 19, 2023 at 9:37 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 18/12/2023 02:52, Binbin Zhou wrote: >>> Add DeviceTree file for Loongson-2K0500 processor, which integrates one >>> 64-bit dual emission superscalar LA264 processor core. >>> >>> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> >>> --- >>> arch/loongarch/boot/dts/Makefile | 2 + >>> .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++ >>> arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++ >>> 3 files changed, 365 insertions(+) >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi >>> >>> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile >>> index 1e24cdb5180a..aa0b21d73d4e 100644 >>> --- a/arch/loongarch/boot/dts/Makefile >>> +++ b/arch/loongarch/boot/dts/Makefile >>> @@ -1,3 +1,5 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> >>> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb >>> + >>> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) >>> diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts >>> new file mode 100644 >>> index 000000000000..52483127a419 >>> --- /dev/null >>> +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts >>> @@ -0,0 +1,89 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (C) 2023 Loongson Technology Corporation Limited >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include "loongson-2k0500.dtsi" >>> + >>> +/ { >>> + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500"; >>> + model = "Loongson-2K0500 Reference Board"; >>> + >>> + aliases { >>> + ethernet0 = &gmac0; >>> + ethernet1 = &gmac1; >>> + serial0 = &uart0; >>> + }; >>> + >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + bootargs = "console=ttyS0,115200"; >> >> You received here comments already: >> https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@linaro.org/ >> >> Don't waste our time to re-review the same mistakes over and over again. >> >> > Hi Krzysztof: > > I am sorry for this, I misunderstood before that `earlycon` is not allowed. > BTW, is there a note about not using the `bootargs` attribute? I > didn't find it in the Documentation. This is a common sense, not a "note". If you think otherwise, please provide me the reasons why duplicated information is necessary in this particular case. > >> >> ... >> >>> + >>> + i2c@1ff4a800 { >>> + compatible = "loongson,ls2k-i2c"; >>> + reg = <0x0 0x1ff4a800 0x0 0x0800>; >>> + interrupt-parent = <&eiointc>; >>> + interrupts = <19>; >>> + status = "disabled"; >>> + }; >>> + >>> + pmc: power-management@1ff6c000 { >>> + compatible = "loongson,ls2k0500-pmc", "syscon"; >> >> It does not look like you tested the DTS against bindings. Please run >> `make dtbs_check W=1` (see >> Documentation/devicetree/bindings/writing-schema.rst or >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ >> for instructions). > > Emm... > Here is the compatible description from the latest kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml#n13 > > I think this compatible should be fine, also, I ensure that `make > dtbs_check W=1` is fine before committing. Hm, that's fine then. Best regards, Krzysztof
On Wed, Dec 20, 2023 at 4:29 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 20/12/2023 10:17, Binbin Zhou wrote: > > On Tue, Dec 19, 2023 at 9:37 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 18/12/2023 02:52, Binbin Zhou wrote: > >>> Add DeviceTree file for Loongson-2K0500 processor, which integrates one > >>> 64-bit dual emission superscalar LA264 processor core. > >>> > >>> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > >>> --- > >>> arch/loongarch/boot/dts/Makefile | 2 + > >>> .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++ > >>> arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++ > >>> 3 files changed, 365 insertions(+) > >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts > >>> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi > >>> > >>> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile > >>> index 1e24cdb5180a..aa0b21d73d4e 100644 > >>> --- a/arch/loongarch/boot/dts/Makefile > >>> +++ b/arch/loongarch/boot/dts/Makefile > >>> @@ -1,3 +1,5 @@ > >>> # SPDX-License-Identifier: GPL-2.0-only > >>> > >>> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb > >>> + > >>> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) > >>> diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > >>> new file mode 100644 > >>> index 000000000000..52483127a419 > >>> --- /dev/null > >>> +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts > >>> @@ -0,0 +1,89 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Copyright (C) 2023 Loongson Technology Corporation Limited > >>> + */ > >>> + > >>> +/dts-v1/; > >>> + > >>> +#include "loongson-2k0500.dtsi" > >>> + > >>> +/ { > >>> + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500"; > >>> + model = "Loongson-2K0500 Reference Board"; > >>> + > >>> + aliases { > >>> + ethernet0 = &gmac0; > >>> + ethernet1 = &gmac1; > >>> + serial0 = &uart0; > >>> + }; > >>> + > >>> + chosen { > >>> + stdout-path = "serial0:115200n8"; > >>> + bootargs = "console=ttyS0,115200"; > >> > >> You received here comments already: > >> https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@linaro.org/ > >> > >> Don't waste our time to re-review the same mistakes over and over again. > >> > >> > > Hi Krzysztof: > > > > I am sorry for this, I misunderstood before that `earlycon` is not allowed. > > BTW, is there a note about not using the `bootargs` attribute? I > > didn't find it in the Documentation. > > This is a common sense, not a "note". If you think otherwise, please > provide me the reasons why duplicated information is necessary in this > particular case. > Hi Krzysztof: I checked the relevant code and the console parameter is already in the stdout-path property. Sorry I didn't get the logic here before, thanks for pointing it out. The previous attempt to leave it because it would affect the boot cmdline proved not to be the right way to do it, so we fixed it some other way. Anyway, I'll fix it in the next patch set. Thanks. Binbin > > > >> > >> ... > >> > >>> + > >>> + i2c@1ff4a800 { > >>> + compatible = "loongson,ls2k-i2c"; > >>> + reg = <0x0 0x1ff4a800 0x0 0x0800>; > >>> + interrupt-parent = <&eiointc>; > >>> + interrupts = <19>; > >>> + status = "disabled"; > >>> + }; > >>> + > >>> + pmc: power-management@1ff6c000 { > >>> + compatible = "loongson,ls2k0500-pmc", "syscon"; > >> > >> It does not look like you tested the DTS against bindings. Please run > >> `make dtbs_check W=1` (see > >> Documentation/devicetree/bindings/writing-schema.rst or > >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > >> for instructions). > > > > Emm... > > Here is the compatible description from the latest kernel: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml#n13 > > > > I think this compatible should be fine, also, I ensure that `make > > dtbs_check W=1` is fine before committing. > > Hm, that's fine then. > > Best regards, > Krzysztof >
Hi all: This patchset introduces LoongArch's built-in dtb support. During the upstream progress of those DT-based drivers, DT properties are changed a lot so very different from those in existing bootloaders. It is inevitably that some existing systems do not provide a standard, canonical device tree to the kernel at boot time. So let's provide a device tree table in the kernel, keyed by the dts filename, containing the relevant DTBs. We can use the built-in dts files as references. Each SoC has only one built-in dts file which describes all possible device information of that SoC, so the dts files are good examples during development. And as a reference, our built-in dts file only enables the most basic bootable combinations (so it is generic enough), acts as an alternative in case the dts in the bootloader is unexpected. In the past while, we resolved the DTC_CHK warning for the v4 patchset, and the relevant patchset has either been received or had the Reviewed-by tag added. Now, we need to rely on the following patch sets: 1. liointc https://lore.kernel.org/all/cover.1701933946.git.zhoubinbin@loongson.cn/ Reviewed-by tag has been added. 2. pmc https://lore.kernel.org/all/cover.1700817227.git.zhoubinbin@loongson.cn/ has been received by Daniel. Thanks. ----- V5: patch(1/7): - Add reviewed-by tag. patch(3/7): - Rewrite commit message to describe the reason for needing the build-in DTB. patch(4/7): - Add Power-Manager node. patch(5/7): - Add Power-Manager node. - Add spi node. - Add pmc node. patch(6/7): - Add Power-Manager node. Link to V4: https://lore.kernel.org/all/cover.1692783907.git.zhoubinbin@loongson.cn/ V4: patch(1/7): - Drop device_type property. patch(2/7): - Rename board.yaml to loongson.yaml. patch(4/7): - Keep the ranges attribute after compatible; - Add bootargs = "ttyS0,115200", which is needed for reference board; patch(5/7): - Keep the ranges attribute after compatible; - Add bootargs = "ttyS0,115200", which is needed for reference board; - Change node name global-utilities to chipid. patch(6/7): - Keep the ranges attribute after compatible; - Add bootargs = "ttyS0,115200", which is needed for reference board. Link to V3: https://lore.kernel.org/all/cover.1692618548.git.zhoubinbin@loongson.cn/ V3: patch(1/7): - Add reference to the common cpu schema. patch(2/7): - Add reviewed-by tag. patch(4/7): - Drop bootargs; - Move the cpus node to dtsi, which is part of the SoC. patch(5/7): - Drop bootargs; - Move the cpus node to dtsi, which is part of the SoC; - Fix gmac0/1-mdio node: compatible is always the first property; - Drop i2c-gpio node. patch(6/7): - Drop bootargs; - Move the cpus node to dtsi, which is part of the SoC. - Changes liointc to liointc-1.0, for Loongson-2K2000 has 32 interrupt sources. Link to V2: https://lore.kernel.org/all/cover.1692088166.git.zhoubinbin@loongson.cn/ V2: patch(1/7): - Drop model and clock-frequency properties; - Add clocks property; - Rewrite the description. patch(2/7): - Add the proper compatibles for boards. patch(4/7)(5/7)(6/7): - Format commit message head; - Drop undocumented compatible, such as pci_bridge compatible; - Distinguish the attributes, put SoC-related into DTSI and board-related into DTS; - Check DTS with 'make dtbs_check W=1'. patch(7/7) - New patch; - Parses Molde name and CPU MHz from the DTS attribute. Link to V1: https://lore.kernel.org/loongarch/cover.1686882123.git.zhoubinbin@loongson.cn/ Binbin Zhou (7): dt-bindings: loongarch: Add CPU bindings for LoongArch dt-bindings: loongarch: Add Loongson SoC boards compatibles LoongArch: Allow device trees to be built into the kernel LoongArch: dts: DeviceTree for Loongson-2K0500 LoongArch: dts: DeviceTree for Loongson-2K1000 LoongArch: dts: DeviceTree for Loongson-2K2000 LoongArch: Parsing CPU-related information from DTS .../devicetree/bindings/loongarch/cpus.yaml | 61 +++ .../bindings/loongarch/loongson.yaml | 34 ++ arch/loongarch/Kconfig | 18 + arch/loongarch/Makefile | 10 +- arch/loongarch/boot/dts/Makefile | 7 +- .../boot/dts/loongson-2k0500-ref.dts | 89 ++++ arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 +++++++++++ .../boot/dts/loongson-2k1000-ref.dts | 184 +++++++ arch/loongarch/boot/dts/loongson-2k1000.dtsi | 453 ++++++++++++++++++ .../boot/dts/loongson-2k2000-ref.dts | 73 +++ arch/loongarch/boot/dts/loongson-2k2000.dtsi | 311 ++++++++++++ arch/loongarch/kernel/env.c | 34 +- arch/loongarch/kernel/setup.c | 9 +- 13 files changed, 1550 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml create mode 100644 Documentation/devicetree/bindings/loongarch/loongson.yaml create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi create mode 100644 arch/loongarch/boot/dts/loongson-2k1000-ref.dts create mode 100644 arch/loongarch/boot/dts/loongson-2k1000.dtsi create mode 100644 arch/loongarch/boot/dts/loongson-2k2000-ref.dts create mode 100644 arch/loongarch/boot/dts/loongson-2k2000.dtsi