| Message ID | cover.1685703605.git.quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable IPQ9574 TSENS support | expand |
On Fri, Jun 02, 2023 at 04:33:49PM +0530, Varadarajan Narayanan wrote: > This patch set enables tsens in IPQ9574 > > Depends on > https://lore.kernel.org/linux-arm-msm/20230406061314.10916-1-quic_devipriy@quicinc.com/ > [v5]: > Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors without removing existing entries > > [v4]: > Drop the sm6375-tsens and qcm2290-tsens related bindings > fix as it is already posted > > Remove unnecessary changes from previous version > > [v3]: > Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors > > [v2]: > Drop the driver change (https://lore.kernel.org/lkml/b45d33d38a334aabbd52c83b0d6028af1f4c74c8.1682682753.git.quic_varada@quicinc.com/) > since the tsens device is compatible with 8074's tsens > and use 8074's compatible itself > > Rename clusterX nodes as cpussX > > [v1]: > Fix DT node names > > [v0]: > Initial patch introducing TSENS support > > Praveenkumar I (1): > dt-bindings: thermal: tsens: Add ipq9574 compatible > > Varadarajan Narayanan (2): > arm64: dts: qcom: ipq9574: add tsens node > arm64: dts: qcom: ipq9574: add thermal zone nodes > > .../devicetree/bindings/thermal/qcom-tsens.yaml | 6 + > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 218 +++++++++++++++++++++ > 2 files changed, 224 insertions(+) > > -- > 2.7.4 > Bjorn, Can this series be taken for 6.5? All comments have been addressed. Thanks Varada
On 2.06.2023 13:03, Varadarajan Narayanan wrote: > IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures > around the various subsystems on the die. > > Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > [v5]: > Incorporate review comments "fix bug" is too vague.. > > [v2]: > Add "qcom,ipq8074-tsens" as fallback compatible > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 0baeb10..cda3fd4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -206,6 +206,16 @@ > #size-cells = <1>; > }; > > + tsens: thermal-sensor@4a9000 { > + compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens"; > + reg = <0x004a9000 0x1000>, /* TM */ > + <0x004a8000 0x1000>; /* SROT */ The comments are unnecessary, we've been copypasting them from SoC to SoC but it's time we stop. With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "combined"; > + #qcom,sensors = <16>; > + #thermal-sensor-cells = <1>; > + }; > + > tlmm: pinctrl@1000000 { > compatible = "qcom,ipq9574-tlmm"; > reg = <0x01000000 0x300000>;