| Message ID | cover.1627559126.git.mchehab+huawei@kernel.org |
|---|---|
| Headers | show |
| Series | DT schema changes for HiKey970 PCIe hardware to work | expand |
On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > Hi Rob, > > After our discussions, I'm opting to submit first the DT bindings for the > Kirin 970 PCIe support. > > Patch 1 is there just because patch 2 needs. You already acked on it. > > Patch 5 is also there just as an example of the entire stuff added to > the DTS file. > > The core of this series are patches 2 to 4. They contain the conversion > of the kirin-pcie.txt file to the DT schema, and adds the needed > bindings. > > Currently, it generates some warnings: > > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml This should be fixed now in dtschema master. > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob
Hi Rob, After our discussions, I'm opting to submit first the DT bindings for the Kirin 970 PCIe support. Patch 1 is there just because patch 2 needs. You already acked on it. Patch 5 is also there just as an example of the entire stuff added to the DTS file. The core of this series are patches 2 to 4. They contain the conversion of the kirin-pcie.txt file to the DT schema, and adds the needed bindings. Currently, it generates some warnings: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Not sure how/where to fix those. Perhaps at the pci-bus.yaml? Please review. Thanks! Mauro Manivannan Sadhasivam (1): arm64: dts: HiSilicon: Add support for HiKey 970 PCIe controller hardware Mauro Carvalho Chehab (4): dt-bindings: PCI: kirin: Fix compatible string dt-bindings: PCI: kirin: convert kirin-pcie.txt to yaml dt-bindings: PCI: kirin: Add support for Kirin970 dt-bindings: phy: Add bindings for HiKey 970 PCIe PHY .../bindings/pci/hisilicon,kirin-pcie.yaml | 145 ++++++++++++++++++ .../devicetree/bindings/pci/kirin-pcie.txt | 50 ------ .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- .../phy/hisilicon,phy-hi3670-pcie.yaml | 86 +++++++++++ MAINTAINERS | 2 +- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 99 ++++++++++++ 6 files changed, 332 insertions(+), 52 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml delete mode 100644 Documentation/devicetree/bindings/pci/kirin-pcie.txt create mode 100644 Documentation/devicetree/bindings/phy/hisilicon,phy-hi3670-pcie.yaml