mbox series

[v3,0/4] iio: vcnl4000: Export near level property for proximity sensor

Message ID cover.1585134362.git.agx@sigxcpu.org
Headers show
Series iio: vcnl4000: Export near level property for proximity sensor | expand

Message

Guido Günther March 25, 2020, 11:09 a.m. UTC
If an object can be considered close to the device that has the proximity
sensor built in is hardware dependent. Allowing to configure the property via
device tree allows to export this device specific value to userspace via
ext_info. This is useful for e.g. iio-sensor-proxy.

This came up when adding proximity support to iio-sensor-proxy [1], [2], it is
not meant as a vcnl4000 thing but rather as something useful for other proximity
sensors too in the future.

I've not converted the vcnl4000 binding docs to yaml but can do so as part of
this series in a v2 if the approach makes sense.

Changes from v2:
- as per review comment by Lars-Peter Clausen
  https://lore.kernel.org/linux-iio/c787921f-c412-4986-14ea-e31b531d3d5b@metafoo.de/
  Switch sysfs name to `nearlevel`
- as per review comment by Nishant Malpani
  https://lore.kernel.org/linux-iio/f5ea512c-d427-94c7-cf5f-f1300cbd4aa3@gmail.com/
  Add manufacturer do binding document name
- as per review comments by Andy Shevchenko
  - Drop superfluous blank line
  - Check return value of device_property_read_u32 for '!= 0' instead of '< 0'

Changes from v1:
- as per review comments by Jonathan Cameron
  https://lore.kernel.org/linux-iio/20200221120519.43b72007@archlinux/
  Document new sysfs file in Documentation/ABI/testing/sysfs-bus-iio-proximity
- convert bindings to yaml
- bindings: fix typo in near-level property

[1]: https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/merge_requests/298
[2]: https://lore.kernel.org/linux-iio/20200210154153.GA26903@bogon.m.sigxcpu.org/

To: Tomas Novotny <tomas@novotny.cz>, Jonathan Cameron <jic23@kernel.org>,Hartmut Knaack <knaack.h@gmx.de>,Lars-Peter Clausen <lars@metafoo.de>,Peter Meerwald-Stadler <pmeerw@pmeerw.net>,"Angus Ainslie (Purism)" <angus@akkea.ca>,"Guido Günther" <agx@sigxcpu.org>,Marco Felsch <m.felsch@pengutronix.de>,Thomas Gleixner <tglx@linutronix.de>,linux-iio@vger.kernel.org,linux-kernel@vger.kernel.org,devicetree@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,Nishant Malpani <nish.malpani25@gmail.com>


Guido Günther (4):
  dt-bindings: iio: vcnl4000: convert bindings to YAML format
  dt-bindings: iio: light: vcnl4000: Add near-level
  iio: vcnl4000: Export near level property for proximity sensor
  Documentation: ABI: document IIO in_proximity_near_level file

 .../ABI/testing/sysfs-bus-iio-proximity       | 10 ++++
 .../bindings/iio/light/vcnl4000.txt           | 24 ---------
 .../bindings/iio/light/vishay,vcnl4000.yaml   | 53 +++++++++++++++++++
 drivers/iio/light/vcnl4000.c                  | 25 +++++++++
 4 files changed, 88 insertions(+), 24 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-proximity
 delete mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4000.txt
 create mode 100644 Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml

Comments

Jonathan Cameron March 29, 2020, 9:27 a.m. UTC | #1
On Wed, 25 Mar 2020 12:09:08 +0100
Guido Günther <agx@sigxcpu.org> wrote:

> The vcnl4000 IIO driver introduced a new attribute
> "in_proximity_near_level".  This adds it to the list of documented ABI
> for sysfs-bus-iio.

Description and patch title are now wrong due to dropping the _

I can fix that up whilst applying if nothing else comes up.

The rest of the series looks good to me, just giving time
for others to comment before taking this.

Thanks,

Jonathan

> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio-proximity | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-proximity
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-proximity b/Documentation/ABI/testing/sysfs-bus-iio-proximity
> new file mode 100644
> index 000000000000..2172f3bb9c64
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-proximity
> @@ -0,0 +1,10 @@
> +What:		/sys/bus/iio/devices/iio:deviceX/in_proximity_nearlevel
> +Date:		March 2020
> +KernelVersion:	5.7
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Near level for proximity sensors. This is a single integer
> +		value that tells user space when an object should be
> +		considered close to the device. If the value read from the
> +		sensor is above or equal to the value in this file an object
> +		should typically be considered near.