| Message ID | cover.1578134779.git.agx@sigxcpu.org |
|---|---|
| Headers | show |
| Series | leds: lm3692x: Allow to set ovp and brigthness mode | expand |
Hi! > Overvoltage protection and brightness mode are currently hardcoded > as 29V and disabled in the driver. Make these configurable via DT. > > Besides addressing review comments v3 folds in the patches to > disable the chip and turn of the regulator on brightness 0 from > > https://lore.kernel.org/linux-leds/20191226101419.GE4033@amd/T/#t > > Besides addressing review comments v2 also allows to limit the maximum led > current. > Patches are against next-20191220. I applied everything but the "exponential" changes and the last one. I'll apply the last one if I get version that applies on top of leds tree. Best regards, Pavel
Hi, On Mon, Jan 06, 2020 at 12:47:08AM +0100, Pavel Machek wrote: > Hi! > > > Overvoltage protection and brightness mode are currently hardcoded > > as 29V and disabled in the driver. Make these configurable via DT. > > > > Besides addressing review comments v3 folds in the patches to > > disable the chip and turn of the regulator on brightness 0 from > > > > https://lore.kernel.org/linux-leds/20191226101419.GE4033@amd/T/#t > > > > Besides addressing review comments v2 also allows to limit the maximum led > > current. > > > Patches are against next-20191220. > > I applied everything but the "exponential" changes and the last > one. I'll apply the last one if I get version that applies on top of > leds tree. Thanks! Can I do anything to get the exponential part in? Is it because you want the exponential mode to move to the backlight binding? Cheers, -- Guido > > Best regards, > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi! > > > Patches are against next-20191220. > > > > I applied everything but the "exponential" changes and the last > > one. I'll apply the last one if I get version that applies on top of > > leds tree. > > Thanks! Can I do anything to get the exponential part in? Is it because > you want the exponential mode to move to the backlight binding? You'd have to do some serious convincing, explaining why we absolutely need the exponential stuff. Most devices today use linear brightness, and userspace needs to know the relation, especially for RGB stuff. You can set bigger max-brightness, and then do in-driver conversion to use full dynamic brightness range...? Best regards, Pavel
Overvoltage protection and brightness mode are currently hardcoded as 29V and disabled in the driver. Make these configurable via DT. Besides addressing review comments v3 folds in the patches to disable the chip and turn of the regulator on brightness 0 from https://lore.kernel.org/linux-leds/20191226101419.GE4033@amd/T/#t Besides addressing review comments v2 also allows to limit the maximum led current. Patches are against next-20191220. Changes from v2 - As per review comment from Pavel Machek https://lore.kernel.org/linux-leds/20191226100615.GA4033@amd/T/#u - Use default value in DT example https://lore.kernel.org/linux-leds/20191226100842.GC4033@amd/T/#u - Use uppercase LED in commit message https://lore.kernel.org/linux-leds/20191226101336.GD4033@amd/T/#u - Fix typo in commit message - Use correct return value when checking if property is present - Fold in https://lore.kernel.org/linux-leds/20191226101419.GE4033@amd/T/#t - Add Acked-By's from Pavel Machek, thanks! Changes from v1 - As per review comments by Dan Murphy https://lore.kernel.org/linux-leds/3d66b07d-b4c5-43e6-4378-d63cc84b8d43@ti.com/ - Split commits per propoerty - Add new properties to DT example too - Drop dev_dbg() statements - ovp: fix 21V value parsing - ovp: Set correct default value if DT parsing fails - As per review comments by Pavel Machek https://lore.kernel.org/linux-leds/20191221191515.GF32732@amd/ - Fix defaults (which is 29V) - Use uV as Unit for ovp property - Change property name to 'ti,ovp-microvolt' to make it shorter - Honor led-max-microamp to not exceed the maximum led current Guido Günther (9): dt: bindings: lm3692x: Add ti,ovp-microvolt property leds: lm3692x: Allow to configure over voltage protection dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property leds: lm3692x: Allow to configure brigthness mode dt: bindings: lm3692x: Add led-max-microamp property leds: lm3692x: Make sure we don't exceed the maximum led current leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable leds: lm3692x: Split out lm3692x_leds_disable leds: lm3692x: Disable chip on brightness 0 .../devicetree/bindings/leds/leds-lm3692x.txt | 11 + drivers/leds/leds-lm3692x.c | 195 +++++++++++++----- 2 files changed, 149 insertions(+), 57 deletions(-)