mbox series

[v1,0/6] Initial support for Samsung Galaxy Tab 2 series

Message ID 20241030194136.297648-1-bavishimithil@gmail.com
Headers show
Series Initial support for Samsung Galaxy Tab 2 series | expand

Message

Mithil Bavishi Oct. 30, 2024, 7:41 p.m. UTC 
This series adds initial support for the Samsung Galaxy Tab 2
(samsung-espresso*) series of devices. It adds support for 6 variants
(P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them
based on 3G and WiFi, but since they use different panel, touch
controllers, batteries, I decided to categorise them based on screen
size as espresso7 and espresso10.

It adds basic functionality for both the models including panel, drm,
sdcard, touchscreen, mmc, wifi, bluetooth, keys, battery, fuel gauge,
pmic, sensors.

Mithil Bavishi (6):
  ARM: dts: twl6032: Add DTS file for TWL6032 PMIC
  arm/dts: Add common device tree for Samsung Galaxy Tab 2 series
  dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0
  arm/dts: Add initial support for Galaxy Tab 2 7.0
  dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1
  arm/dts: Add initial support for Galaxy Tab 2 10.1

 .../devicetree/bindings/arm/ti/omap.yaml      |   2 +
 arch/arm/boot/dts/ti/omap/Makefile            |   2 +
 .../omap/omap4-samsung-espresso-common.dtsi   | 694 ++++++++++++++++++
 .../dts/ti/omap/omap4-samsung-espresso10.dts  | 102 +++
 .../dts/ti/omap/omap4-samsung-espresso7.dts   |  70 ++
 arch/arm/boot/dts/ti/omap/twl6032.dtsi        |  81 ++
 6 files changed, 951 insertions(+)
 create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso-common.dtsi
 create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts
 create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
 create mode 100644 arch/arm/boot/dts/ti/omap/twl6032.dtsi

Comments

Andreas Kemnade Oct. 30, 2024, 7:55 p.m. UTC | #1 
Hi,

a quick first pass of review.

Am Wed, 30 Oct 2024 19:41:32 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> Create common device tree for Samsung Espresso series devices
> 
> Differentiate based on screen sizes, panels, touch controllers,
> and batteries
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> ---
[...]

> +	backlight_pins: pinmux_backlight_pins {

- instead of _ in node names please, also for other places:
    backlight_pins: pinmux-backlight-pins

[...]
> +
> +#include "twl6030.dtsi"
> +
really??? you include both twl6030 and twl6032. That does not make any
sense. Including twl6030_omap4.dtsi might make sense but not
twl6030.dtsi.

Regards,
Andreas
Andreas Kemnade Oct. 30, 2024, 8:37 p.m. UTC | #2 
Am Wed, 30 Oct 2024 19:41:34 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> Create a device tree for the 3 inch variants (P3100, P3110, P3113)
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> ---
>  arch/arm/boot/dts/ti/omap/Makefile            |  1 +
>  .../dts/ti/omap/omap4-samsung-espresso7.dts   | 70
> +++++++++++++++++++ 2 files changed, 71 insertions(+)
>  create mode 100644
> arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> 
  DTC     arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb
arch/arm/boot/dts/ti/omap/twl6032.dtsi:67.37-70.4: ERROR
(phandle_references):
/ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/usb-comparator:
Reference to non-existent node or label "ldosb"

  also defined at arch/arm/boot/dts/ti/omap/twl6030.dtsi:83.37-86.4
  also defined at
  arch/arm/boot/dts/ti/omap/omap4-samsung-espresso-common.dtsi:616.21-618.3
  ERROR: Input tree has errors, aborting (use -f to force output)

I think you accidently submitted a wrong/outdated version. You had
removed the twl6030.dtsi include in pmOS after I pointed that out to
you in an issue there. Any further review is futile.

From:
https://gitlab.com/postmarketOS/pmaports/-/issues/2825:
>Mighty
>@MightyM17
>ยท 4 months ago
>Reporter
>Oh, there's a hanging include "twl6030.dtsi" thats causing us trouble,
>I'll port the usb regs and comparator to twl6032.dtsi and it should
>work fine.

that is a clear sign that somehow an old version seems to pop up.

Regards,
Andreas