| Message ID | 20241023060352.605019-1-quic_rajkbhag@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Add WSI node for QCN9274 in RDP433 for MLO | expand |
On 23/10/2024 08:03, Raj Kumar Bhagat wrote: > From: Harshitha Prem <quic_hprem@quicinc.com> > > Currently, single device is part of device group abstraction but for multi > link operation, multiple devices have to be combined together. Information > of how many devices involved in grouping can be parsed from device tree and > it would have the valid group id information as well. > > Add changes to parse devices involved and group id from device tree file > to form device group > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Harshitha Prem <quic_hprem@quicinc.com> > Co-developed-by: Aditya Kumar Singh <quic_adisi@quicinc.com> > Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Missing SoB. What does Kalle SoB do here? Please read carefully submitting patches. Best regards, Krzysztof
On 23/10/2024 08:03, Raj Kumar Bhagat wrote: > The RDP433 is a Qualcomm Reference Design Platform based on the > IPQ9574. It has three QCN9274 WiFi devices connected to PCIe1, PCIe2, > and PCIe3. These devices are also connected among themselves via > WSI connection. This WSI connection is essential to exchange control > information among these devices > > The WSI connection in RDP433 is represented below: > > +-------+ +-------+ +-------+ > | pcie2 | | pcie3 | | pcie1 | > | | | | | | > +----->| wsi |------->| wsi |------->| wsi |-----+ > | | idx 0 | | idx 1 | | idx 2 | | > | +-------+ +-------+ +-------+ | > +------------------------------------------------------+ > > Based on the above, the WSI properties for QCN9274 at pcie2 are: > qcom,wsi-group-id = 0 > qcom,wsi-index = 0 > qcom,wsi-num-devices = 3; > > Hence, add WiFi nodes with WSI properties for all three QCN9274 > devices connected to RDP433. > > Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 62 ++++++++++++++++++++- > 1 file changed, 61 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index 165ebbb59511..2241e20ad42a 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -3,7 +3,7 @@ > * IPQ9574 RDP433 board device tree source > * > * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved. > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > /dts-v1/; > @@ -27,6 +27,26 @@ &pcie1 { > perst-gpios = <&tlmm 26 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 27 GPIO_ACTIVE_LOW>; > status = "okay"; > + > + pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + wifi1@0 { > + compatible = "pci17cb,1109"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + status = "okay"; Why? > + > + wsi { > + qcom,wsi-group-id = <0>; So all devices have the same group id? No other group id? So hard-code it at 0? > + qcom,wsi-index = <2>; > + qcom,wsi-num-devices = <3>; All this looks opposite how we organize usually DTS. Instead of phandles you pass some sort of indices. Instead of re-using some existing properties for remoteproc-related stuff, you add three more. Best regards, Krzysztof
The RDP433 is a Qualcomm Reference Design Platform based on the IPQ9574. It features three QCN9274 WiFi devices connected to PCIe1, PCIe2, and PCIe3. These devices are also interconnected via a WLAN Serial Interface (WSI) connection. This WSI connection is essential to exchange control information among these devices. This patch series describes the WSI interface found in QCN9274 and uses this device-tree node in the Ath12k driver to provide details of adjacent devices in Multi Link Operation (MLO) among multiple QCN9274 devices. NOTES: 1. As ath12k MLO patches are not ready yet, this patchset does not apply to the ath.git ath-next branch and that's why the patchset is marked as RFC. These are the work-in-progress patches we have at the moment. The full set of MLO patches is available at: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath12k-mlo-qcn9274 2. The dependency marked below applies only to the DTS patch. The dt-bindings patches do not have this dependency. Depends-On: [PATCH V7 0/4] Add PCIe support for IPQ9574 Link: https://lore.kernel.org/linux-pci/20240801054803.3015572-1-quic_srichara@quicinc.com/ Aditya Kumar Singh (1): wifi: ath12k: assign unique hardware link IDs during QMI host cap Harshitha Prem (1): wifi: ath12k: parse multiple device information from device tree Karthikeyan Periyasamy (1): wifi: ath12k: Send partner device details in QMI MLO capability Raj Kumar Bhagat (3): dt-bindings: net: wireless: update required properties for ath12k PCI module dt-bindings: net: wireless: ath12k: describe WSI property for QCN9274 arm64: dts: qcom: ipq9574: Add WiFi nodes for RDP433 .../bindings/net/wireless/qcom,ath12k.yaml | 90 +++++++++++++-- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 62 +++++++++- drivers/net/wireless/ath/ath12k/core.c | 106 ++++++++++++++++-- drivers/net/wireless/ath/ath12k/core.h | 2 + drivers/net/wireless/ath/ath12k/qmi.c | 98 +++++++++++++--- 5 files changed, 322 insertions(+), 36 deletions(-) base-commit: 7603a9349b2fc64152a734f253cf8d8e5befb6db prerequisite-patch-id: d1334693a2e8da65ae7b458ee4adb459850ad2e7 prerequisite-patch-id: 87f73b342f67c2636390a7da1294cee90f1fff48 prerequisite-patch-id: 46d8302766527d16cdd90c59ded6cbae0ec4ad70 prerequisite-patch-id: b17db6783b1c35f3e8812f621730fe0a1a57a14e