mbox series

[v3,0/2] pinctrl: qcom: Introduce Pinctrl for QCS8300

Message ID 20241018-qcs8300_tlmm-v3-0-8b8d3957cf1a@quicinc.com
Headers show
Series pinctrl: qcom: Introduce Pinctrl for QCS8300 | expand

Message

Jingyi Wang Oct. 18, 2024, 3:19 a.m. UTC 
Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
QCS8300 SoC.

Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
Changes in v3:
- fix ngpios num in tlmm driver
- change the name of callback from "remove_new" to "remove"
- Link to v2: https://lore.kernel.org/r/20241009-qcs8300_tlmm-v2-0-9e40dee5e4f1@quicinc.com

Changes in v2:
- Add Reviewed-by tag for binding change
- Patch rebased on new tag to avoid conflict
- codestyle fixup
- Link to v1: https://lore.kernel.org/r/20240819064933.1778204-1-quic_jingyw@quicinc.com

---
Jingyi Wang (2):
      dt-bindings: pinctrl: describe qcs8300-tlmm
      pinctrl: qcom: add the tlmm driver for QCS8300 platforms

 .../bindings/pinctrl/qcom,qcs8300-tlmm.yaml        |  118 ++
 drivers/pinctrl/qcom/Kconfig.msm                   |    7 +
 drivers/pinctrl/qcom/Makefile                      |    1 +
 drivers/pinctrl/qcom/pinctrl-qcs8300.c             | 1246 ++++++++++++++++++++
 4 files changed, 1372 insertions(+)
---
base-commit: 7df1e7189cecb6965ce672e820a5ec6cf499b65b
change-id: 20241018-qcs8300_tlmm-8f529206edb7

Best regards,

Comments

Andrew Lunn Oct. 18, 2024, 6:08 p.m. UTC | #1 
On Fri, Oct 18, 2024 at 11:19:30AM +0800, Jingyi Wang wrote:
> Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
> QCS8300 SoC.
> 
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>

I'm curious why you are Cc: netdev for a pin controller patch?  Did
./scripts/get_maintainer.pl say you should?

    Andrew

---
pw-bot: cr
Jingyi Wang Oct. 21, 2024, 2:32 a.m. UTC | #2 
On 10/19/2024 2:08 AM, Andrew Lunn wrote:
> On Fri, Oct 18, 2024 at 11:19:30AM +0800, Jingyi Wang wrote:
>> Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
>> QCS8300 SoC.
>>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> 
> I'm curious why you are Cc: netdev for a pin controller patch?  Did
> ./scripts/get_maintainer.pl say you should?
> 
The cc list was generated by the b4 tools.
>     Andrew
> 
> ---
> pw-bot: cr

Thanks,
Jingyi
Jingyi Wang Oct. 21, 2024, 4:27 a.m. UTC | #3 
On 10/21/2024 10:32 AM, Jingyi Wang wrote:
> 
> 
> On 10/19/2024 2:08 AM, Andrew Lunn wrote:
>> On Fri, Oct 18, 2024 at 11:19:30AM +0800, Jingyi Wang wrote:
>>> Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
>>> QCS8300 SoC.
>>>
>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>>
>> I'm curious why you are Cc: netdev for a pin controller patch?  Did
>> ./scripts/get_maintainer.pl say you should?
>>
> The cc list was generated by the b4 tools.

double checked with ./scripts/get_maintainer.pl, also get the list:
netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_))

I think the list should be added for keyword match in the driver.

>>     Andrew
>>
>> ---
>> pw-bot: cr
> 
> Thanks,
> Jingyi
> 
Thanks,
Jingyi
Andrew Lunn Oct. 21, 2024, 4:04 p.m. UTC | #4 
On Mon, Oct 21, 2024 at 12:27:36PM +0800, Jingyi Wang wrote:
> 
> 
> On 10/21/2024 10:32 AM, Jingyi Wang wrote:
> > 
> > 
> > On 10/19/2024 2:08 AM, Andrew Lunn wrote:
> >> On Fri, Oct 18, 2024 at 11:19:30AM +0800, Jingyi Wang wrote:
> >>> Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
> >>> QCS8300 SoC.
> >>>
> >>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> >>
> >> I'm curious why you are Cc: netdev for a pin controller patch?  Did
> >> ./scripts/get_maintainer.pl say you should?
> >>
> > The cc list was generated by the b4 tools.
> 
> double checked with ./scripts/get_maintainer.pl, also get the list:
> netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_))
> 
> I think the list should be added for keyword match in the driver.

I assume this is a PTP pin probably a 1 pps output, not an actual PTP
driver hidden within the pinctrl? If so, please edit the list and
remove netdev and Richard. You might want to review the other emails
and see if they all make sense.

	Andrew
Linus Walleij Oct. 22, 2024, 12:42 p.m. UTC | #5 
On Fri, Oct 18, 2024 at 5:20 AM Jingyi Wang <quic_jingyw@quicinc.com> wrote:

> Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm
> QCS8300 SoC.
>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>

ACKs on bindings, up to v3 and no maintainer comments, driver
looks fairly standard. Patches applied!

Yours,
Linus Walleij