| Message ID | 20240920-bcmbca-leds-v1-0-5f70e692c6ff@linaro.org |
|---|---|
| Headers | show |
| Series | leds: Add basic BCMBCA LEDs support | expand |
On 2024-09-20 13:15, Linus Walleij wrote: > The Broadcom BCA (Broadband Access) SoCs have a LED control > block that can support either parallel (directly connected) > LEDs or serial (connected to 1-4 shift registers) LEDs. > > Add a driver for that hardware. There is an existing driver for this hw block, please see: drivers/leds/blink/leds-bcm63138.c It may need some work (I didn't compare your submission with my minimal driver) and I think it would be preferred over adding a new driver for the same hw.
On Fri, Sep 20, 2024 at 1:30 PM Rafał Miłecki <rafal@milecki.pl> wrote: > On 2024-09-20 13:15, Linus Walleij wrote: > > The Broadcom BCA (Broadband Access) SoCs have a LED control > > block that can support either parallel (directly connected) > > LEDs or serial (connected to 1-4 shift registers) LEDs. > > > > Add a driver for that hardware. > > There is an existing driver for this hw block, please see: > drivers/leds/blink/leds-bcm63138.c Gah how could I miss this ... I will test with this driver and then add any stuff I need. Thanks! Linus Walleij
This series adds bindings and a driver for the Broadcom BCA (Broadband Access) SoC LEDs. These LEDs can be either serial using 1-4 shift registers or parallel using unique lines per-LED. The LED controller supports hardware triggers from an integrated ethernet switch, this support can be added later, the modern hardware control framework is complex and will require phandles and elaborate lookup of the corresponding netdev etc. The patches were developed and tested on the Genexis XG6846B device using the BCM6846 SoC. Broadcom guys: if you would rather take sole maintenanceship of this or be listed as comaintainers, tell me, it's fine. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Linus Walleij (2): dt-bindings: leds: bcmbca: Add bindings for BRCMBCA LEDs leds: bcmbca: Add new driver for Broadcom BCMBCA .../devicetree/bindings/leds/brcm,bcmbca-leds.yaml | 88 +++++ MAINTAINERS | 7 + drivers/leds/Kconfig | 9 + drivers/leds/Makefile | 1 + drivers/leds/leds-bcmbca.c | 391 +++++++++++++++++++++ 5 files changed, 496 insertions(+) --- base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652 change-id: 20240920-bcmbca-leds-e6f16f55cfd9 Best regards,